chore(build): resolve build warnings in amplify package (#4031)

Author: thisisabhash

Amplify/DevMenu/AmplifyDevMenu.swift

@@ -13,7 +13,7 @@ import UIKit
 /// Presents a developer menu using the provided `DevMenuPresentationContextProvider`
 /// upon notification from a `TriggerRecognizer`. Default recognizer is a `LongPressGestureRecognizer`
 @MainActor
-public final class AmplifyDevMenu: DevMenuBehavior, TriggerDelegate {
+public final class AmplifyDevMenu: @preconcurrency DevMenuBehavior, @preconcurrency TriggerDelegate {
 
     weak var devMenuPresentationContextProvider: DevMenuPresentationContextProvider?
     var triggerRecognizer: TriggerRecognizer?

Amplify/DevMenu/View/IssueReporter.swift

@@ -97,11 +97,11 @@ struct IssueReporter: View {
     /// Open Amplify iOS issue logging screen on Github
     private func reportToGithub() {
         Task {
-            let issue = await IssueInfo(issueDescription: issueDescription,
+            let issue = IssueInfo(issueDescription: issueDescription,
                                         includeEnvInfo: includeEnvInfo,
                                         includeDeviceInfo: includeDeviceInfo)
             let issueDescriptionMarkdown =
-                await IssueInfoHelper.generateMarkdownForIssue(
+                IssueInfoHelper.generateMarkdownForIssue(
                     issue: issue)
 
             let urlString = amplifyIosNewIssueUrl + issueDescriptionMarkdown
@@ -122,10 +122,10 @@ struct IssueReporter: View {
     /// Copy issue as a markdown string to clipboard
     private func copyToClipboard() {
         Task {
-            let issue = await IssueInfo(issueDescription: issueDescription,
+            let issue = IssueInfo(issueDescription: issueDescription,
                                   includeEnvInfo: includeEnvInfo,
                                   includeDeviceInfo: includeDeviceInfo)
-            let value = await IssueInfoHelper.generateMarkdownForIssue(issue: issue)
+            let value = IssueInfoHelper.generateMarkdownForIssue(issue: issue)
             #if os(iOS)
             UIPasteboard.general.string = value
             #elseif canImport(AppKit)

AmplifyPlugins/API/Sources/AWSAPIPlugin/Operation/AWSGraphQLSubscriptionTaskRunner.swift

@@ -407,7 +407,7 @@ fileprivate func toAPIError<R: Decodable>(_ errors: [Error], type: R.Type) -> AP
             GraphQLResponseError<R>.error(errors)
         )
 
-    case let errors as [WebSocketClient.Error]:
+    case _ as [WebSocketClient.Error]:
         return APIError.networkError("WebSocketClient connection aborted", nil, URLError(.networkConnectionLost))
     default:
         return APIError.operationError(

AmplifyPlugins/API/Tests/AWSAPIPluginTests/APISwiftCompatibility/APISwiftTests.swift

@@ -13,15 +13,14 @@ final class APISwiftTests: XCTestCase {
     func testCreateBlogMutation() {
         let file = S3ObjectInput(bucket: "bucket", key: "let", region: "region")
         let input = CreateBlogInput(name: "name", file: file)
-        let condition = ModelBlogConditionInput(name: .init(eq: "name"))
         let mutation = CreateBlogMutation(input: input)
 
         let request = GraphQLRequest<CreateBlogMutation.Data>(
             document: CreateBlogMutation.requestString,
             variables: mutation.variables?.jsonObject,
             responseType: CreateBlogMutation.Data.self)
 
-        var expectedDocument = """
+        let expectedDocument = """
         mutation CreateBlog($input: CreateBlogInput!, $condition: ModelBlogConditionInput) {
           createBlog(input: $input, condition: $condition) {
             __typename

AmplifyPlugins/API/Tests/AWSAPIPluginTests/AppSyncRealTimeClient/AppSyncRealTimeClientTests.swift

@@ -554,7 +554,6 @@ class AppSyncRealTimeClientTests: XCTestCase {
 
     func testReconnect_whenHeartBeatSignalIsNotReceived() async throws {
         var cancellables = Set<AnyCancellable>()
-        let timeout = 1.0
         let mockWebSocketClient = MockWebSocketClient()
         let mockAppSyncRequestInterceptor = MockAppSyncRequestInterceptor()
         let appSyncClient = AppSyncRealTimeClient(

AmplifyPlugins/API/Tests/AWSAPIPluginTests/Interceptor/AuthTokenURLRequestInterceptorTests.swift

@@ -46,7 +46,7 @@ class AuthTokenURLRequestInterceptorTests: XCTestCase {
         do {
             _ = try await interceptor.intercept(request).allHTTPHeaderFields
         } catch {
-            guard case .operationError(let description, _, let underlyingError) = error as? APIError,
+            guard case .operationError(_, _, let underlyingError) = error as? APIError,
                let authError = underlyingError as? AuthError,
                case .sessionExpired = authError else {
                 XCTFail("Should be API.operationError with underlying AuthError.sessionExpired")

AmplifyPlugins/API/Tests/AWSAPIPluginTests/Support/Decode/GraphQLResponseDecoderPostComment4V2Tests.swift

@@ -320,7 +320,7 @@ class GraphQLResponseDecoderPostComment4V2Tests: XCTestCase, SharedTestCasesPost
         XCTAssertEqual(input["postID"] as? String, post.id)
 
         let decoder = GraphQLResponseDecoder(request: request.toOperationRequest(operationType: .query))
-        var graphQLData: [String: JSONValue] = [
+        let graphQLData: [String: JSONValue] = [
             "\(request.decodePath!)": [
                 "id": "id",
                 "content": "content",

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/ASF/CognitoUserPoolASF+KeyChain.swift

@@ -33,7 +33,7 @@ extension CognitoUserPoolASF {
                                asfDeviceId: String,
                                asfClient: AdvancedSecurityBehavior,
                                userPoolConfiguration: UserPoolConfigurationData) async -> String? {
-        let deviceInfo: ASFDeviceBehavior = await ASFDeviceInfo(id: asfDeviceId)
+        let deviceInfo: ASFDeviceBehavior = ASFDeviceInfo(id: asfDeviceId)
         let appInfo: ASFAppInfoBehavior = ASFAppInfo()
 
         do {

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Models/AWSAuthCognitoSession.swift

@@ -64,12 +64,7 @@ public struct AWSAuthCognitoSession: AuthSession,
             return .failure(AuthError.signedOut(
                             AuthPluginErrorConstants.userSubSignOutError.errorDescription,
                             AuthPluginErrorConstants.userSubSignOutError.recoverySuggestion))
-        } catch let error as AuthError {
-            return .failure(error)
         } catch {
-            let error = AuthError.unknown("""
-                            Could not retreive user sub from the fetched Cognito tokens.
-                            """)
             return .failure(error)
         }
     }

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/StateMachine/CodeGen/Errors/AuthenticationError.swift

@@ -42,7 +42,7 @@ extension AuthenticationError: Codable {
         switch self {
         case .configuration(let message):
             try container.encode(message, forKey: .configuration)
-        case .service(let message, let error):
+        case .service(let message, _):
             try container.encode(message, forKey: .service)
         case .unknown(let message):
             try container.encode(message, forKey: .unknown)