Skip to content

Commit 6591394

Browse files
authored
chore: kickoff release
2 parents ccfa6a5 + 0747f47 commit 6591394

File tree

20 files changed

+108
-86
lines changed

20 files changed

+108
-86
lines changed

AmplifyPlugins/API/Sources/AWSAPIPlugin/AWSAPIPlugin+Configure.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public extension AWSAPIPlugin {
3838
configure(using: dependencies)
3939

4040
// Initialize SwiftSDK's CRT dependency for SigV4 signing functionality
41-
AwsCommonRuntimeKit.initialize()
41+
CommonRuntimeKit.initialize()
4242

4343
log.info("Configure finished")
4444
}

AmplifyPlugins/Auth/Tests/AWSCognitoAuthPluginUnitTests/TaskTests/AuthenticationProviderDeleteUserTests.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,7 @@ class AuthenticationProviderDeleteUserTests: BasePluginTest {
8484
try GlobalSignOutOutputResponse(httpResponse: .init(body: .empty, statusCode: .ok))
8585
},
8686
mockDeleteUserOutputResponse: { _ in
87-
let crtError = ClientRuntime.ClientError.retryError(
88-
CRTError.crtError(
89-
AWSError(errorCode: 1059)))
87+
let crtError = ClientRuntime.ClientError.retryError(CommonRunTimeError.crtError(CRTError(code: 1059)))
9088
throw SdkError<DeleteUserOutputError>.client(crtError)
9189
}
9290
)
@@ -121,9 +119,7 @@ class AuthenticationProviderDeleteUserTests: BasePluginTest {
121119
try GlobalSignOutOutputResponse(httpResponse: .init(body: .empty, statusCode: .ok))
122120
},
123121
mockDeleteUserOutputResponse: { _ in
124-
let crtError = ClientRuntime.ClientError.retryError(
125-
CRTError.crtError(
126-
AWSError(errorCode: 1059)))
122+
let crtError = ClientRuntime.ClientError.retryError(CommonRunTimeError.crtError(CRTError(code: 1059)))
127123
throw SdkError<DeleteUserOutputError>.client(crtError)
128124
}
129125
)

AmplifyPlugins/Auth/Tests/AuthHostApp/AuthHostApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

AmplifyPlugins/Core/AWSPluginsCore/Auth/Provider/AmplifyAWSCredentialsProvider.swift

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@
88
import Amplify
99
import AWSClientRuntime
1010
import AwsCommonRuntimeKit
11+
import Foundation
1112

12-
public class AmplifyAWSCredentialsProvider: CredentialsProvider {
13+
public class AmplifyAWSCredentialsProvider: AWSClientRuntime.CredentialsProvider {
1314

1415
public func getCredentials() async throws -> AWSClientRuntime.AWSCredentials {
1516
let authSession = try await Amplify.Auth.fetchAuthSession()
@@ -27,20 +28,16 @@ extension AWSCredentials {
2728

2829
func toAWSSDKCredentials() -> AWSClientRuntime.AWSCredentials {
2930
if let tempCredentials = self as? AWSTemporaryCredentials {
30-
31-
let expirationTimeSinceNow = tempCredentials.expiration.timeIntervalSinceNow
32-
let expirationTimeout = UInt64(max(0, expirationTimeSinceNow))
33-
3431
return AWSClientRuntime.AWSCredentials(
3532
accessKey: tempCredentials.accessKeyId,
3633
secret: tempCredentials.secretAccessKey,
37-
expirationTimeout: expirationTimeout,
34+
expirationTimeout: tempCredentials.expiration,
3835
sessionToken: tempCredentials.sessionToken)
3936
} else {
4037
return AWSClientRuntime.AWSCredentials(
4138
accessKey: accessKeyId,
4239
secret: secretAccessKey,
43-
expirationTimeout: 0)
40+
expirationTimeout: Date())
4441
}
4542

4643
}

AmplifyPlugins/Core/AWSPluginsCore/Auth/Provider/AmplifyAWSSignatureV4Signer.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import AwsCommonRuntimeKit
1313

1414
public protocol AWSSignatureV4Signer {
1515
func sigV4SignedRequest(requestBuilder: SdkHttpRequestBuilder,
16-
credentialsProvider: CredentialsProvider,
16+
credentialsProvider: AWSClientRuntime.CredentialsProvider,
1717
signingName: Swift.String,
1818
signingRegion: Swift.String,
1919
date: ClientRuntime.Date) async throws -> SdkHttpRequest?
@@ -24,7 +24,7 @@ public class AmplifyAWSSignatureV4Signer: AWSSignatureV4Signer {
2424
}
2525

2626
public func sigV4SignedRequest(requestBuilder: SdkHttpRequestBuilder,
27-
credentialsProvider: CredentialsProvider,
27+
credentialsProvider: AWSClientRuntime.CredentialsProvider,
2828
signingName: Swift.String,
2929
signingRegion: Swift.String,
3030
date: ClientRuntime.Date) async throws -> SdkHttpRequest? {
@@ -43,7 +43,8 @@ public class AmplifyAWSSignatureV4Signer: AWSSignatureV4Signer {
4343
date: date,
4444
service: signingName,
4545
region: signingRegion,
46-
signatureType: .requestHeaders)
46+
signatureType: .requestHeaders,
47+
signingAlgorithm: .sigv4)
4748

4849
let httpRequest = await AWSSigV4Signer.sigV4SignedRequest(requestBuilder: requestBuilder, signingConfig: signingConfig)
4950
return httpRequest

AmplifyPlugins/Core/AWSPluginsCore/Utils/CustomHttpClientEngine/UserAgentSuffixAppender.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,4 @@ extension UserAgentSuffixAppender: HttpClientEngine {
3434
request.headers = headers
3535
return try await target.execute(request: request)
3636
}
37-
38-
public func close() async {
39-
await target?.close()
40-
}
4137
}

AmplifyPlugins/Core/AWSPluginsCoreTests/Utils/UserAgentSuffixAppenderTests.swift

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,6 @@ class UserAgentSuffixAppenderTests: XCTestCase {
6969
}
7070
}
7171

72-
/// Given: A UserAgentSuffixAppender with a configured httpClientEngine
73-
/// When: close is invoked
74-
/// Then: The httpClientEngine's close API should be called
75-
func testClose_shouldInvokeClose() async {
76-
await appender.close()
77-
XCTAssertEqual(httpClientEngine.closeCount, 1)
78-
}
79-
8072
private func createRequest() -> SdkHttpRequest {
8173
return SdkHttpRequest(
8274
method: .get,
@@ -94,9 +86,4 @@ private class MockHttpClientEngine: HttpClientEngine {
9486
executeRequest = request
9587
return .init(body: .empty, statusCode: .accepted)
9688
}
97-
98-
var closeCount = 0
99-
func close() async {
100-
closeCount += 1
101-
}
10289
}

AmplifyPlugins/Core/AWSPluginsTestCommon/MockAWSAuthService.swift

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,6 @@ struct MyCustomCredentialsProvider: CredentialsProvider {
6666
AWSCredentials(
6767
accessKey: "AKIDEXAMPLE",
6868
secret: "wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY",
69-
expirationTimeout: 30)
70-
}
71-
72-
func getCredentials() throws -> SdkFuture<AWSClientRuntime.AWSCredentials> {
73-
let future = SdkFuture<AWSClientRuntime.AWSCredentials>()
74-
future.fulfill(AWSCredentials(
75-
accessKey: "AKIDEXAMPLE",
76-
secret: "wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY",
77-
expirationTimeout: 30))
78-
return future
69+
expirationTimeout: Date().addingTimeInterval(30))
7970
}
8071
}

AmplifyPlugins/Geo/Tests/AWSLocationGeoPluginTests/Mocks/MockAWSClientConfiguration.swift

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,20 @@ import XCTest
1515
@testable import AWSPluginsTestCommon
1616

1717
class MockAWSClientConfiguration: LocationClientConfigurationProtocol {
18+
var encoder: ClientRuntime.RequestEncoder?
19+
20+
var decoder: ClientRuntime.ResponseDecoder?
21+
22+
var httpClientEngine: ClientRuntime.HttpClientEngine
23+
24+
var httpClientConfiguration: ClientRuntime.HttpClientConfiguration
25+
26+
var idempotencyTokenGenerator: ClientRuntime.IdempotencyTokenGenerator
27+
28+
var clientLogMode: ClientRuntime.ClientLogMode
29+
30+
var partitionID: String?
31+
1832
var useFIPS: Bool?
1933

2034
var useDualStack: Bool?
@@ -38,12 +52,18 @@ class MockAWSClientConfiguration: LocationClientConfigurationProtocol {
3852
var retryer: SDKRetryer
3953

4054
init(config: AWSLocationGeoPluginConfiguration) throws {
55+
let defaultSDKRuntimeConfig = try DefaultSDKRuntimeConfiguration("MockAWSClientConfiguration")
56+
57+
self.httpClientEngine = defaultSDKRuntimeConfig.httpClientEngine
58+
self.httpClientConfiguration = defaultSDKRuntimeConfig.httpClientConfiguration
59+
self.idempotencyTokenGenerator = defaultSDKRuntimeConfig.idempotencyTokenGenerator
60+
self.clientLogMode = defaultSDKRuntimeConfig.clientLogMode
4161
self.credentialsProvider = MockAWSAuthService().getCredentialsProvider()
4262
self.region = config.regionName
4363
self.signingRegion = ""
4464
self.endpointResolver = MockEndPointResolver()
4565
self.logger = MockLogAgent()
46-
self.retryer = try SDKRetryer(options: RetryOptions(backOffRetryOptions: ExponentialBackOffRetryOptions()))
66+
self.retryer = try SDKRetryer(options: RetryOptions(jitterMode: .default))
4767
}
4868
}
4969

AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Extensions/SdkError+Pinpoint.swift

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,20 @@ extension SdkError {
2323
return clientError
2424
}
2525

26-
private var crtError: CRTError? {
27-
if case .retryError(let crtError as CRTError) = clientError {
28-
return crtError
26+
private var commonRunTimeError: CommonRunTimeError? {
27+
if case .crtError(let commonRunTimeError) = clientError {
28+
return commonRunTimeError
29+
}
30+
31+
if case .retryError(let commonRunTimeError as CommonRunTimeError) = clientError {
32+
return commonRunTimeError
2933
}
3034

31-
if case .crtError(let crtError) = clientError {
35+
return nil
36+
}
37+
38+
private var crtError: CRTError? {
39+
if case .crtError(let crtError) = commonRunTimeError {
3240
return crtError
3341
}
3442

@@ -44,17 +52,9 @@ extension SdkError {
4452
return putEventsError
4553
}
4654

47-
private var awsError: AWSError? {
48-
guard case .crtError(let awsError) = crtError else {
49-
return nil
50-
}
51-
52-
return awsError
53-
}
54-
5555
public var errorDescription: String {
5656
guard let putEventsOutputError = putEventsOutputError else {
57-
return awsError?.errorMessage ?? localizedDescription
57+
return crtError?.message ?? localizedDescription
5858
}
5959

6060
switch putEventsOutputError {
@@ -75,8 +75,8 @@ extension SdkError {
7575
return putEventsOutputError
7676
}
7777

78-
if crtError != nil {
79-
return crtError
78+
if commonRunTimeError != nil {
79+
return commonRunTimeError
8080
}
8181

8282
guard let clientError = clientError else {
@@ -98,7 +98,7 @@ extension SdkError {
9898
return true
9999
}
100100

101-
guard let awsError = awsError else {
101+
guard let crtError = crtError else {
102102
return false
103103
}
104104

@@ -119,6 +119,6 @@ extension SdkError {
119119
UInt32(AWS_HTTP_STATUS_CODE_408_REQUEST_TIMEOUT.rawValue)
120120
]
121121

122-
return connectivityErrorCodes.contains(where: { $0 == awsError.errorCode })
122+
return connectivityErrorCodes.contains(where: { $0 == crtError.code })
123123
}
124124
}

0 commit comments

Comments
 (0)