Skip to content

Commit 86217f9

Browse files
authored
chore(auth): Fix the build failure in auth cocoapod (#2353)
1 parent b6339cf commit 86217f9

File tree

5 files changed

+50
-41
lines changed

5 files changed

+50
-41
lines changed

AmplifyPlugins/Auth/AWSCognitoAuthPlugin.xcodeproj/project.pbxproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@
134134
B41D10082475AB7E0049D08D /* AWSCognitoAuthPlugin+ClientBehavior.swift in Sources */ = {isa = PBXBuildFile; fileRef = B41D10012475AB7E0049D08D /* AWSCognitoAuthPlugin+ClientBehavior.swift */; };
135135
B41D10092475AB7E0049D08D /* AWSCognitoAuthPlugin+DeviceBehavior.swift in Sources */ = {isa = PBXBuildFile; fileRef = B41D10022475AB7E0049D08D /* AWSCognitoAuthPlugin+DeviceBehavior.swift */; };
136136
B41D100A2475AB7E0049D08D /* AWSCognitoAuthPlugin+UserBehavior.swift in Sources */ = {isa = PBXBuildFile; fileRef = B41D10032475AB7E0049D08D /* AWSCognitoAuthPlugin+UserBehavior.swift */; };
137+
B4304E2C28E227DF00A6AA43 /* AWSCognitoNetworkPreferences.swift in Sources */ = {isa = PBXBuildFile; fileRef = B4304E2B28E227DF00A6AA43 /* AWSCognitoNetworkPreferences.swift */; };
137138
B43B4DD92565E820008F345D /* MockAuthenticationProviderBehavior.swift in Sources */ = {isa = PBXBuildFile; fileRef = B43B4DD82565E820008F345D /* MockAuthenticationProviderBehavior.swift */; };
138139
B43B4DE32565E8D7008F345D /* MockAuthorizationProviderBehavior.swift in Sources */ = {isa = PBXBuildFile; fileRef = B43B4DE22565E8D7008F345D /* MockAuthorizationProviderBehavior.swift */; };
139140
B43B4DFD2565E941008F345D /* MockAuthUserServiceBehavior.swift in Sources */ = {isa = PBXBuildFile; fileRef = B43B4DFC2565E941008F345D /* MockAuthUserServiceBehavior.swift */; };
@@ -321,6 +322,7 @@
321322
B41D10012475AB7E0049D08D /* AWSCognitoAuthPlugin+ClientBehavior.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "AWSCognitoAuthPlugin+ClientBehavior.swift"; sourceTree = "<group>"; };
322323
B41D10022475AB7E0049D08D /* AWSCognitoAuthPlugin+DeviceBehavior.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "AWSCognitoAuthPlugin+DeviceBehavior.swift"; sourceTree = "<group>"; };
323324
B41D10032475AB7E0049D08D /* AWSCognitoAuthPlugin+UserBehavior.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "AWSCognitoAuthPlugin+UserBehavior.swift"; sourceTree = "<group>"; };
325+
B4304E2B28E227DF00A6AA43 /* AWSCognitoNetworkPreferences.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AWSCognitoNetworkPreferences.swift; sourceTree = "<group>"; };
324326
B43B4DD82565E820008F345D /* MockAuthenticationProviderBehavior.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockAuthenticationProviderBehavior.swift; sourceTree = "<group>"; };
325327
B43B4DE22565E8D7008F345D /* MockAuthorizationProviderBehavior.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockAuthorizationProviderBehavior.swift; sourceTree = "<group>"; };
326328
B43B4DFC2565E941008F345D /* MockAuthUserServiceBehavior.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockAuthUserServiceBehavior.swift; sourceTree = "<group>"; };
@@ -621,8 +623,9 @@
621623
children = (
622624
B41D0F4F2475A3960049D08D /* AWSAuthCognitoSession.swift */,
623625
B41D0F4B2475A3960049D08D /* AWSAuthDevice.swift */,
624-
B41D0F4E2475A3960049D08D /* AWSCognitoAuthService.swift */,
625626
B41D0F4C2475A3960049D08D /* AWSAuthUser.swift */,
627+
B41D0F4E2475A3960049D08D /* AWSCognitoAuthService.swift */,
628+
B4304E2B28E227DF00A6AA43 /* AWSCognitoNetworkPreferences.swift */,
626629
B41D0F4A2475A3960049D08D /* AWSCognitoUserPoolTokens.swift */,
627630
B41D0F502475A3960049D08D /* Error */,
628631
B41D0F422475A3960049D08D /* Options */,
@@ -1492,6 +1495,7 @@
14921495
B41D0F8E2475A3960049D08D /* AuthenticationProviderAdapter+SignOut.swift in Sources */,
14931496
B41D0F972475A3960049D08D /* AuthorizationProviderAdapter+SignedInSession.swift in Sources */,
14941497
B41D0FB12475A3960049D08D /* AWSAuthChangePasswordOperation.swift in Sources */,
1498+
B4304E2C28E227DF00A6AA43 /* AWSCognitoNetworkPreferences.swift in Sources */,
14951499
B41D0FC52475A3960049D08D /* AuthUserAttributeKey+Extension.swift in Sources */,
14961500
5C33248D27723D0800F2C47B /* AuthenticationProviderAdapter+DeleteUser.swift in Sources */,
14971501
B41D10042475AB7E0049D08D /* AWSCognitoAuthPlugin+Reset.swift in Sources */,

AmplifyPlugins/Auth/AWSCognitoAuthPlugin/AWSCognitoAuthPlugin+Configure.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ extension AWSCognitoAuthPlugin {
102102
setUserPreferencesForService(service: service)
103103
return service
104104
}
105-
105+
106106
func setUserPreferencesForService(service: AmplifyAWSServiceConfiguration) {
107107
guard let networkPreferences = networkPreferences else {
108108
return

AmplifyPlugins/Auth/AWSCognitoAuthPlugin/AWSCognitoAuthPlugin.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ final public class AWSCognitoAuthPlugin: AuthCategoryPlugin {
4444
public var key: PluginKey {
4545
return "awsCognitoAuthPlugin"
4646
}
47-
47+
4848
/// The user network preferences for timeout and retry
4949
let networkPreferences: AWSCognitoNetworkPreferences?
5050

@@ -60,7 +60,7 @@ final public class AWSCognitoAuthPlugin: AuthCategoryPlugin {
6060
public init() {
6161
self.networkPreferences = nil
6262
}
63-
63+
6464
/// Instantiates an instance of the AWSCognitoAuthPlugin with custom network preferences
6565
/// - Parameters:
6666
/// - networkPreferences: network preferences

AmplifyPlugins/Auth/AWSCognitoAuthPlugin/Models/AWSCognitoNetworkPreferences.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@
88
import Foundation
99

1010
public struct AWSCognitoNetworkPreferences {
11-
11+
1212
/// The maximum number of retries for failed requests. The value needs to be between 0 and 10 inclusive. If set to higher than 10, it becomes 10.
1313
public let maxRetryCount: UInt32
14-
14+
1515
/// The timeout interval to use when waiting for additional data.
1616
public let timeoutIntervalForRequest: Double
17-
17+
1818
/// The maximum amount of time that a resource request should be allowed to take.
1919
public let timeoutIntervalForResource: Double
20-
20+
2121
public init(maxRetryCount: UInt32,
2222
timeoutIntervalForRequest: Double,
2323
timeoutIntervalForResource: Double) {

AmplifyPlugins/Auth/AWSCognitoAuthPluginTests/ConfigurationTests/AWSCognitoAuthPluginConfigTests.swift

Lines changed: 38 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ class AWSCognitoAuthPluginConfigTests: XCTestCase {
5555
let categoryConfig = AuthCategoryConfiguration(plugins: [
5656
"awsCognitoAuthPlugin": [
5757
"CredentialsProvider": ["CognitoIdentity": ["Default":
58-
["PoolId": "xx",
59-
"Region": "us-east-1"]
60-
]],
58+
["PoolId": "xx",
59+
"Region": "us-east-1"]
60+
]],
6161
"CognitoUserPool": ["Default": [
6262
"PoolId": "xx",
6363
"Region": "us-east-1",
@@ -89,9 +89,9 @@ class AWSCognitoAuthPluginConfigTests: XCTestCase {
8989
let categoryConfig = AuthCategoryConfiguration(plugins: [
9090
"awsCognitoAuthPlugin": [
9191
"CredentialsProvider": ["CognitoIdentity": ["Default":
92-
["PoolId": "cc",
93-
"Region": "us-east-1"]
94-
]]
92+
["PoolId": "cc",
93+
"Region": "us-east-1"]
94+
]]
9595
]
9696
])
9797
let amplifyConfig = AmplifyConfiguration(auth: categoryConfig)
@@ -147,13 +147,13 @@ class AWSCognitoAuthPluginConfigTests: XCTestCase {
147147
let categoryConfig = AuthCategoryConfiguration(plugins: [
148148
"awsCognitoAuthPlugin": [
149149
"CredentialsProvider": ["CognitoIdentity": ["Default":
150-
["xx": "xx",
151-
"xx2": "us-east-1"]
152-
]],
150+
["xx": "xx",
151+
"xx2": "us-east-1"]
152+
]],
153153
"CognitoUserPool": ["Default": [
154154
"xx": "xx",
155155
"xx2": "us-east-1"
156-
]]
156+
]]
157157
]
158158
])
159159
let amplifyConfig = AmplifyConfiguration(auth: categoryConfig)
@@ -253,9 +253,9 @@ class AWSCognitoAuthPluginConfigTests: XCTestCase {
253253
XCTFail("Auth configuration should not succeed")
254254
} catch {
255255
guard let pluginError = error as? PluginError,
256-
case .pluginConfigurationError = pluginError else {
257-
XCTFail("Should throw invalidConfiguration exception. But received \(error) ")
258-
return
256+
case .pluginConfigurationError = pluginError else {
257+
XCTFail("Should throw invalidConfiguration exception. But received \(error) ")
258+
return
259259
}
260260
}
261261
}
@@ -274,10 +274,11 @@ class AWSCognitoAuthPluginConfigTests: XCTestCase {
274274

275275
let categoryConfig = AuthCategoryConfiguration(plugins: [
276276
"awsCognitoAuthPlugin": [
277-
"CredentialsProvider": ["CognitoIdentity": ["Default":
278-
["PoolId": "xx",
279-
"Region": "us-east-1"]
280-
]],
277+
"CredentialsProvider": ["CognitoIdentity":
278+
["Default":
279+
["PoolId": "xx",
280+
"Region": "us-east-1"]
281+
]],
281282
"CognitoUserPool": ["Default": [
282283
"PoolId": "xx",
283284
"Region": "us-east-1",
@@ -293,65 +294,69 @@ class AWSCognitoAuthPluginConfigTests: XCTestCase {
293294
XCTFail("Should not throw error. \(error)")
294295
}
295296

296-
let signUpExpectation = expectation(description: "Should receive a result")
297+
let signUpExpectation = expectation(description: "Should receive a signUp result")
297298
_ = plugin.signUp(username: "mockUsername", password: "", options: nil) { _ in
298299
signUpExpectation.fulfill()
299300
}
300301

301302
var expectationList = [signUpExpectation]
302303

303-
for _ in 1 ... 50 {
304-
let fetchSessionExpectation = expectation(description: "Should receive a result")
304+
for index in 1 ... 50 {
305+
let fetchSessionExpectation = expectation(
306+
description: "Should receive fetch Authsession result for \(index)")
305307
_ = plugin.fetchAuthSession(options: nil) { _ in
306308
fetchSessionExpectation.fulfill()
307309
}
308310
expectationList.append(fetchSessionExpectation)
309311
}
310312

311-
let signUpExpectation2 = expectation(description: "Should receive a result")
313+
let signUpExpectation2 = expectation(description: "Should receive a second signUp result")
312314
DispatchQueue.global().async {
313315

314316
_ = plugin.signUp(username: "mockUsername", password: "", options: nil) { _ in
315317
signUpExpectation2.fulfill()
316318
}
317319
}
318320
expectationList.append(signUpExpectation2)
319-
wait(for: expectationList, timeout: 10, enforceOrder: true)
321+
wait(for: expectationList, timeout: 20, enforceOrder: true)
320322
}
321-
323+
322324
func testUserNetworkPreferencesForIdentityPoolService() throws {
323325
let networkPreferences = AWSCognitoNetworkPreferences(maxRetryCount: 0,
324326
timeoutIntervalForRequest: 30,
325327
timeoutIntervalForResource: 30)
326328
let plugin = AWSCognitoAuthPlugin(networkPreferences: networkPreferences)
327329

328-
let json = JSONValue(dictionaryLiteral: ("CredentialsProvider",
329-
.init(dictionaryLiteral: ("CognitoIdentity",
330-
.init(dictionaryLiteral: ("Default",
331-
.init(dictionaryLiteral: ("Region", "us-east-1"))))))))
330+
let json: JSONValue = ["CredentialsProvider":
331+
["CognitoIdentity":
332+
["Default":
333+
["Region": "us-east1"]
334+
]
335+
]]
332336
let identityPoolConfig = plugin.identityPoolServiceConfiguration(from: json)
333337

334338
XCTAssertEqual(identityPoolConfig?.maxRetryCount, networkPreferences.maxRetryCount)
335339
XCTAssertEqual(identityPoolConfig?.timeoutIntervalForResource, networkPreferences.timeoutIntervalForResource)
336340
XCTAssertEqual(identityPoolConfig?.timeoutIntervalForRequest, networkPreferences.timeoutIntervalForRequest)
337341
}
338-
342+
339343
func testUserNetworkPreferencesForUserPoolService() throws {
340344
let networkPreferences = AWSCognitoNetworkPreferences(maxRetryCount: 0,
341345
timeoutIntervalForRequest: 30,
342346
timeoutIntervalForResource: 30)
343347
let plugin = AWSCognitoAuthPlugin(networkPreferences: networkPreferences)
344-
345-
let json = JSONValue(dictionaryLiteral: ("CognitoUserPool",
346-
.init(dictionaryLiteral: ("Default",
347-
.init(dictionaryLiteral: ("Region", "us-east-1"))))))
348+
let json: JSONValue = ["CognitoUserPool":
349+
["Default":
350+
["Region": "us-east1"]
351+
]
352+
]
348353
let identityPoolConfig = try plugin.userPoolServiceConfiguration(from: json)
349354

350355
XCTAssertEqual(identityPoolConfig?.maxRetryCount, networkPreferences.maxRetryCount)
351356
XCTAssertEqual(identityPoolConfig?.timeoutIntervalForResource, networkPreferences.timeoutIntervalForResource)
352357
XCTAssertEqual(identityPoolConfig?.timeoutIntervalForRequest, networkPreferences.timeoutIntervalForRequest)
353358
}
354-
359+
355360
func testNoUserPreferences() throws {
356361
let plugin = AWSCognitoAuthPlugin()
357362
XCTAssertNil(plugin.networkPreferences)

0 commit comments

Comments
 (0)