fix(storage): fix data race in DefaultStorageTransferDatabase (#2439)

ameter · web-flow · commit 893f7d5c2fbf · 2022-10-13T13:53:37.000-06:00
diff --git a/AmplifyPlugins/Storage/Sources/AWSS3StoragePlugin/Support/Internal/DefaultStorageTransferDatabase.swift b/AmplifyPlugins/Storage/Sources/AWSS3StoragePlugin/Support/Internal/DefaultStorageTransferDatabase.swift
@@ -175,7 +175,9 @@ class DefaultStorageTransferDatabase {
 
             let pairs = self.linkTasksWithSessions(persistableTransferTasks: persistableTransferTasks, sessionTasks: sessionTasks)
             completionHandler(.success(pairs))
-            self.recoveryState = .completed
+            self.queue.async {
+                self.recoveryState = .completed
+            }
         }
 
         urlSession.getActiveTasks(resultHandler: sessionTaskHandler)

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,9 @@ class DefaultStorageTransferDatabase {`
`175`	`175`
`176`	`176`	`let pairs = self.linkTasksWithSessions(persistableTransferTasks: persistableTransferTasks, sessionTasks: sessionTasks)`
`177`	`177`	`completionHandler(.success(pairs))`
`178`		`- self.recoveryState = .completed`
	`178`	`+ self.queue.async {`
	`179`	`+ self.recoveryState = .completed`
	`180`	`+ }`
`179`	`181`	`}`
`180`	`182`
`181`	`183`	`urlSession.getActiveTasks(resultHandler: sessionTaskHandler)`