fix(DataStore): Various mutation sync fixes (#1355)

- Correctly subclass SyncMutationToCloudOperation as an AsynchronousOperation
  instead of an Operation
- Dispatch start events when sync includes dropped mutations

Additional work:
- chore(DataStore): Removed redundant error & finish calls in isCancelled guards
- chore(DataStore): Improve OperationCancelledError handling
- test(Core): Added nullability test for AtomicValue.with
- test(DataStore): Stabilize subscription end-to-end integ test
- test(DataStore): Enable ThreadSanitizer for integ tests
- test(DataStore): Disabled unimplemented OIDC tests in test scheme
- test(DataStore): Disable OIDC tests

Author: palpatim

.gitignore

@@ -52,7 +52,8 @@ credentials-mc.json
 fastlane/report.xml
 
 # Amplify artifacts, such as used for integ tests
-amplify
+#amplify/
+AmplifyPlugins/**/amplify
 amplify/\#current-cloud-backend
 amplify/.config/local-*
 amplify/logs

Amplify.xcodeproj/project.pbxproj

@@ -609,6 +609,7 @@
 		FA9D6C1B238DEEEB00C7DD9F /* ConcurrentDispatcherPerformanceTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAF1B8872339633C007F1435 /* ConcurrentDispatcherPerformanceTests.swift */; };
 		FA9D6C1E238DEF0E00C7DD9F /* DefaultHubPluginPerformanceTestHelpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAF1B88A23397791007F1435 /* DefaultHubPluginPerformanceTestHelpers.swift */; };
 		FA9D6C1F238DEF1100C7DD9F /* SerialDispatcherPerformanceTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA317107232AE8DF009BC140 /* SerialDispatcherPerformanceTests.swift */; };
+		FA9F939626BAF73F00805607 /* OperationCancelledError.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA9F939526BAF73F00805607 /* OperationCancelledError.swift */; };
 		FA9FB7792329D4D400C04D32 /* HubFilter.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA9FB7782329D4D400C04D32 /* HubFilter.swift */; };
 		FA9FB77B2329D4FB00C04D32 /* UnsubscribeToken.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA9FB77A2329D4FB00C04D32 /* UnsubscribeToken.swift */; };
 		FA9FB77D232AA0D800C04D32 /* FilteredListener.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA9FB77C232AA0D800C04D32 /* FilteredListener.swift */; };
@@ -1591,6 +1592,7 @@
 		FA8EE780238628490097E4F1 /* Persistable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Persistable.swift; sourceTree = "<group>"; };
 		FA8EE78223862DDB0097E4F1 /* AnyModel+Schema.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "AnyModel+Schema.swift"; sourceTree = "<group>"; };
 		FA8F4D232395B1B600861D91 /* MutationEvent+Model.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "MutationEvent+Model.swift"; sourceTree = "<group>"; };
+		FA9F939526BAF73F00805607 /* OperationCancelledError.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OperationCancelledError.swift; sourceTree = "<group>"; };
 		FA9FB7782329D4D400C04D32 /* HubFilter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HubFilter.swift; sourceTree = "<group>"; };
 		FA9FB77A2329D4FB00C04D32 /* UnsubscribeToken.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UnsubscribeToken.swift; sourceTree = "<group>"; };
 		FA9FB77C232AA0D800C04D32 /* FilteredListener.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FilteredListener.swift; sourceTree = "<group>"; };
@@ -3303,6 +3305,7 @@
 				FA5704C8245F3C6900392C19 /* AmplifyInProcessReportingOperation.swift */,
 				FA249EE624C5FA49009B3CE8 /* AmplifyInProcessReportingOperation+Combine.swift */,
 				FA56F72622B14BF70039754A /* AmplifyOperation.swift */,
+				FA9F939526BAF73F00805607 /* OperationCancelledError.swift */,
 				FAA7A5A524C0CC8F00CA863F /* AmplifyOperation+Combine.swift */,
 				FA5704CA245F58C600392C19 /* AmplifyOperation+Hub.swift */,
 				FAB9D810233BF5F600928AA9 /* AmplifyOperationContext.swift */,
@@ -5050,6 +5053,7 @@
 				B4B5CC812457B0690019C783 /* AuthFetchUserAttributesRequest.swift in Sources */,
 				B493E69324524E8C00D9E521 /* AuthUserAttribute.swift in Sources */,
 				B450741524115C340098F02D /* AuthSignInResult.swift in Sources */,
+				FA9F939626BAF73F00805607 /* OperationCancelledError.swift in Sources */,
 				B468841A2460A98E00221268 /* AuthForgetDeviceRequest.swift in Sources */,
 				217855C3237F84D700A30D19 /* RESTRequest.swift in Sources */,
 				975751AD24CA35F000FA0A6E /* IssueInfoHelper.swift in Sources */,

Amplify/Categories/API/Error/APIError.swift

@@ -47,6 +47,8 @@ extension APIError: AmplifyError {
     ) {
         if let error = error as? Self {
             self = error
+        } else if error.isOperationCancelledError {
+            self = .unknown("Operation cancelled", "", error)
         } else {
             self = .unknown(errorDescription, recoverySuggestion, error)
         }

Amplify/Categories/Analytics/Error/AnalyticsError.swift

@@ -58,6 +58,8 @@ extension AnalyticsError: AmplifyError {
     ) {
         if let error = error as? Self {
             self = error
+        } else if error.isOperationCancelledError {
+            self = .unknown("Operation cancelled", error)
         } else {
             self = .unknown(errorDescription, error)
         }

Amplify/Categories/Auth/Error/AuthError.swift

@@ -88,6 +88,8 @@ extension AuthError: AmplifyError {
     ) {
         if let error = error as? Self {
             self = error
+        } else if error.isOperationCancelledError {
+            self = .unknown("Operation cancelled", error)
         } else {
             self = .unknown(errorDescription, error)
         }

Amplify/Categories/DataStore/DataStoreError.swift

@@ -108,6 +108,8 @@ extension DataStoreError: AmplifyError {
             self = error
         } else if let amplifyError = error as? AmplifyError {
             self = .api(amplifyError)
+        } else if error.isOperationCancelledError {
+            self = .unknown("Operation cancelled", "", error)
         } else {
             self = .unknown(errorDescription, recoverySuggestion, error)
         }

Amplify/Categories/Predictions/Error/PredictionsError.swift

@@ -80,6 +80,8 @@ extension PredictionsError: AmplifyError {
     ) {
         if let error = error as? Self {
             self = error
+        } else if error.isOperationCancelledError {
+            self = .unknown("Operation cancelled", "", error)
         } else {
             self = .unknown(errorDescription, recoverySuggestion, error)
         }

Amplify/Categories/Storage/Error/StorageError.swift

@@ -86,6 +86,8 @@ extension StorageError: AmplifyError {
     ) {
         if let error = error as? Self {
             self = error
+        } else if error.isOperationCancelledError {
+            self = .unknown("Operation cancelled", error)
         } else {
             self = .unknown(errorDescription, error)
         }

Amplify/Core/Support/AmplifyOperation+Combine.swift

@@ -60,7 +60,7 @@ extension AmplifyOperation {
     /// - Returns: A publisher that either completes successfully (if the underlying
     ///   error of `error` is a cancellation) or re-emits the existing error
     private func interceptCancellation(error: Failure) -> AnyPublisher<Success, Failure> {
-        if error.underlyingError is OperationCancelledError {
+        if error.isOperationCancelledError {
             return Empty<Success, Failure>(completeImmediately: true).eraseToAnyPublisher()
         } else {
             return Fail<Success, Failure>(error: error).eraseToAnyPublisher()

Amplify/Core/Support/AmplifyOperation.swift

@@ -18,8 +18,6 @@ import Foundation
 /// Pausable/resumable tasks that do not require Hub dispatching should use AsynchronousOperation instead.
 open class AmplifyOperation<Request: AmplifyOperationRequest, Success, Failure: AmplifyError>: AsynchronousOperation {
 
-    struct OperationCancelledError: Error { }
-
     /// The concrete Request associated with this operation
     public typealias Request = Request