feat(Auth): Removed deviceNotFound TODO which is not applicable for TOTP (#3074)

Author: harsh62

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Actions/SignIn/DeviceSRPAuth/InitiateAuthDeviceSRP.swift

@@ -85,23 +85,12 @@ struct InitiateAuthDeviceSRP: Action {
     func parseResponse(
         _ response: SignInResponseBehavior,
         with stateData: SRPStateData) -> StateMachineEvent {
-
-
-            //HS: TODO: Combine this logic with responedToAuthChallenge
-            if let challengeName = response.challengeName {
-                switch challengeName {
-                case .devicePasswordVerifier:
-                    return SignInEvent(eventType: .respondDevicePasswordVerifier(stateData, response))
-                default:
-                    let message = "Unsupported challenge response during DeviceSRPAuth \(challengeName)"
-                    let error = SignInError.unknown(message: message)
-                    return SignInEvent(eventType: .throwAuthError(error))
-                }
-            } else {
-                let message = "Response did not contain challenge info"
-                let error = SignInError.invalidServiceResponse(message: message)
+            guard case .devicePasswordVerifier = response.challengeName else {
+                let message = "Unsupported challenge response during DeviceSRPAuth \(response.challengeName ?? .sdkUnknown("Response did not contain challenge info"))"
+                let error = SignInError.unknown(message: message)
                 return SignInEvent(eventType: .throwAuthError(error))
             }
+            return SignInEvent(eventType: .respondDevicePasswordVerifier(stateData, response))
         }
 
 }

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Actions/SignIn/SoftwareTokenSetup/CompleteTOTPSetup.swift

@@ -81,16 +81,7 @@ struct CompleteTOTPSetup: Action {
             logVerbose("\(#fileID) Sending event \(responseEvent)",
                        environment: environment)
             await dispatcher.send(responseEvent)
-            // TODO: HS:
-            //        } catch let error where deviceNotFound(error: error, deviceMetadata: deviceMetadata) {
-            //            logVerbose("\(#fileID) Received device not found \(error)", environment: environment)
-            //            // Remove the saved device details and retry verify challenge
-            //            await DeviceMetadataHelper.removeDeviceMetaData(for: username, with: environment)
-            //            let event = SignInChallengeEvent(
-            //                eventType: .retryVerifyChallengeAnswer(confirmSignEventData)
-            //            )
-            //            logVerbose("\(#fileID) Sending event \(event)", environment: environment)
-            //            await dispatcher.send(event)
+
         } catch let error as SignInError {
             logError(error.authError.errorDescription, environment: environment)
             let errorEvent = SignInEvent(eventType: .throwAuthError(error))
@@ -107,21 +98,6 @@ struct CompleteTOTPSetup: Action {
         }
     }
 
-// TODO: HS: Figure out if this is needed
-//    func deviceNotFound(error: Error, deviceMetadata: DeviceMetadata) -> Bool {
-//
-//        // If deviceMetadata was not send, the error returned is not from device not found.
-//        if case .noData = deviceMetadata {
-//            return false
-//        }
-//
-//        if let serviceError: RespondToAuthChallengeOutputError = error.internalAWSServiceError(),
-//           case .resourceNotFoundException = serviceError {
-//            return true
-//        }
-//        return false
-//    }
-
 }
 
 extension CompleteTOTPSetup: CustomDebugDictionaryConvertible {