Skip to content

Commit ae75da8

Browse files
authored
chore(DataStore): defines typealias for AmplifyCancellable (#1044)
1 parent df178be commit ae75da8

File tree

8 files changed

+8
-26
lines changed

8 files changed

+8
-26
lines changed

Amplify/Core/Support/Cancellable.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,6 @@
1010
public protocol Cancellable {
1111
func cancel()
1212
}
13+
14+
/// Unique name for Cancellable which handles a name conflict with the Combine framework.
15+
public typealias AmplifyCancellable = Cancellable

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/MutationSync/MutationEvent/MutationEventPublisher.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ import Combine
1010

1111
/// Publishes mutation events to downstream subscribers for subsequent sync to the API.
1212
@available(iOS 13.0, *)
13-
protocol MutationEventPublisher: class, Cancellable {
13+
protocol MutationEventPublisher: class, AmplifyCancellable {
1414
var publisher: AnyPublisher<MutationEvent, DataStoreError> { get }
1515
}

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/SubscriptionSync/IncomingAsyncSubscriptionEventPublisher.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import Combine
1818
/// `GraphQLSubscriptionType` and holds a reference to the returned operation. The operations' listeners enqueue
1919
/// incoming successful events onto a `Publisher`, that queue processors can subscribe to.
2020
@available(iOS 13.0, *)
21-
final class IncomingAsyncSubscriptionEventPublisher: Cancellable {
21+
final class IncomingAsyncSubscriptionEventPublisher: AmplifyCancellable {
2222
typealias Payload = MutationSync<AnyModel>
2323
typealias Event = SubscriptionEvent<GraphQLResponse<Payload>>
2424

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/SubscriptionSync/IncomingAsyncSubscriptionEventToAnyModelMapper.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ enum IncomingAsyncSubscriptionEvent {
1818
// swiftlint:disable type_name
1919
/// Subscribes to an IncomingSubscriptionAsyncEventQueue, and publishes AnyModel
2020
@available(iOS 13.0, *)
21-
final class IncomingAsyncSubscriptionEventToAnyModelMapper: Subscriber, Cancellable {
21+
final class IncomingAsyncSubscriptionEventToAnyModelMapper: Subscriber, AmplifyCancellable {
2222
// swiftlint:enable type_name
2323

2424
typealias Input = IncomingAsyncSubscriptionEventPublisher.Event

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/SubscriptionSync/IncomingEventReconciliationQueue.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ enum IncomingEventReconciliationQueueEvent {
2222
/// automatically-configured subscriptions for models, the queue provides an `offer` method for submitting events
2323
/// directly from other network events such as mutation callbacks or from base/initial sync queries.
2424
@available(iOS 13.0, *)
25-
protocol IncomingEventReconciliationQueue: class, Cancellable {
25+
protocol IncomingEventReconciliationQueue: class, AmplifyCancellable {
2626
func start()
2727
func pause()
2828
func offer(_ remoteModel: MutationSync<AnyModel>, modelSchema: ModelSchema)

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/SubscriptionSync/IncomingSubscriptionEventPublisher.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ enum IncomingSubscriptionEventPublisherEvent {
1515
}
1616

1717
@available(iOS 13.0, *)
18-
protocol IncomingSubscriptionEventPublisher: Cancellable {
18+
protocol IncomingSubscriptionEventPublisher: AmplifyCancellable {
1919
var publisher: AnyPublisher<IncomingSubscriptionEventPublisherEvent, DataStoreError> { get }
2020
}

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/Support/Cancellable.swift

Lines changed: 0 additions & 17 deletions
This file was deleted.

AmplifyPlugins/DataStore/DataStoreCategoryPlugin.xcodeproj/project.pbxproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@
7272
6B3CC61923F5E64F0008ECBC /* RemoteSyncEngine+State.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6B3CC61823F5E64F0008ECBC /* RemoteSyncEngine+State.swift */; };
7373
6B3CC67C23F86D680008ECBC /* RemoteSyncEngine+IncomingEventReconciliationQueueEvent.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6B3CC67B23F86D680008ECBC /* RemoteSyncEngine+IncomingEventReconciliationQueueEvent.swift */; };
7474
6B3CC68023F87FA10008ECBC /* RemoteSyncEngine+Retryable.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6B3CC67F23F87FA10008ECBC /* RemoteSyncEngine+Retryable.swift */; };
75-
6B3CC68223F89EE30008ECBC /* Cancellable.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6B3CC68123F89EE30008ECBC /* Cancellable.swift */; };
7675
6B4693E923A5645F006BE2C5 /* MutationRetryNotifier.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6B4693E823A5645F006BE2C5 /* MutationRetryNotifier.swift */; };
7776
6B4E3DF42397269C00AD962B /* OutgoingMutationQueueTestsWithMockStateMachine.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6B4E3DF32397269C00AD962B /* OutgoingMutationQueueTestsWithMockStateMachine.swift */; };
7877
6B4E3DF62397327E00AD962B /* MockStateMachine.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6B4E3DF52397327E00AD962B /* MockStateMachine.swift */; };
@@ -320,7 +319,6 @@
320319
6B3CC61823F5E64F0008ECBC /* RemoteSyncEngine+State.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "RemoteSyncEngine+State.swift"; sourceTree = "<group>"; };
321320
6B3CC67B23F86D680008ECBC /* RemoteSyncEngine+IncomingEventReconciliationQueueEvent.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "RemoteSyncEngine+IncomingEventReconciliationQueueEvent.swift"; sourceTree = "<group>"; };
322321
6B3CC67F23F87FA10008ECBC /* RemoteSyncEngine+Retryable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "RemoteSyncEngine+Retryable.swift"; sourceTree = "<group>"; };
323-
6B3CC68123F89EE30008ECBC /* Cancellable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Cancellable.swift; sourceTree = "<group>"; };
324322
6B4693E823A5645F006BE2C5 /* MutationRetryNotifier.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MutationRetryNotifier.swift; sourceTree = "<group>"; };
325323
6B4E3DF32397269C00AD962B /* OutgoingMutationQueueTestsWithMockStateMachine.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OutgoingMutationQueueTestsWithMockStateMachine.swift; sourceTree = "<group>"; };
326324
6B4E3DF52397327E00AD962B /* MockStateMachine.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockStateMachine.swift; sourceTree = "<group>"; };
@@ -821,7 +819,6 @@
821819
FA8F4D1D2395AF7600861D91 /* DataStoreError+Plugin.swift */,
822820
FA8F4D212395B11700861D91 /* MutationEvent+Query.swift */,
823821
FA3841E823889D440070AD5B /* StateMachine.swift */,
824-
6B3CC68123F89EE30008ECBC /* Cancellable.swift */,
825822
);
826823
path = Support;
827824
sourceTree = "<group>";
@@ -1631,7 +1628,6 @@
16311628
D838AB4C2500330000BF4940 /* ModelSyncedEvent.swift in Sources */,
16321629
FAED5742238B52CE008EBED8 /* ModelStorageBehavior.swift in Sources */,
16331630
2149E5C62388684F00873955 /* StorageEngineAdapter.swift in Sources */,
1634-
6B3CC68223F89EE30008ECBC /* Cancellable.swift in Sources */,
16351631
FA55A5492391EA89002AFF2D /* MutationEventSubscription.swift in Sources */,
16361632
FA5D76AB2394752900489864 /* AWSMutationDatabaseAdapter+MutationEventIngester.swift in Sources */,
16371633
B9B64AA123FD0A3C00730B68 /* ModelValueConverter+SQLite.swift in Sources */,

0 commit comments

Comments
 (0)