Skip to content

Commit d3d153d

Browse files
committed
fix(liveness): misc minor changes (#135)
1 parent 870acb4 commit d3d153d

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

AmplifyPlugins/Predictions/AWSPredictionsPlugin/Signing/SigV4Signer.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ struct SigV4Signer {
165165
/// - Returns: A SigV4 Signed URL
166166
func sign(
167167
url: URL,
168-
method: HTTPMethod,
168+
method: HTTPMethod = .get,
169169
body: RequestBody? = nil,
170170
headers: [String: String] = [:],
171171
date: () -> Date = { .init() },
@@ -232,7 +232,7 @@ struct SigV4Signer {
232232
_storage.previousSignature = signature
233233

234234
let queryString = canonicalQueryString + "&X-Amz-Signature=\(signature)"
235-
let signedURL = url.appending(queryString: queryString)
235+
let signedURL = url.replacing(queryString: queryString)
236236

237237
return signedURL
238238
}

AmplifyPlugins/Predictions/AWSPredictionsPlugin/Signing/URL+Signing.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,13 @@ extension URL {
2828
return value
2929
}
3030

31-
func appending(queryString: String) -> URL {
31+
func replacing(queryString: String) -> URL {
3232
let split = absoluteString.split(separator: "?")
3333
let url: URL?
3434
if split.count == 2 {
3535
let baseURL = String(split[0])
36-
let existingQueryString = String(split[1])
3736
url = URL(
38-
string: baseURL + "?" + existingQueryString + "&" + queryString
37+
string: baseURL + "?" + queryString
3938
)
4039
} else {
4140
url = URL(string: absoluteString + "?" + queryString)

0 commit comments

Comments
 (0)