Skip to content

Commit df39b06

Browse files
authored
chore: Adding dependency to build-amplify-swift in release workflow. Also adding missing identifier to concurrency groups (#3170)
1 parent 88961a0 commit df39b06

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

.github/workflows/build_amplify_swift.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
name: Build | Amplify Swift
22
on:
33
workflow_call:
4+
inputs:
5+
identifier:
6+
required: true
7+
type: string
48
workflow_dispatch:
59
push:
610
branches-ignore:
@@ -11,7 +15,7 @@ permissions:
1115
contents: read
1216

1317
concurrency:
14-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
18+
group: ${{ inputs.identifier || github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1519
cancel-in-progress: ${{ github.ref_name != 'main'}}
1620

1721
jobs:

.github/workflows/deploy_package.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ jobs:
1616
build-amplify-swift:
1717
name: Build Amplify package
1818
uses: ./.github/workflows/build_amplify_swift.yml
19+
with:
20+
identifier: 'workflow-call-build-amplify-swift'
1921

2022
unit-tests:
2123
name: Run Plugins Unit Tests
@@ -33,7 +35,7 @@ jobs:
3335
release:
3436
environment: Release
3537
name: Release new ${{ inputs.type }} version
36-
needs: [unit-tests, fortify]
38+
needs: [unit-tests, fortify, build-amplify-swift]
3739
runs-on: macos-latest
3840
env:
3941
GITHUB_EMAIL: [email protected]

.github/workflows/fortify_scan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ permissions:
1717
contents: read
1818

1919
concurrency:
20-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
20+
group: ${{ inputs.identifier || github.workflow }}-${{ github.event.pull_request.number || github.ref }}
2121
cancel-in-progress: ${{ github.ref_name != 'main'}}
2222

2323
jobs:

.github/workflows/unit_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ permissions:
1616
contents: read
1717

1818
concurrency:
19-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
19+
group: ${{ inputs.identifier || github.workflow }}-${{ github.event.pull_request.number || github.ref }}
2020
cancel-in-progress: ${{ github.ref_name != 'main'}}
2121

2222
jobs:

0 commit comments

Comments
 (0)