chore: fix build warnings in amplify package

Author: thisisabhash

Amplify/Categories/DataStore/Model/ModelIdentifiable.swift

@@ -121,7 +121,7 @@ public extension DefaultModelIdentifier {
 // MARK: - Persistable + stringValue
 private extension Persistable {
     var stringValue: String {
-        var value: String = switch self {
+        let value: String = switch self {
         case let self as Temporal.Date:
             self.iso8601String
 

Amplify/Core/Support/ChildTask.swift

@@ -35,25 +35,28 @@ actor ChildTask<InProcess, Success, Failure: Error>: BufferingSequence {
 
     var value: Success {
         get async throws {
-            try await withTaskCancellationHandler(handler: {
-                Task {
-                    await cancel()
-                }
-            }, operation: {
-                try await withCheckedThrowingContinuation { continuation in
-                    if isCancelled {
-                        // immediately cancel is already cancelled
-                        continuation.resume(throwing: CancellationError())
-                    } else if let result = storedResult {
-                        // immediately send result if it is available
-                        valueContinuations.append(continuation)
-                        send(result)
-                    } else {
-                        // capture contination to use later
-                        valueContinuations.append(continuation)
+            try await withTaskCancellationHandler(
+                operation: {
+                    try await withCheckedThrowingContinuation { continuation in
+                        if isCancelled {
+                            // immediately cancel is already cancelled
+                            continuation.resume(throwing: CancellationError())
+                        } else if let result = storedResult {
+                            // immediately send result if it is available
+                            valueContinuations.append(continuation)
+                            send(result)
+                        } else {
+                            // capture contination to use later
+                            valueContinuations.append(continuation)
+                        }
+                    }
+                },
+                onCancel: {
+                    Task {
+                        await cancel()
                     }
                 }
-            })
+            )
         }
     }
 

Amplify/DevMenu/Trigger/LongPressGestureRecognizer.swift

@@ -10,7 +10,7 @@ import Foundation
 import UIKit
 
 /// A class for recognizing long press gesture which notifies a `TriggerDelegate` of the event
-class LongPressGestureRecognizer: NSObject, @preconcurrency TriggerRecognizer, UIGestureRecognizerDelegate {
+class LongPressGestureRecognizer: NSObject, TriggerRecognizer, UIGestureRecognizerDelegate {
 
     weak var triggerDelegate: TriggerDelegate?
     weak var uiWindow: UIWindow?

AmplifyPlugins/API/Tests/AWSAPIPluginTests/AppSyncRealTimeClient/AppSyncRealTimeClientTests.swift

@@ -58,7 +58,7 @@ class AppSyncRealTimeClientTests: XCTestCase {
         }
         Task {
             try await Task.sleep(nanoseconds: 80 * 1_000)
-            await appSyncClient.subject.send(.success(.init(id: nil, payload: nil, type: .connectionAck)))
+            appSyncClient.subject.send(.success(.init(id: nil, payload: nil, type: .connectionAck)))
         }
         await fulfillment(of: [finishExpectation], timeout: timeout + 1)
     }
@@ -90,7 +90,7 @@ class AppSyncRealTimeClientTests: XCTestCase {
         }
         Task {
             try await Task.sleep(nanoseconds: 80 * 1_000)
-            await appSyncClient.subject.send(.success(.init(
+            appSyncClient.subject.send(.success(.init(
                 id: id,
                 payload: .object([
                     "errors": .array([
@@ -133,7 +133,7 @@ class AppSyncRealTimeClientTests: XCTestCase {
 
         Task {
             try await Task.sleep(nanoseconds: 80 * 1_000)
-            await appSyncClient.subject.send(.success(.init(
+            appSyncClient.subject.send(.success(.init(
                 id: id,
                 payload: .object([
                     "errors": .array([
@@ -180,7 +180,7 @@ class AppSyncRealTimeClientTests: XCTestCase {
 
         Task {
             try await Task.sleep(nanoseconds: 80 * 1_000)
-            await appSyncClient.subject.send(.success(.init(
+            appSyncClient.subject.send(.success(.init(
                 id: id,
                 payload: .object([
                     "errors": .array([

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/AWSCognitoAuthPlugin+AppSyncSigner.swift

@@ -111,7 +111,7 @@ extension AWSCognitoAuthPlugin {
             return nil
         }
 
-        var headers = urlRequest.allHTTPHeaderFields ?? [:]
+        let headers = urlRequest.allHTTPHeaderFields ?? [:]
         let httpMethod = (urlRequest.httpMethod?.uppercased())
             .flatMap(HTTPMethodType.init(rawValue:)) ?? .get
 

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Actions/Configuration/InitializeAuthorizationConfiguration.swift

@@ -19,7 +19,7 @@ struct InitializeAuthorizationConfiguration: Action {
     ) async {
         // ATM this is a no-op action
         logVerbose("\(#fileID) Starting execution", environment: environment)
-        var event = switch storedCredentials {
+        let event = switch storedCredentials {
         case .noCredentials:
             AuthorizationEvent(eventType: .configure)
         default:

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Actions/FetchAuthorizationSession/InformSessionError.swift

@@ -19,7 +19,7 @@ struct InformSessionError: Action {
     func execute(withDispatcher dispatcher: EventDispatcher, environment: Environment) async {
 
         logVerbose("\(#fileID) Starting execution", environment: environment)
-        var event: AuthorizationEvent = switch error {
+        let event: AuthorizationEvent = switch error {
         case .service(let serviceError):
             if isNotAuthorizedError(serviceError) {
                 .init(eventType: .throwError(

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Models/AuthChallengeType.swift

@@ -34,7 +34,7 @@ enum AuthChallengeType {
 
 }
 
-extension CognitoIdentityProviderClientTypes.ChallengeNameType: Codable {
+extension CognitoIdentityProviderClientTypes.ChallengeNameType: @retroactive Decodable, @retroactive Encodable {
     var authChallengeType: AuthChallengeType {
         switch self {
         case .customChallenge:

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Operations/Helpers/FetchAuthSessionOperationHelper.swift

@@ -75,7 +75,7 @@ class FetchAuthSessionOperationHelper {
     ) async throws -> AuthSession {
 
             if forceRefresh || !credentials.areValid() {
-                var event = switch credentials {
+                let event = switch credentials {
                 case .identityPoolWithFederation(let federatedToken, let identityId, _):
                     AuthorizationEvent(eventType: .startFederationToIdentityPool(federatedToken, identityId))
                 case .noCredentials:

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Service/ErrorMapping/AuthErrorConvertible.swift

@@ -19,5 +19,3 @@ extension AuthError: AuthErrorConvertible {
         return self
     }
 }
-
-extension AuthError: @unchecked Sendable { }