Prevent clearing shared keychains #4077
Merged
+162
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#4076
Description
This change prevents shared Keychains (accessGroup) from being cleared on a fresh install. Since UserDefaults are not shared across apps/extensions, we have no reliable way to determine if this is the first launch of all apps/extensions that are using the provided accessGroup.
The caveat here is that if a user uninstalls and reinstalls an application, the credentials will not be wiped like they are in the standard, non shared Keychain usage. This change is necessary though given the above description.
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.