From e207d4334b9ec777f399c6d3078ca0b220ec2658 Mon Sep 17 00:00:00 2001 From: Edison Zhang Date: Thu, 19 Sep 2024 10:53:33 -0700 Subject: [PATCH 1/3] moveTo SignIn is not needed due to signOut() --- .../amplifyframework/ui/authenticator/AuthenticatorViewModel.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/authenticator/src/main/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModel.kt b/authenticator/src/main/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModel.kt index 4df7cdaa..6e9bac97 100644 --- a/authenticator/src/main/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModel.kt +++ b/authenticator/src/main/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModel.kt @@ -582,7 +582,6 @@ internal class AuthenticatorViewModel( logger.error(result.error.toString()) logger.error("Current signed in user session has expired, signing out.") signOut() - moveTo(AuthenticatorStep.SignIn) } else { handleGeneralFailure(result.error) } From a3684fc654f229d4406a01ab1a1b48e5472ffa51 Mon Sep 17 00:00:00 2001 From: Edison Zhang Date: Mon, 23 Sep 2024 14:15:32 -0700 Subject: [PATCH 2/3] update test cases for when getCurrentUser error with SessionExpiredException during start --- .../ui/authenticator/AuthenticatorViewModelTest.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/authenticator/src/test/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModelTest.kt b/authenticator/src/test/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModelTest.kt index 77e727e2..bf2ce8c6 100644 --- a/authenticator/src/test/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModelTest.kt +++ b/authenticator/src/test/java/com/amplifyframework/ui/authenticator/AuthenticatorViewModelTest.kt @@ -133,7 +133,7 @@ class AuthenticatorViewModelTest { } @Test - fun `getCurrentUser error with session expired exception during start results in SignIn state`() = runTest { + fun `getCurrentUser error with session expired exception during start results in being signed out`() = runTest { coEvery { authProvider.fetchAuthSession() } returns Success(mockAuthSession(isSignedIn = true)) coEvery { authProvider.getCurrentUser() } returns AmplifyResult.Error(SessionExpiredException()) @@ -143,8 +143,8 @@ class AuthenticatorViewModelTest { coVerify(exactly = 1) { authProvider.fetchAuthSession() authProvider.getCurrentUser() + authProvider.signOut() } - viewModel.currentStep shouldBe AuthenticatorStep.SignIn } @Test From b298a6475a639d38fafbb1b23b202c0df5f34ea1 Mon Sep 17 00:00:00 2001 From: Edison Zhang Date: Tue, 24 Sep 2024 15:02:31 -0700 Subject: [PATCH 3/3] retrigger checks