Skip to content

Commit 680bb19

Browse files
authored
chore: update face fit instruction text and error message (#49)
* chore: clean up face fit instruction text * chore: update face fit instruction text and error message * chore: update face fit instruction text and error message
1 parent aab92ed commit 680bb19

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

HostApp/HostApp/Views/LivenessCheckErrorContentView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ struct LivenessCheckErrorContentView: View {
2828
extension LivenessCheckErrorContentView {
2929
static let mock = LivenessCheckErrorContentView(
3030
name: "Time out",
31-
description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face within 7 seconds."
31+
description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face in it."
3232
)
3333

3434
static let unexpected = LivenessCheckErrorContentView(
@@ -38,7 +38,7 @@ extension LivenessCheckErrorContentView {
3838

3939
static let faceMatchTimeOut = LivenessCheckErrorContentView(
4040
name: "Time out",
41-
description: "Face did not fill oval in time limit. Try again and completely fill the oval with face within 7 seconds."
41+
description: "Face did not fill oval in time limit. Try again and completely fill the oval with face in it."
4242
)
4343

4444
static let sessionTimeOut = LivenessCheckErrorContentView(

Sources/FaceLiveness/Resources/Base.lproj/Localizable.strings

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"amplify_ui_liveness_get_ready_steps_title" = "Follow the instructions to complete the check:";
1616
"amplify_ui_liveness_get_ready_face_not_covered" = "Make sure your face is not covered with sunglasses or a mask.";
1717
"amplify_ui_liveness_get_ready_lighting" = "Move to a well-lit place that is not in direct sunlight.";
18-
"amplify_ui_liveness_get_ready_fit_face" = "When an oval appears, fill the oval with your face within 7 seconds.";
18+
"amplify_ui_liveness_get_ready_fit_face" = "When an oval appears, fill the oval with your face in it.";
1919
"amplify_ui_liveness_get_ready_begin_check" = "Begin Check";
2020
"amplify_ui_liveness_get_ready_good_fit_example" = "Good fit";
2121
"amplify_ui_liveness_get_ready_too_far_example" = "Too far";

Sources/FaceLiveness/Utilities/LocalizedStringKey+Liveness.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ extension LocalizedStringKey {
5858
"amplify_ui_liveness_get_ready_lighting"
5959
)
6060

61-
/// en = "When an oval appears, fill the oval with your face within 7 seconds."
61+
/// en = "When an oval appears, fill the oval with your face in it."
6262
static let get_ready_fit_face = LocalizedStringKey(
6363
"amplify_ui_liveness_get_ready_fit_face"
6464
)

Tests/FaceLivenessTests/LivenessTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ final class FaceLivenessDetectionViewModelTestCase: XCTestCase {
140140
}
141141

142142
/// Given: A `FaceLivenessDetectionViewModel`
143-
/// When: The viewModel handles a no fit event over a duration of 7 seconds
143+
/// When: The viewModel handles a no fit event over a client default time limit of 7 seconds
144144
/// Then: The end state is `.encounteredUnrecoverableError(.timedOut)`
145145
func testNoFitTimeoutCheck() async throws {
146146
viewModel.livenessService = self.livenessService

Tests/IntegrationTestApp/IntegrationTestApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tests/IntegrationTestApp/IntegrationTestApp/Views/LivenessCheckErrorContentView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ struct LivenessCheckErrorContentView: View {
2828
extension LivenessCheckErrorContentView {
2929
static let mock = LivenessCheckErrorContentView(
3030
name: "Time out",
31-
description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face within 7 seconds."
31+
description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face in it."
3232
)
3333

3434
static let unexpected = LivenessCheckErrorContentView(
@@ -38,7 +38,7 @@ extension LivenessCheckErrorContentView {
3838

3939
static let faceMatchTimeOut = LivenessCheckErrorContentView(
4040
name: "Time out",
41-
description: "Face did not fill oval in time limit. Try again and completely fill the oval with face within 7 seconds."
41+
description: "Face did not fill oval in time limit. Try again and completely fill the oval with face in it."
4242
)
4343

4444
static let sessionTimeOut = LivenessCheckErrorContentView(

0 commit comments

Comments
 (0)