chore(codeql): migration (#3113)

calebpollman · web-flow · commit 35d85d18a683 · 2022-12-01T11:14:35.000-08:00
diff --git a/.github/codeql/codeql-config.yml b/.github/codeql/codeql-config.yml
@@ -0,0 +1,2 @@
+paths-ignore:
+  - docs
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -0,0 +1,40 @@
+name: 'CodeQL'
+
+on:
+  push:
+    branches: ['main', '*/main']
+
+  pull_request:
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [javascript]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          config-file: ./.github/codeql/codeql-config.yml
+          queries: +security-and-quality
+
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2
+        with:
+          category: '/language:${{ matrix.language }}'
diff --git a/canary/apps/vue/vite/vite.config.js b/canary/apps/vue/vite/vite.config.js
@@ -1,5 +1,3 @@
-import { fileURLToPath, URL } from 'url';
-
 import { defineConfig } from 'vite';
 import vue from '@vitejs/plugin-vue';
 
diff --git a/canary/e2e/cypress/integration/common/shared.ts b/canary/e2e/cypress/integration/common/shared.ts
@@ -2,11 +2,10 @@
 /// <reference types="cypress" />
 /// <reference types="../../support/commands" />
 
-import { And, Given, Then, When } from 'cypress-cucumber-preprocessor/steps';
-import { get, escapeRegExp } from 'lodash';
+import { Given, Then, When } from 'cypress-cucumber-preprocessor/steps';
+import { escapeRegExp } from 'lodash';
 
 let language = 'en-US';
-let window = null;
 
 Given("I'm running the example {string}", (example: string) => {
   cy.visit(example, {
diff --git a/canary/e2e/cypress/integration/common/sign-up.ts b/canary/e2e/cypress/integration/common/sign-up.ts
@@ -1,6 +1,6 @@
 /// <reference types="@testing-library/cypress" />
 /// <reference types="cypress" />
-import { Given, Then, When } from 'cypress-cucumber-preprocessor/steps';
+import { Given, When } from 'cypress-cucumber-preprocessor/steps';
 
 Given('I click {string}', (text: string) => {
   cy.findByText(text).click();
diff --git a/examples/angular/src/pages/ui/components/authenticator/useAuthenticator/useAuthenticator.component.ts b/examples/angular/src/pages/ui/components/authenticator/useAuthenticator/useAuthenticator.component.ts
@@ -1,5 +1,5 @@
-import { Component, OnInit } from '@angular/core';
-import { Amplify, Auth } from 'aws-amplify';
+import { Component } from '@angular/core';
+import { Amplify } from 'aws-amplify';
 import { AuthenticatorService } from '@aws-amplify/ui-angular';
 
 import awsExports from './aws-exports';
diff --git a/examples/next/theme.ts b/examples/next/theme.ts
@@ -1,5 +1,5 @@
 import { defaultTheme, Theme } from '@aws-amplify/ui-react';
-import { flipPalette, usePalette } from 'utils';
+import { flipPalette } from 'utils';
 
 export const theme: Theme = {
   name: 'listings-theme',
diff --git a/packages/angular/projects/ui-angular/src/lib/components/authenticator/components/confirm-sign-up/confirm-sign-up.component.ts b/packages/angular/projects/ui-angular/src/lib/components/authenticator/components/confirm-sign-up/confirm-sign-up.component.ts
@@ -1,4 +1,4 @@
-import { Component, HostBinding, Input } from '@angular/core';
+import { Component, HostBinding } from '@angular/core';
 import { AuthenticatorService } from '../../../../services/authenticator.service';
 import {
   FormFieldsArray,
diff --git a/packages/angular/projects/ui-angular/src/lib/components/authenticator/components/sign-up/sign-up-form-fields/sign-up-form-fields.component.ts b/packages/angular/projects/ui-angular/src/lib/components/authenticator/components/sign-up/sign-up-form-fields/sign-up-form-fields.component.ts
@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 
 @Component({
   selector: 'amplify-sign-up-form-fields',
diff --git a/packages/e2e/cypress/integration/ui/components/authenticator/confirm-sign-up/confirm-sign-up.steps.ts b/packages/e2e/cypress/integration/ui/components/authenticator/confirm-sign-up/confirm-sign-up.steps.ts
@@ -1,4 +1,4 @@
-import { Then, When } from '@badeball/cypress-cucumber-preprocessor';
+import { Then } from '@badeball/cypress-cucumber-preprocessor';
 
 Then('I see an error alert', () => {
   cy.findByRole('alert').should('exist');
diff --git a/packages/e2e/cypress/integration/ui/components/authenticator/reset-password/reset-password.steps.ts b/packages/e2e/cypress/integration/ui/components/authenticator/reset-password/reset-password.steps.ts
diff --git a/packages/e2e/cypress/integration/ui/theme/responsive/responsive.steps.ts b/packages/e2e/cypress/integration/ui/theme/responsive/responsive.steps.ts
@@ -1,9 +1,4 @@
-import {
-  And,
-  Given,
-  Then,
-  When,
-} from '@badeball/cypress-cucumber-preprocessor';
+import { And, Then } from '@badeball/cypress-cucumber-preprocessor';
 
 const breakpoints = {
   base: 0,
diff --git a/packages/react-core/src/InAppMessaging/utils/__tests__/handleMessageAction.spec.ts b/packages/react-core/src/InAppMessaging/utils/__tests__/handleMessageAction.spec.ts
@@ -40,7 +40,7 @@ describe('handleMessageAction', () => {
       expect(infoSpy).toHaveBeenCalledWith(`Handle action: ${action}`);
       expect(infoSpy).toHaveBeenCalledTimes(1);
       expect(warnSpy).toHaveBeenCalledWith(
-        `url must be of type string: ${invalidUrl}`
+        'url must be of type string. Received: null'
       );
       expect(warnSpy).toHaveBeenCalledTimes(1);
       expect(handleMessageLinkAction).not.toHaveBeenCalled();
@@ -56,7 +56,7 @@ describe('handleMessageAction', () => {
 
       expect(infoSpy).toHaveBeenCalledWith(`Handle action: ${action}`);
       expect(warnSpy).toHaveBeenCalledWith(
-        `url must be of type string: ${invalidUrl}`
+        'url must be of type string. Received: undefined'
       );
       expect(infoSpy).toHaveBeenCalledTimes(1);
       expect(warnSpy).toHaveBeenCalledTimes(1);
diff --git a/packages/react-core/src/InAppMessaging/utils/handleMessageAction.ts b/packages/react-core/src/InAppMessaging/utils/handleMessageAction.ts
@@ -22,7 +22,7 @@ const handleMessageAction = ({
 
   if (action === 'LINK' || action === 'DEEP_LINK') {
     if (!isString(url)) {
-      logger.warn(`url must be of type string: ${url}`);
+      logger.warn(`url must be of type string. Received: ${url}`);
       return;
     }
 
diff --git a/packages/react/src/components/Storage/FileUploader/UploadPreviewer/__tests__/UploadPreviewer.test.tsx b/packages/react/src/components/Storage/FileUploader/UploadPreviewer/__tests__/UploadPreviewer.test.tsx
@@ -27,11 +27,6 @@ const fileStatus2: FileStatus = {
 };
 const fileStatuses: FileStatuses = [fileStatus];
 const fileStatuses2: FileStatuses = [fileStatus, fileStatus2];
-const ref = {
-  current: {
-    info: jest.fn(),
-  },
-} as unknown as React.MutableRefObject<HTMLInputElement>;
 
 const commonProps = {
   aggregatePercentage: 0,
diff --git a/packages/react/src/components/Storage/FileUploader/__tests__/FileUploader.test.tsx b/packages/react/src/components/Storage/FileUploader/__tests__/FileUploader.test.tsx
@@ -471,7 +471,7 @@ describe('File Uploader', () => {
   });
 
   it.skip('shows the overridden Tracker component', async () => {
-    const UploadTracker = ({ name }) => <div>File Name: {name}</div>;
+    // const UploadTracker = ({ name }) => <div>File Name: {name}</div>;
 
     const fileStatuses = [fileStatus];
     useFileUploaderSpy.mockReturnValue({
@@ -491,9 +491,9 @@ describe('File Uploader', () => {
     ).toBeVisible();
   });
   it.skip('shows the overridden Previewer component', async () => {
-    const UploadPreviewer = ({ fileStatuses }) => (
-      <div>Preview: {fileStatuses[0].name} </div>
-    );
+    // const UploadPreviewer = ({ fileStatuses }) => (
+    //   <div>Preview: {fileStatuses[0].name} </div>
+    // );
     const fileStatuses = [fileStatus];
     useFileUploaderSpy.mockReturnValue({
       ...mockReturnUseFileUploader,
diff --git a/packages/react/src/components/Storage/FileUploader/hooks/useFileUploader/__tests__/useFileUploader.test.tsx b/packages/react/src/components/Storage/FileUploader/hooks/useFileUploader/__tests__/useFileUploader.test.tsx
@@ -223,8 +223,6 @@ describe('useFileUploader', () => {
       stopPropagation: () => null,
       dataTransfer: { dropEffect: '', files: [fakeFile] },
     } as any;
-    const eventPrevSpy = jest.spyOn(event, 'preventDefault');
-    const eventPropSpy = jest.spyOn(event, 'stopPropagation');
 
     const {
       current: { onDrop },
diff --git a/packages/react/src/components/ThemeProvider/__tests__/ThemeProvider.test.tsx b/packages/react/src/components/ThemeProvider/__tests__/ThemeProvider.test.tsx
@@ -62,7 +62,7 @@ describe('ThemeProvider', () => {
   });
 
   it('takes direction prop and sets dir', () => {
-    const { debug, container } = render(
+    const { container } = render(
       <ThemeProvider direction="rtl">
         <App />
       </ThemeProvider>
@@ -75,7 +75,7 @@ describe('ThemeProvider', () => {
   });
 
   it('takes the colorMode prop and sets [data-amplify-color-mode]', () => {
-    const { debug, container } = render(
+    const { container } = render(
       <ThemeProvider colorMode="light">
         <App />
       </ThemeProvider>
diff --git a/packages/react/src/hooks/__tests__/useDataStore.test.ts b/packages/react/src/hooks/__tests__/useDataStore.test.ts
@@ -127,7 +127,7 @@ describe('useDataStoreCollection', () => {
       fakeDataStoreObserveQuery
     );
 
-    const { result, unmount } = renderHook(() =>
+    const { unmount } = renderHook(() =>
       useDataStoreCollection({
         model: fakeModel,
       })
diff --git a/packages/react/src/primitives/Alert/__tests__/Alert.test.tsx b/packages/react/src/primitives/Alert/__tests__/Alert.test.tsx
@@ -3,8 +3,6 @@ import * as React from 'react';
 
 import { Alert } from '../Alert';
 import { ComponentClassNames, ComponentText } from '../../shared/constants';
-import { ComponentPropsToStylePropsMap } from '../../types';
-import kebabCase from 'lodash/kebabCase';
 
 describe('Alert: ', () => {
   it('can render Alert variations', async () => {
diff --git a/packages/react/src/primitives/Field/__tests__/FieldDescription.test.tsx b/packages/react/src/primitives/Field/__tests__/FieldDescription.test.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { render, screen } from '@testing-library/react';
+import { render } from '@testing-library/react';
 
 import { FieldDescription, QA_FIELD_DESCRIPTION } from '../FieldDescription';
 import { ComponentClassNames } from '../../shared/constants';
diff --git a/packages/react/src/primitives/Grid/__tests__/Grid.test.tsx b/packages/react/src/primitives/Grid/__tests__/Grid.test.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { render, screen, waitFor } from '@testing-library/react';
+import { render, screen } from '@testing-library/react';
 import kebabCase from 'lodash/kebabCase';
 
 import { Grid } from '../Grid';
diff --git a/packages/react/src/primitives/Menu/__tests_/menu.test.tsx b/packages/react/src/primitives/Menu/__tests_/menu.test.tsx
@@ -1,11 +1,10 @@
 import * as React from 'react';
-import { screen, render, cleanup } from '@testing-library/react';
+import { screen, render } from '@testing-library/react';
 
 import { ComponentClassNames } from '../../shared';
 import { Menu, MENU_ITEMS_GROUP_TEST_ID } from '../Menu';
 import { MenuItem, MENU_ITEM_TEST_ID } from '../MenuItem';
 import { MENU_TRIGGER_TEST_ID } from '../Menu';
-import userEvent from '@testing-library/user-event';
 
 // Needed because of the Radix Popper used by Menu
 // https://github.com/radix-ui/primitives/blob/main/packages/react/popper/src/Popper.tsx#L127
diff --git a/packages/react/src/primitives/SearchField/__tests__/SearchFieldButton.test.tsx b/packages/react/src/primitives/SearchField/__tests__/SearchFieldButton.test.tsx
@@ -7,8 +7,6 @@ import { ComponentClassNames, ComponentText } from '../../shared/constants';
 const ariaLabelText = ComponentText.SearchField.searchButtonLabel;
 
 describe('SearchFieldButton component', () => {
-  const testId = 'testId';
-
   it('should render default classname for SearchFieldButton', async () => {
     render(<SearchFieldButton />);
 
diff --git a/packages/react/src/primitives/SwitchField/__tests__/SwitchField.test.tsx b/packages/react/src/primitives/SwitchField/__tests__/SwitchField.test.tsx
@@ -230,7 +230,8 @@ describe('Switch Field', () => {
     });
 
     it('should render labeled radio when id is not provided and is autogenerated', async () => {
-      const { debug } = render(<SwitchField label={label} />);
+      render(<SwitchField label={label} />);
+
       const field = await screen.findByLabelText(label);
       expect(field.id.startsWith(AUTO_GENERATED_ID_PREFIX)).toBe(true);
     });
diff --git a/packages/react/src/primitives/SwitchField/useSwitch.ts b/packages/react/src/primitives/SwitchField/useSwitch.ts
@@ -1,4 +1,4 @@
-import React, { ChangeEvent, useCallback, useState } from 'react';
+import { ChangeEvent, useCallback, useState } from 'react';
 
 export const useSwitch = (props) => {
   const { onChange, isChecked, defaultChecked, isDisabled } = props;
diff --git a/packages/react/src/primitives/shared/__tests__/utils.test.tsx b/packages/react/src/primitives/shared/__tests__/utils.test.tsx
@@ -1,4 +1,3 @@
-import { ViewProps } from '../../types';
 import { createTheme } from '@aws-amplify/ui';
 import {
   getConsecutiveIntArray,
@@ -10,25 +9,6 @@ import {
 } from '../utils';
 import { ComponentClassNames } from '../constants';
 
-const props: ViewProps = {
-  backgroundColor: 'blue',
-  border: '1px solid black',
-  borderRadius: '6px',
-  boxShadow: '3px 3px 5px 6px #ccc',
-  color: 'red',
-  height: '100px',
-  maxHeight: '200px',
-  maxWidth: '200px',
-  minHeight: '100px',
-  minWidth: '100px',
-  opacity: '80%',
-  padding: '6px',
-  width: '100px',
-  as: 'section',
-  ariaLabel: 'important section',
-  className: 'my-section',
-};
-
 const theme = createTheme();
 const { tokens } = theme;
 
diff --git a/packages/react/src/primitives/shared/responsive/__tests__/useBreakpoint.test.ts b/packages/react/src/primitives/shared/responsive/__tests__/useBreakpoint.test.ts
@@ -1,7 +1,7 @@
 /** @jest-environment jsdom */
 
 import { useBreakpoint } from '../useBreakpoint';
-import { act, renderHook } from '@testing-library/react-hooks';
+import { renderHook } from '@testing-library/react-hooks';
 import MatchMediaMock from 'jest-matchmedia-mock';
 import * as React from 'react';
 import { Breakpoints } from '../../../types/responsive';
diff --git a/packages/ui/src/helpers/authenticator/textUtil.ts b/packages/ui/src/helpers/authenticator/textUtil.ts
@@ -9,7 +9,7 @@ import { AuthenticatorRoute } from './facade';
 /**
  * ConfirmSignIn
  */
-const getChallengeText = (challengeName: AuthChallengeName): string => {
+const getChallengeText = (challengeName?: AuthChallengeName): string => {
   switch (challengeName) {
     case 'SMS_MFA':
       return translate(DefaultTexts.CONFIRM_SMS);
diff --git a/packages/vue/src/components/confirm-sign-in.vue b/packages/vue/src/components/confirm-sign-in.vue
@@ -30,7 +30,7 @@ const { getBackToSignInText, getConfirmText, getChallengeText } =
   authenticatorTextUtil;
 
 // Computed Properties
-const confirmSignInHeading = computed(() => getChallengeText(challengeName!));
+const confirmSignInHeading = computed(() => getChallengeText(challengeName));
 const backSignInText = computed(() => getBackToSignInText());
 const confirmText = computed(() => getConfirmText());
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-import { fileURLToPath, URL } from 'url';`
`2`		`-`
`3`	`1`	`import { defineConfig } from 'vite';`
`4`	`2`	`import vue from '@vitejs/plugin-vue';`
`5`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Component, HostBinding, Input } from '@angular/core';`
	`1`	`+import { Component, HostBinding } from '@angular/core';`
`2`	`2`	`import { AuthenticatorService } from '../../../../services/authenticator.service';`
`3`	`3`	`import {`
`4`	`4`	`FormFieldsArray,`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Component, OnInit } from '@angular/core';`
	`1`	`+import { Component } from '@angular/core';`
`2`	`2`
`3`	`3`	`@Component({`
`4`	`4`	`selector: 'amplify-sign-up-form-fields',`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Then, When } from '@badeball/cypress-cucumber-preprocessor';`
	`1`	`+import { Then } from '@badeball/cypress-cucumber-preprocessor';`
`2`	`2`
`3`	`3`	`Then('I see an error alert', () => {`
`4`	`4`	`cy.findByRole('alert').should('exist');`