Skip to content

Commit 8350d36

Browse files
jacobloganJacob Loganhbuchel
authored
Dial code (#2459)
* rename countryCode to dialCode * begin deprecating countryCode by adding in duplicate dialCode props and updating all examples to use dialCode props * update props table * duplicate phone number field tests using dialCode * update tests * add required field to phoneNumberFieldProps, added deprecation warning * update e2e tests * update phone number field documentation * rename countrycode files to dialcode * update angular and vue dial code select name * update angular and vue to dial code * return default label to country code and undo e2e test changes * update unit tests * update e2e tests to revert change to dial code * Create swift-kids-help.md * Update docs/src/pages/[platform]/components/phonenumberfield/react.mdx add `role="none"` to docs alert Co-authored-by: Heather Buchel <[email protected]> * Update swift-kids-help.md Co-authored-by: Jacob Logan <[email protected]> Co-authored-by: Heather Buchel <[email protected]>
1 parent 4044c7d commit 8350d36

36 files changed

+500
-142
lines changed

.changeset/swift-kids-help.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
"amplify-ui-angular-mono": patch
3+
"@aws-amplify/ui-react": minor
4+
"@aws-amplify/ui-angular": patch
5+
---
6+
7+
Angular: Add `amplify-dialcodeselect` class which contains the previous countrycodeselect styles
8+
Vue: Add `amplify-dialcodeselect` class which contains the previous countrycodeselect styles
9+
React: Added 'dialCode' versions of all 'countryCode' props so that users can begin migrating away from the deprecated `countryCode`.
10+
11+
```
12+
countryCodeLabel => dialCodeLabel
13+
countryCodeName => dialCodeName
14+
onCountryCodeChange => onDialCodeChange
15+
countryCodeRef => dialCodeRef
16+
defaultCountryCode => defaultDialCode
17+
```

docs/src/pages/[platform]/components/phonenumberfield/PhoneNumberFieldPropControls.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ export interface PhoneNumberFieldPropControlsProps
4040
setValue: (
4141
value: React.SetStateAction<PhoneNumberFieldProps['value']>
4242
) => void;
43-
setDefaultCountryCode: (
44-
value: React.SetStateAction<PhoneNumberFieldProps['defaultCountryCode']>
43+
setDefaultDialCode: (
44+
value: React.SetStateAction<PhoneNumberFieldProps['defaultDialCode']>
4545
) => void;
4646
}
4747

docs/src/pages/[platform]/components/phonenumberfield/demo.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { getPropString } from '../utils/getPropString';
99
const propsToCode = (props) => {
1010
return (
1111
`<PhoneNumberField` +
12-
`\n defaultCountryCode="${props.defaultCountryCode}"` +
12+
`\n defaultDialCode="${props.defaultDialCode}"` +
1313
`\n label="${props.label}"` +
1414
(props.labelHidden ? `\n labelHidden` : '') +
1515
getPropString(props.descriptiveText, 'descriptiveText') +
@@ -25,7 +25,7 @@ const propsToCode = (props) => {
2525
};
2626

2727
const defaultPhoneNumberFieldProps: PhoneNumberFieldProps = {
28-
defaultCountryCode: '+1',
28+
defaultDialCode: '+1',
2929
label: 'Phone number',
3030
value: '',
3131
descriptiveText: 'Please enter your phone number',
@@ -51,9 +51,9 @@ export const PhoneNumberFieldDemo = () => {
5151
<PhoneNumberField
5252
value={phoneNumberFieldProps.value}
5353
onChange={(event) => phoneNumberFieldProps.setValue(event.target.value)}
54-
defaultCountryCode={phoneNumberFieldProps.defaultCountryCode}
55-
onCountryCodeChange={(event) =>
56-
phoneNumberFieldProps.setDefaultCountryCode(event.target.value)
54+
defaultDialCode={phoneNumberFieldProps.defaultDialCode}
55+
onDialCodeChange={(event) =>
56+
phoneNumberFieldProps.setDefaultDialCode(event.target.value)
5757
}
5858
label={phoneNumberFieldProps.label}
5959
labelHidden={phoneNumberFieldProps.labelHidden}

docs/src/pages/[platform]/components/phonenumberfield/examples/AccessibilityExample.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ export const AccessibilityExample = () => (
44
<PhoneNumberField
55
label="Phone Number"
66
labelHidden={true}
7-
defaultCountryCode="+1"
7+
defaultDialCode="+1"
88
placeholder="Phone Number"
9-
countryCodeLabel="Country code"
9+
dialCodeLabel="Dial code"
1010
/>
1111
);

docs/src/pages/[platform]/components/phonenumberfield/examples/AutoCompleteExample.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const AutoCompleteExample = () => {
1414
autoComplete="username"
1515
label="Phone Number"
1616
name="phone_number"
17-
defaultCountryCode="+1"
17+
defaultDialCode="+1"
1818
/>
1919
<Button type="submit">Sign In</Button>
2020
</Flex>

docs/src/pages/[platform]/components/phonenumberfield/examples/ClassNameExample.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { PhoneNumberField } from '@aws-amplify/ui-react';
33
export const ClassNameExample = () => (
44
<PhoneNumberField
55
className="custom-phonenumberfield-class"
6-
defaultCountryCode="+1"
6+
defaultDialCode="+1"
77
label="Square field"
88
/>
99
);

docs/src/pages/[platform]/components/phonenumberfield/examples/CountryCodeSelectExample.tsx

Lines changed: 0 additions & 14 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { PhoneNumberField } from '@aws-amplify/ui-react';
22

33
export const DefaultPhoneNumberFieldExample = () => (
4-
<PhoneNumberField label="Phone Number" defaultCountryCode="+1" />
4+
<PhoneNumberField label="Phone Number" defaultDialCode="+1" />
55
);

docs/src/pages/[platform]/components/phonenumberfield/examples/DescriptiveTextExample.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import { PhoneNumberField, Text } from '@aws-amplify/ui-react';
33
export const DescriptiveTextExample = () => (
44
<>
55
<PhoneNumberField
6-
defaultCountryCode="+1"
6+
defaultDialCode="+1"
77
label="Phone Number"
88
descriptiveText="This is basic descriptive text"
99
/>
1010
<PhoneNumberField
11-
defaultCountryCode="+1"
11+
defaultDialCode="+1"
1212
label="Phone Number"
1313
descriptiveText={
1414
<Text
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { PhoneNumberField } from '@aws-amplify/ui-react';
2+
3+
export const DialCodeSelectExample = () => (
4+
<PhoneNumberField
5+
label="Phone Number"
6+
defaultDialCode="+7"
7+
dialCodeList={['+1', '+44', '+52', '+86', '+91']}
8+
dialCodeName="dial_code"
9+
dialCodeLabel="Dial Code"
10+
onDialCodeChange={(e) => alert(`Dial Code changed to: ${e.target.value}`)}
11+
/>
12+
);

0 commit comments

Comments
 (0)