Skip to content

Conversation

jordanvn
Copy link
Member

Description of changes

  • Updates docs pages to reference File Uploader instead of Storage Manager
  • Changes page path to /fileuploader
  • Adds deprecation warning for Storage Manager
  • Updates message in GH templates

To Do:

Note: theming, and

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jordanvn jordanvn requested a review from a team as a code owner August 27, 2024 22:49
Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: 57425f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

README.md Outdated
| Geo (MapView) || | | |
| Account Settings || | | |
| Storage (StorageManager) || | | |
| Storage || | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Storage (StorageManager) || | | |
| Storage || | | |
| Storage (FileUploader) || | | |
| Storage (StorageImage) || | | |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 2 to 3
title: File Uploader
description: The File Uploader lets your users upload and manage files to the cloud.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: File Uploader
description: The File Uploader lets your users upload and manage files to the cloud.
title: FileUploader
description: The FileUploader lets your users upload and manage files in the cloud.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +171 to +175
{
source: '/react/connected-components/storage/storagemanager',
destination: '/react/connected-components/storage/fileuploader',
permanent: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cover redirects from the primary docs that are linking to the existing StorageManager documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so. This is the only endpoint linked in the primary docs. There is also a PR under review which updates the links to use the /fileuploader endpoint instead: aws-amplify/docs#7921

thaddmt
thaddmt previously approved these changes Sep 5, 2024
@jordanvn jordanvn merged commit 5a4b0e9 into main Sep 5, 2024
34 checks passed
@jordanvn jordanvn deleted the rename-storage-manager/docs branch September 5, 2024 19:47
calebpollman added a commit that referenced this pull request May 15, 2025
…5697)

* chore: rename references to Storage Manager in docs to File Uploader

* chore: reverting reference to StorageManager in deprecated props section

* chore: replacing /storagemanager with /fileuploader in test sitemap

* chore: update Storage Manager reference in README

* chore: removing references to not-yet-existing FileUploader component

* chore: reverting references to storageManager icon

* fix: fixing incorrect comma placement

* chore: make references to Storage in GitHub guides more generic

* chore: add redirect from storagemanager to fileuploader

* chore: add informational alert that storage manager has been renamed file uploader

* chore: moving warning to top of page and changing text

* chore: update text of name change warning

* chore: remove rename warning, move info alert to top of page

* Update docs/src/pages/[platform]/connected-components/storage/fileuploader/index.page.mdx

Co-authored-by: Caleb Pollman <[email protected]>

* Update docs/src/pages/[platform]/connected-components/storage/fileuploader/react.mdx

Co-authored-by: Scott Rees <[email protected]>

* chore: update rename alert text

* chore: add storage component specificity to readme

* chore: further update to alert text, breaking message into two paragraphs

---------

Co-authored-by: Caleb Pollman <[email protected]>
Co-authored-by: Scott Rees <[email protected]>
calebpollman added a commit that referenced this pull request May 15, 2025
…5697)

* chore: rename references to Storage Manager in docs to File Uploader

* chore: reverting reference to StorageManager in deprecated props section

* chore: replacing /storagemanager with /fileuploader in test sitemap

* chore: update Storage Manager reference in README

* chore: removing references to not-yet-existing FileUploader component

* chore: reverting references to storageManager icon

* fix: fixing incorrect comma placement

* chore: make references to Storage in GitHub guides more generic

* chore: add redirect from storagemanager to fileuploader

* chore: add informational alert that storage manager has been renamed file uploader

* chore: moving warning to top of page and changing text

* chore: update text of name change warning

* chore: remove rename warning, move info alert to top of page

* Update docs/src/pages/[platform]/connected-components/storage/fileuploader/index.page.mdx

Co-authored-by: Caleb Pollman <[email protected]>

* Update docs/src/pages/[platform]/connected-components/storage/fileuploader/react.mdx

Co-authored-by: Scott Rees <[email protected]>

* chore: update rename alert text

* chore: add storage component specificity to readme

* chore: further update to alert text, breaking message into two paragraphs

---------

Co-authored-by: Caleb Pollman <[email protected]>
Co-authored-by: Scott Rees <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants