Remove the check for INTERNET and ACCESS_NETWORK_STATE permissions (#1120)

Author: desokroshan

CHANGELOG.md

@@ -9,6 +9,11 @@
     - `ENABLE_S3_SIGV4_SYSTEM_PROPERTY`
     - `ENFORCE_S3_SIGV4_SYSTEM_PROPERTY`
 
+### Bug Fixes
+
+- **Amazon Pinpoint**
+  - Removed the check for INTERNET and ACCESS_NETWORK_STATE permissions while initializing `PinpointManager`. These are [normal permissions](https://developer.android.com/guide/topics/permissions/overview#normal_permissions) and therefore are not required to be checked before performing corresponding app-op. This changes Pinpoint SDK behavior to match that of our other SDKs where an `UnknownHostException` or a corresponding RuntimeException would be thrown if connectivity is not present when network calls are made by the SDK. This fixes [Issue#1092](https://github.com/aws-amplify/aws-sdk-android/issues/1092).
+
 ## [Release 2.14.2](https://github.com/aws/aws-sdk-android/releases/tag/release_v2.14.2)
 
 ### New Features

aws-android-sdk-pinpoint/src/main/java/com/amazonaws/mobileconnectors/pinpoint/PinpointManager.java

@@ -25,7 +25,6 @@
 import com.amazonaws.mobileconnectors.pinpoint.internal.core.util.Preconditions;
 import com.amazonaws.mobileconnectors.pinpoint.internal.core.util.SDKInfo;
 import com.amazonaws.mobileconnectors.pinpoint.internal.validate.EncodingValidator;
-import com.amazonaws.mobileconnectors.pinpoint.internal.validate.PermissionValidator;
 import com.amazonaws.mobileconnectors.pinpoint.targeting.TargetingClient;
 import com.amazonaws.mobileconnectors.pinpoint.targeting.notification.DeviceTokenRegisteredHandler;
 import com.amazonaws.mobileconnectors.pinpoint.targeting.notification.NotificationClient;
@@ -52,9 +51,6 @@ public class PinpointManager {
     private static final String SDK_NAME = "aws-sdk-android";
     private static final SDKInfo SDK_INFO = new SDKInfo(SDK_NAME, SDK_VERSION);
     private static final Log log = LogFactory.getLog(PinpointManager.class);
-    private static final PermissionValidator INTERNET_PERMISSION_VALIDATOR = new PermissionValidator("android.permission.INTERNET");
-    private static final PermissionValidator ACCESS_NETWORK_STATE_PERMISSION_VALIDATOR = new PermissionValidator(
-        "android.permission.ACCESS_NETWORK_STATE");
     private static final EncodingValidator ENCODING_VALIDATOR = new EncodingValidator("UTF-8");
 
     private final PinpointContext pinpointContext;
@@ -86,8 +82,6 @@ public PinpointManager(final PinpointConfiguration config) {
 
             final AmazonPinpointClient targetingServiceClient = new AmazonPinpointClient(credentialsProvider, config.getClientConfiguration());
 
-            INTERNET_PERMISSION_VALIDATOR.validate(appContext);
-            ACCESS_NETWORK_STATE_PERMISSION_VALIDATOR.validate(appContext);
             ENCODING_VALIDATOR.validate();
 
             this.pinpointContext = new PinpointContext(analyticsServiceClient, targetingServiceClient, appContext, appId, SDK_INFO, config);