Skip to content

Commit 2be6796

Browse files
changxu0306raphkim
authored andcommitted
Fix misspelled method getSessionCredentialsExpiration (#2219)
1 parent 0953879 commit 2be6796

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

aws-android-sdk-auth-core/src/main/java/com/amazonaws/mobile/auth/core/IdentityManager.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,25 +23,25 @@
2323

2424
import com.amazonaws.ClientConfiguration;
2525
import com.amazonaws.SDKGlobalConfiguration;
26-
2726
import com.amazonaws.auth.AWSBasicCognitoIdentityProvider;
2827
import com.amazonaws.auth.AWSCredentials;
2928
import com.amazonaws.auth.AWSCredentialsProvider;
3029
import com.amazonaws.auth.CognitoCachingCredentialsProvider;
31-
3230
import com.amazonaws.internal.keyvaluestore.AWSKeyValueStore;
31+
import com.amazonaws.mobile.auth.core.internal.util.ThreadUtils;
3332
import com.amazonaws.mobile.auth.core.signin.AuthException;
3433
import com.amazonaws.mobile.auth.core.signin.CognitoAuthException;
3534
import com.amazonaws.mobile.auth.core.signin.ProviderAuthException;
3635
import com.amazonaws.mobile.auth.core.signin.SignInManager;
3736
import com.amazonaws.mobile.auth.core.signin.SignInProvider;
3837
import com.amazonaws.mobile.auth.core.signin.SignInProviderResultHandler;
39-
import com.amazonaws.mobile.auth.core.internal.util.ThreadUtils;
4038
import com.amazonaws.mobile.config.AWSConfiguration;
41-
4239
import com.amazonaws.regions.Region;
4340
import com.amazonaws.regions.Regions;
4441

42+
import org.json.JSONException;
43+
import org.json.JSONObject;
44+
4545
import java.util.Collection;
4646
import java.util.Date;
4747
import java.util.HashMap;
@@ -53,9 +53,6 @@
5353
import java.util.concurrent.ExecutorService;
5454
import java.util.concurrent.Executors;
5555

56-
import org.json.JSONException;
57-
import org.json.JSONObject;
58-
5956
/**
6057
* The identity manager keeps track of the current sign-in provider and is responsible
6158
* for caching credentials.
@@ -344,7 +341,7 @@ public boolean areCredentialsExpired() {
344341
}
345342

346343
final Date credentialsExpirationDate =
347-
credentialsProviderHolder.getUnderlyingProvider().getSessionCredentitalsExpiration();
344+
credentialsProviderHolder.getUnderlyingProvider().getSessionCredentialsExpiration();
348345

349346
if (credentialsExpirationDate == null) {
350347
Log.d(LOG_TAG, "Credentials are EXPIRED.");

aws-android-sdk-core/src/main/java/com/amazonaws/auth/CognitoCredentialsProvider.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ public void setSessionCredentialsExpiration(Date expiration) {
440440
}
441441
}
442442

443-
public Date getSessionCredentitalsExpiration() {
443+
public Date getSessionCredentialsExpiration() {
444444
credentialsLock.readLock().lock();
445445
try {
446446
return sessionCredentialsExpiration;
@@ -449,6 +449,14 @@ public Date getSessionCredentitalsExpiration() {
449449
}
450450
}
451451

452+
/**
453+
* @deprecated Use {@link #getSessionCredentialsExpiration()} instead.
454+
*/
455+
@Deprecated
456+
public Date getSessionCredentitalsExpiration() {
457+
return getSessionCredentialsExpiration();
458+
}
459+
452460
public String getIdentityPoolId() {
453461
return identityProvider.getIdentityPoolId();
454462
}

aws-android-sdk-kinesisvideo/src/main/java/com/amazonaws/mobileconnectors/kinesisvideo/auth/KinesisVideoCredentialsProviderImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
package com.amazonaws.mobileconnectors.kinesisvideo.auth;
1919

20-
import java.util.Date;
21-
2220
import androidx.annotation.NonNull;
2321

2422
import com.amazonaws.auth.AWSCredentials;
@@ -31,6 +29,8 @@
3129
import com.amazonaws.kinesisvideo.common.logging.Log;
3230
import com.amazonaws.kinesisvideo.common.preconditions.Preconditions;
3331

32+
import java.util.Date;
33+
3434
/**
3535
* Implementation of the AWS Credentials Provider wrapper for Android
3636
*/
@@ -65,7 +65,7 @@ protected KinesisVideoCredentials updateCredentials() throws KinesisVideoExcepti
6565
final CognitoCredentialsProvider cognitoCredentialsProvider =
6666
(CognitoCredentialsProvider) credentialsProvider;
6767

68-
expiration = cognitoCredentialsProvider.getSessionCredentitalsExpiration();
68+
expiration = cognitoCredentialsProvider.getSessionCredentialsExpiration();
6969
log.debug("Refreshed token expiration is %s", expiration);
7070
}
7171

0 commit comments

Comments
 (0)