Skip to content

Commit 85fd36c

Browse files
authored
Fix custom auth integration test failures (#1199)
* Fix custom auth integration test failures
1 parent 0499ea5 commit 85fd36c

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

aws-android-sdk-mobile-client/src/androidTest/java/com/amazonaws/mobile/client/AWSMobileClientCustomAuthTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,11 @@
3535
import java.util.HashMap;
3636
import java.util.Map;
3737
import java.util.concurrent.CountDownLatch;
38+
import java.util.concurrent.TimeUnit;
3839

3940
import static com.amazonaws.mobile.auth.core.internal.util.ThreadUtils.runOnUiThread;
41+
import static com.amazonaws.mobile.client.AWSMobileClientTest.PASSWORD;
42+
import static com.amazonaws.mobile.client.AWSMobileClientTest.USERNAME;
4043
import static org.junit.Assert.assertNotNull;
4144
import static org.junit.Assert.assertTrue;
4245

@@ -46,8 +49,6 @@ public class AWSMobileClientCustomAuthTest extends AWSMobileClientTestBase {
4649
private static AWSMobileClient auth;
4750

4851
private static final CountDownLatch signUpLatch = new CountDownLatch(1);
49-
private static final String USERNAME = "customAuthTestUser";
50-
private static final String PASSWORD = "Test@123";
5152
private static final String TAG = AWSMobileClientCustomAuthTest.class.getSimpleName();
5253

5354
@BeforeClass
@@ -203,7 +204,7 @@ public void onError(Exception e) {
203204
});
204205

205206
try {
206-
signUpLatch.await();
207+
signUpLatch.await(20, TimeUnit.SECONDS);
207208
return true;
208209
} catch (InterruptedException e) {
209210
e.printStackTrace();
@@ -239,7 +240,7 @@ public void onError(Exception e) {
239240
});
240241

241242
try {
242-
signUpLatch.await();
243+
signUpLatch.await(20, TimeUnit.SECONDS);
243244
} catch (InterruptedException e) {
244245
e.printStackTrace();
245246
}

aws-android-sdk-mobile-client/src/main/java/com/amazonaws/mobile/client/AWSMobileClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1165,7 +1165,7 @@ public void onSuccess(CognitoUserSession userSession, CognitoDevice newDevice) {
11651165
public void getAuthenticationDetails(AuthenticationContinuation authenticationContinuation, String userId) {
11661166
Log.d(TAG, "Sending password.");
11671167
try {
1168-
if (awsConfiguration.optJsonObject("Auth").getString("authenticationFlowType").equals("CUSTOM_AUTH")) {
1168+
if (awsConfiguration.optJsonObject("Auth") != null && awsConfiguration.optJsonObject("Auth").has("authenticationFlowType") && awsConfiguration.optJsonObject("Auth").getString("authenticationFlowType").equals("CUSTOM_AUTH")) {
11691169
final HashMap<String, String> authParameters = new HashMap<String,String>();
11701170
authenticationContinuation.setAuthenticationDetails(new AuthenticationDetails(username, password, authParameters, validationData));
11711171
} else {

0 commit comments

Comments
 (0)