Skip to content

Commit a002409

Browse files
tjleingThomas Leing
andauthored
Read version number from build instead of hardcoding it (#3412)
* Read version number from build instead of hardcoding it * Also re-enable build config * Fix test * empty commit to retrigger tests --------- Co-authored-by: Thomas Leing <[email protected]>
1 parent 9134f0b commit a002409

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

aws-android-sdk-core/src/main/java/com/amazonaws/util/VersionInfoUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
package com.amazonaws.util;
1717

18+
import com.amazonaws.BuildConfig;
1819
import com.amazonaws.logging.Log;
1920
import com.amazonaws.logging.LogFactory;
2021

@@ -26,7 +27,7 @@ public class VersionInfoUtils {
2627
private static final int DEFAULT_STRING_LENGTH = 128;
2728

2829
/** SDK version info */
29-
private static volatile String version = "2.22.6";
30+
private static volatile String version = BuildConfig.VERSION_NAME;
3031
// changed build
3132
// logic
3233

aws-android-sdk-core/src/test/java/com/amazonaws/util/VersionInfoUtilsTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
package com.amazonaws.util;
1717

18+
import com.amazonaws.BuildConfig;
1819
import static org.junit.Assert.assertEquals;
1920
import static org.junit.Assert.assertNotNull;
2021

@@ -24,7 +25,7 @@ public class VersionInfoUtilsTest {
2425

2526
@Test
2627
public void getVersion() {
27-
assertEquals("2.22.6", VersionInfoUtils.getVersion());
28+
assertEquals(BuildConfig.VERSION_NAME, VersionInfoUtils.getVersion());
2829
}
2930

3031
@Test

gradle.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ org.gradle.jvmargs=-Xmx1536m
1414

1515
# Disable Gradle Android plugin features.
1616
# Reference: https://developer.android.com/studio/releases/gradle-plugin#4-0-0-new
17-
android.defaults.buildfeatures.buildconfig=false
1817
android.defaults.buildfeatures.aidl=false
1918
android.defaults.buildfeatures.renderscript=false
2019
android.defaults.buildfeatures.resvalues=false

0 commit comments

Comments
 (0)