Update cache when awsconfig file changes (#2946)

* Update cache when awsconfig file changes

* added comment to the change

Co-authored-by: Banji Jolaoso <[email protected]>

Author: banji180

aws-android-sdk-mobile-client/src/main/java/com/amazonaws/mobile/client/AWSMobileClient.java

@@ -705,19 +705,18 @@ JSONObject getHostedUIJSON() {
     JSONObject getHostedUIJSON(final AWSConfiguration awsConfig) {
         try {
             JSONObject hostedUIJSONFromJSON = getHostedUIJSONFromJSON(awsConfig);
-            if (hostedUIJSONFromJSON == null) {
-                return null;
-            }
-
             final String hostedUIString = mStore.get(HOSTED_UI_KEY);
             JSONObject hostedUIJSON = null;
             try {
                 hostedUIJSON = new JSONObject(hostedUIString);
             } catch (Exception e) {
                 Log.w(TAG,
-                        "Failed to parse HostedUI settings from store. Defaulting to awsconfiguration.json", e);
+                        "Failed to parse HostedUI settings from store", e);
             }
-            if (hostedUIJSON == null && hostedUIJSONFromJSON != null) {
+
+            // Since there is no file watcher to keep track of when config file changes, this logic is intended to always check if the config file is different from mstore cache and updates the later accordingly.
+            // If config file cannot be loaded, the mstore data still prevails.
+            if (hostedUIJSONFromJSON != null && (hostedUIJSON == null || hostedUIJSON.toString() != hostedUIJSONFromJSON.toString())) {
                 hostedUIJSON = new JSONObject(hostedUIJSONFromJSON.toString());
                 mStore.set(HOSTED_UI_KEY, hostedUIJSON.toString());
             }