Skip to content

Conversation

@ykethan
Copy link
Member

@ykethan ykethan commented Aug 15, 2024

Description of changes:

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ykethan ykethan marked this pull request as ready for review October 9, 2024 20:16
@ykethan ykethan requested review from a team, aspittel and swaminator as code owners October 9, 2024 20:16
@ykethan ykethan requested a review from josefaidt October 9, 2024 21:07
@ykethan ykethan requested a review from josefaidt October 10, 2024 02:54
@ykethan ykethan enabled auto-merge (squash) October 10, 2024 16:29
};
}

Amplify offers the ability to add layers to your Functions which contain your library dependencies. To get started, specify the `layers` property in `defineFunction`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase f on functions

@ykethan ykethan merged commit 435cc5b into aws-amplify:main Oct 10, 2024
12 checks passed
Copy link
Contributor

@swaminator swaminator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tell customers explicitly that if they want to set up a layer, they should first do that and reference it in their Amplify project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants