Add placeholder update handler for CDI (#34)

Author: chaitao93

aws-macie-customdataidentifier/aws-macie-customdataidentifier.json

@@ -99,6 +99,9 @@
       "permissions": [
         "macie2:ListCustomDataIdentifiers"
       ]
+    },
+    "update": {
+      "permissions": []
     }
   }
 }

aws-macie-customdataidentifier/pom.xml

@@ -23,7 +23,7 @@
         <dependency>
             <groupId>software.amazon.cloudformation</groupId>
             <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
-            <version>2.0.0</version>
+            <version>[2.0.0, 3.0.0)</version>
         </dependency>
         <!-- https://mvnrepository.com/artifact/org.projectlombok/lombok -->
         <dependency>

aws-macie-customdataidentifier/src/main/java/software/amazon/macie/customdataidentifier/UpdateHandler.java

@@ -4,6 +4,7 @@
 import software.amazon.cloudformation.exceptions.CfnInvalidRequestException;
 import software.amazon.cloudformation.proxy.AmazonWebServicesClientProxy;
 import software.amazon.cloudformation.proxy.Logger;
+import software.amazon.cloudformation.proxy.OperationStatus;
 import software.amazon.cloudformation.proxy.ProgressEvent;
 import software.amazon.cloudformation.proxy.ProxyClient;
 import software.amazon.cloudformation.proxy.ResourceHandlerRequest;
@@ -16,8 +17,12 @@ protected ProgressEvent<ResourceModel, CallbackContext> handleRequest(
         final ProxyClient<Macie2Client> proxyClient,
         final Logger logger
     ) {
-        logger.log(String
-            .format("Exception occurred for AWS account id [%s]. %s does not have an update handler.", request.getAwsAccountId(), ResourceModel.TYPE_NAME));
-        throw new CfnInvalidRequestException(ResourceModel.TYPE_NAME);
+        logger.log(String.format("AWS Account ID [%s] triggered %s dummy update handler",
+            request.getAwsAccountId(), ResourceModel.TYPE_NAME));
+
+        return ProgressEvent.<ResourceModel, CallbackContext>builder()
+            .resourceModel(request.getDesiredResourceState())
+            .status(OperationStatus.SUCCESS)
+            .build();
     }
 }

aws-macie-customdataidentifier/src/test/java/software/amazon/macie/customdataidentifier/UpdateHandlerTest.java

@@ -9,11 +9,14 @@
 import software.amazon.awssdk.services.macie2.Macie2Client;
 import software.amazon.cloudformation.exceptions.CfnInvalidRequestException;
 import software.amazon.cloudformation.proxy.AmazonWebServicesClientProxy;
+import software.amazon.cloudformation.proxy.OperationStatus;
+import software.amazon.cloudformation.proxy.ProgressEvent;
 import software.amazon.cloudformation.proxy.ProxyClient;
 import software.amazon.cloudformation.proxy.ResourceHandlerRequest;
 
 import java.time.Duration;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 
 @ExtendWith(MockitoExtension.class)
@@ -45,8 +48,15 @@ public void handleRequest_whenUpdateCalled_thenThrowInvalidRequestException() {
             .desiredResourceState(model)
             .build();
 
-        Assertions.assertThrows(CfnInvalidRequestException.class,
-                                () ->handler.handleRequest(proxy, request, new CallbackContext(), proxyClient, logger));
+        final ProgressEvent<ResourceModel, CallbackContext> response = handler.handleRequest(proxy, request, new CallbackContext(), proxyClient, logger);
 
+        assertThat(response).isNotNull();
+        assertThat(response.getStatus()).isEqualTo(OperationStatus.SUCCESS);
+        assertThat(response.getCallbackContext()).isNull();
+        assertThat(response.getCallbackDelaySeconds()).isEqualTo(0);
+        assertThat(response.getResourceModel()).isEqualTo(ResourceModel.builder().build());
+        assertThat(response.getResourceModels()).isNull();
+        assertThat(response.getMessage()).isNull();
+        assertThat(response.getErrorCode()).isNull();
     }
 }

aws-macie-findingsfilter/pom.xml

@@ -23,7 +23,7 @@
         <dependency>
             <groupId>software.amazon.cloudformation</groupId>
             <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
-            <version>2.0.0</version>
+            <version>[2.0.0, 3.0.0)</version>
         </dependency>
         <!-- https://mvnrepository.com/artifact/org.projectlombok/lombok -->
         <dependency>

aws-macie-session/pom.xml

@@ -30,7 +30,7 @@
         <dependency>
             <groupId>software.amazon.cloudformation</groupId>
             <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
-            <version>2.0.0</version>
+            <version>[2.0.0, 3.0.0)</version>
         </dependency>
         <!-- https://mvnrepository.com/artifact/org.projectlombok/lombok -->
         <dependency>