Skip to content

Commit 94f6fb9

Browse files
John Tompkinstobywf
authored andcommitted
Removing DescribeRule call at end of void scheduler method (#191)
1 parent 472b64b commit 94f6fb9

File tree

3 files changed

+0
-39
lines changed

3 files changed

+0
-39
lines changed

src/main/java/com/amazonaws/cloudformation/scheduler/CloudWatchScheduler.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929

3030
import software.amazon.awssdk.services.cloudwatchevents.CloudWatchEventsClient;
3131
import software.amazon.awssdk.services.cloudwatchevents.model.DeleteRuleRequest;
32-
import software.amazon.awssdk.services.cloudwatchevents.model.DescribeRuleRequest;
3332
import software.amazon.awssdk.services.cloudwatchevents.model.PutRuleRequest;
3433
import software.amazon.awssdk.services.cloudwatchevents.model.PutTargetsRequest;
3534
import software.amazon.awssdk.services.cloudwatchevents.model.RemoveTargetsRequest;
@@ -116,9 +115,6 @@ public <ResourceT, CallbackT> void rescheduleAfterMinutes(final String functionA
116115
Target target = Target.builder().arn(functionArn).id(targetId).input(jsonRequest).build();
117116
PutTargetsRequest putTargetsRequest = PutTargetsRequest.builder().targets(target).rule(putRuleRequest.name()).build();
118117
this.client.putTargets(putTargetsRequest);
119-
120-
DescribeRuleRequest describeRuleRequest = DescribeRuleRequest.builder().name(ruleName).build();
121-
this.client.describeRule(describeRuleRequest);
122118
}
123119

124120
/**

src/test/java/com/amazonaws/cloudformation/scheduler/CloudWatchSchedulerTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,5 @@ public void test_rescheduleAfterMinutes_1MinuteFloor() {
176176
.putTargets(argThat(new PutTargetsRequestMatcher("reinvoke-handler-", new TargetsListMatcher(targetMatchers))));
177177
verify(client, times(1))
178178
.putRule(argThat(new PutRuleRequestMatcher("reinvoke-handler-", "cron(41 14 31 10 ? 2019)", RuleState.ENABLED)));
179-
verify(client, times(1)).describeRule(argThat(new DescribeRuleRequestMatcher("reinvoke-handler-")));
180179
}
181180
}

src/test/java/com/amazonaws/cloudformation/scheduler/DescribeRuleRequestMatcher.java

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)