Bump checkstyle from 8.18 to 8.29 (#232)

* Bump checkstyle from 8.18 to 8.29

Author: dependabot[bot]

pom.xml

@@ -38,7 +38,7 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <awssdk.version>2.10.49</awssdk.version>
-        <checkstyle.version>8.18</checkstyle.version>
+        <checkstyle.version>8.29</checkstyle.version>
         <commons-io.version>2.6</commons-io.version>
         <jackson.version>2.10.1</jackson.version>
         <maven-checkstyle-plugin.version>3.1.0</maven-checkstyle-plugin.version>
@@ -211,7 +211,6 @@
         </dependency>
     </dependencies>
     <pluginRepositories>
-        <!-- Supports software.amazon.awssdk:build-tools -->
         <pluginRepository>
             <id>jitpack.io</id>
             <url>https://jitpack.io</url>
@@ -226,6 +225,11 @@
                 <version>${spotless.version}</version>
                 <configuration>
                     <java>
+                        <!-- this automatically inserts line breaks, so apply it before eclipse formatter! -->
+                        <importOrder>
+                            <order>com,java,javax,org,software</order>
+                        </importOrder>
+                        <removeUnusedImports/>
                         <eclipse>
                             <!-- This formatter covers alot of linting, but not 100% of what checkstyle will enforce -->
                             <file>${basedir}/src/main/resources/com/amazonaws/cloudformation/eclipse-java-formatter.xml</file>
@@ -234,10 +238,6 @@
                         <licenseHeader>
                             <file>licenseHeader</file>
                         </licenseHeader>
-                        <removeUnusedImports/>
-                        <importOrder>
-                            <order>com,java,javax,org,software</order>
-                        </importOrder>
                     </java>
                 </configuration>
                 <executions>
@@ -342,11 +342,6 @@
                         <artifactId>checkstyle</artifactId>
                         <version>${checkstyle.version}</version>
                     </dependency>
-                    <dependency>
-                        <groupId>com.github.aws.aws-sdk-java-v2</groupId>
-                        <artifactId>build-tools</artifactId>
-                        <version>2.10.18</version>
-                    </dependency>
                 </dependencies>
                 <executions>
                     <execution>

src/main/java/software/amazon/cloudformation/LambdaWrapper.java

@@ -15,15 +15,13 @@
 package software.amazon.cloudformation;
 
 import static com.google.common.util.concurrent.Uninterruptibles.sleepUninterruptibly;
-
 import com.amazonaws.AmazonServiceException;
 import com.amazonaws.services.lambda.runtime.Context;
 import com.amazonaws.services.lambda.runtime.LambdaLogger;
 import com.amazonaws.services.lambda.runtime.RequestStreamHandler;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;
 import com.google.common.annotations.VisibleForTesting;
-
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
@@ -36,14 +34,12 @@
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
-
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.json.JSONObject;
 import org.json.JSONTokener;
-
 import software.amazon.awssdk.http.SdkHttpClient;
 import software.amazon.awssdk.http.apache.ApacheHttpClient;
 import software.amazon.awssdk.utils.StringUtils;

src/main/java/software/amazon/cloudformation/Response.java

@@ -15,9 +15,7 @@
 package software.amazon.cloudformation;
 
 import java.util.List;
-
 import lombok.Data;
-
 import software.amazon.cloudformation.proxy.HandlerErrorCode;
 import software.amazon.cloudformation.proxy.OperationStatus;
 

src/main/java/software/amazon/cloudformation/exceptions/BaseHandlerException.java

@@ -15,7 +15,6 @@
 package software.amazon.cloudformation.exceptions;
 
 import lombok.Getter;
-
 import software.amazon.cloudformation.proxy.HandlerErrorCode;
 
 @Getter

src/main/java/software/amazon/cloudformation/injection/CloudFormationProvider.java

@@ -15,7 +15,6 @@
 package software.amazon.cloudformation.injection;
 
 import java.net.URI;
-
 import software.amazon.awssdk.http.SdkHttpClient;
 import software.amazon.awssdk.services.cloudformation.CloudFormationClient;
 

src/main/java/software/amazon/cloudformation/loggers/CloudWatchLogHelper.java

@@ -15,10 +15,8 @@
 package software.amazon.cloudformation.loggers;
 
 import com.amazonaws.services.lambda.runtime.LambdaLogger;
-
 import java.time.Instant;
 import java.util.UUID;
-
 import software.amazon.awssdk.services.cloudwatchlogs.CloudWatchLogsClient;
 import software.amazon.awssdk.services.cloudwatchlogs.model.CreateLogGroupRequest;
 import software.amazon.awssdk.services.cloudwatchlogs.model.CreateLogStreamRequest;

src/main/java/software/amazon/cloudformation/loggers/CloudWatchLogPublisher.java

@@ -15,10 +15,8 @@
 package software.amazon.cloudformation.loggers;
 
 import com.amazonaws.services.lambda.runtime.LambdaLogger;
-
 import java.time.Instant;
 import java.util.Date;
-
 import software.amazon.awssdk.services.cloudwatchlogs.CloudWatchLogsClient;
 import software.amazon.awssdk.services.cloudwatchlogs.model.InputLogEvent;
 import software.amazon.awssdk.services.cloudwatchlogs.model.PutLogEventsRequest;

src/main/java/software/amazon/cloudformation/metrics/MetricsPublisher.java

@@ -15,7 +15,6 @@
 package software.amazon.cloudformation.metrics;
 
 import java.time.Instant;
-
 import software.amazon.cloudformation.Action;
 import software.amazon.cloudformation.proxy.HandlerErrorCode;
 

src/main/java/software/amazon/cloudformation/metrics/MetricsPublisherImpl.java

@@ -19,7 +19,6 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-
 import software.amazon.awssdk.services.cloudwatch.CloudWatchClient;
 import software.amazon.awssdk.services.cloudwatch.model.Dimension;
 import software.amazon.awssdk.services.cloudwatch.model.MetricDatum;

src/main/java/software/amazon/cloudformation/proxy/AmazonWebServicesClientProxy.java

@@ -22,7 +22,6 @@
 import com.amazonaws.auth.BasicSessionCredentials;
 import com.google.common.base.Preconditions;
 import com.google.common.util.concurrent.Uninterruptibles;
-
 import java.time.Duration;
 import java.time.Instant;
 import java.time.temporal.ChronoUnit;
@@ -31,9 +30,7 @@
 import java.util.function.BiFunction;
 import java.util.function.Function;
 import java.util.function.Supplier;
-
 import javax.annotation.Nonnull;
-
 import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
 import software.amazon.awssdk.auth.credentials.AwsSessionCredentials;
 import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;