Skip to content

Commit 2f1269c

Browse files
authored
Revert "Increase Boto assumeRole duration to 6 hours (#814)" (#817)
This reverts commit 866db5a.
1 parent f53256c commit 2f1269c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/rpdk/core/boto_helpers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def get_temporary_credentials(session, key_names=BOTO_CRED_KEYS, role_arn=None):
4444
)
4545
try:
4646
response = sts_client.assume_role(
47-
RoleArn=role_arn, RoleSessionName=session_name, DurationSeconds=21600
47+
RoleArn=role_arn, RoleSessionName=session_name, DurationSeconds=900
4848
)
4949
except ClientError:
5050
# pylint: disable=W1201
@@ -64,7 +64,7 @@ def get_temporary_credentials(session, key_names=BOTO_CRED_KEYS, role_arn=None):
6464
creds = (frozen.access_key, frozen.secret_key, frozen.token)
6565
else:
6666
try:
67-
response = sts_client.get_session_token(DurationSeconds=21600)
67+
response = sts_client.get_session_token(DurationSeconds=900)
6868
except ClientError as e:
6969
LOG.debug(
7070
"Getting session token resulted in unknown ClientError", exc_info=e

tests/test_boto_helpers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def test_get_temporary_credentials_needs_token():
101101
endpoint_url="https://sts.us-east-2.amazonaws.com",
102102
region_name="us-east-2",
103103
)
104-
client.get_session_token.assert_called_once_with(DurationSeconds=21600)
104+
client.get_session_token.assert_called_once_with(DurationSeconds=900)
105105

106106
assert len(creds) == 3
107107
assert tuple(creds.keys()) == LOWER_CAMEL_CRED_KEYS
@@ -135,7 +135,7 @@ def test_get_temporary_credentials_invalid_credentials():
135135
endpoint_url="https://sts.us-east-2.amazonaws.com",
136136
region_name="us-east-2",
137137
)
138-
client.get_session_token.assert_called_once_with(DurationSeconds=21600)
138+
client.get_session_token.assert_called_once_with(DurationSeconds=900)
139139

140140

141141
def test_get_temporary_credentials_assume_role_fails():
@@ -163,7 +163,7 @@ def test_get_temporary_credentials_assume_role_fails():
163163
region_name="us-east-2",
164164
)
165165
client.assume_role.assert_called_once_with(
166-
RoleArn=EXPECTED_ROLE, RoleSessionName=ANY, DurationSeconds=21600
166+
RoleArn=EXPECTED_ROLE, RoleSessionName=ANY, DurationSeconds=900
167167
)
168168

169169

@@ -192,7 +192,7 @@ def test_get_temporary_credentials_assume_role():
192192
region_name="cn-north-1",
193193
)
194194
client.assume_role.assert_called_once_with(
195-
RoleArn=EXPECTED_ROLE, RoleSessionName=ANY, DurationSeconds=21600
195+
RoleArn=EXPECTED_ROLE, RoleSessionName=ANY, DurationSeconds=900
196196
)
197197

198198
assert len(creds) == 3

0 commit comments

Comments
 (0)