chore(CI): Update github actions to latest versions (#933)

* Update github actions to latest

* update actions in contract-integration workflow

* Update actions for pypi-release

* Update actions for schema-updater

* Update setup-java action to distribution from v1 in contract-integration

* enable pip and pre-commit caching, enable manual workflow trigger

* Add python version cache key for precommit cache

* continue on error but fail pipeline if error happened during integration run

* remove set +e and set -o pipefail, GHA doesn't appear to reference pipefail for status

* Make cfn test more verbose in contract integration test

* Remove contract integration from pull requests but keep for push/merge to main branch

Author: mmaeng

.github/workflows/contract-integration.yaml

@@ -1,23 +1,25 @@
 on:
   push:
     branches: [ master ]
-  pull_request:
-    branches: [ master ]
+
+  workflow_dispatch: # Enables on-demand/manual triggering: https://docs.github.com/en/free-pro-team@latest/actions/managing-workflow-runs/manually-running-a-workflow
 jobs:
   contract-integration-java:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
+      - uses: actions/checkout@v3
         with:
           repository: aws-cloudformation/aws-cloudformation-resource-providers-lookoutvision
           path: lookoutvision
-      - uses: actions/setup-java@v1
+      - uses: actions/setup-java@v3
         with:
+          distribution: 'zulu'  # match distribution for v1
           java-version: 8
-      - uses: actions/setup-python@v2
+      - uses: actions/setup-python@v4
         with:
           python-version: 3
+          cache: 'pip'
       - run: |
           pip install -e .
           cd lookoutvision/*project
@@ -27,7 +29,7 @@ jobs:
           sam local start-lambda &
           pip install --quiet cloudformation-cli-java-plugin cloudformation-cli-python-plugin
           mvn package --no-transfer-progress -Dmaven.test.skip=true
-          cfn test --enforce-timeout 240
+          cfn test --enforce-timeout 240 -vvv
           ! grep -q -E -i '(accessKeyId|secretAccessKey|sessionToken)' rpdk.log*
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -36,14 +38,15 @@ jobs:
   contract-integration-python:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
+      - uses: actions/checkout@v3
         with:
           repository: aws-cloudformation/aws-cloudformation-resource-providers-frauddetector
           path: frauddetector
-      - uses: actions/setup-python@v2
+      - uses: actions/setup-python@v4
         with:
           python-version: 3
+          cache: 'pip'
       - run: |
           pip install -e .
           cd frauddetector/*outcome
@@ -53,7 +56,7 @@ jobs:
           sam local start-lambda &
           pip install --quiet cloudformation-cli-java-plugin cloudformation-cli-python-plugin
           cfn submit --dry-run
-          cfn test --enforce-timeout 240
+          cfn test --enforce-timeout 240 -vvv
           ! grep -q -E -i '(accessKeyId|secretAccessKey|sessionToken)' rpdk.log*
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}

.github/workflows/pr-ci.yaml

@@ -2,11 +2,7 @@
 # This workflow will install Python dependencies, run tests and lint with a multiple versions of Python
 name: CloudFormation CLI Pull Request CI
 
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ master ]
+on: [push, pull_request]
 
 jobs:
   build:
@@ -18,17 +14,22 @@ jobs:
         os: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python ${{ matrix.python }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python }}
+        cache: 'pip'
     - name: Install dependencies
       run: |
         pip install --upgrade 'attrs==19.2.0' wheel -r requirements.txt
     - name: Install cli
       run: |
         pip install .
+    - uses: actions/cache@v3
+      with:
+        path: ~/.cache/pre-commit/
+        key: ${{ matrix.os }}-${{ env.pythonLocation }}${{ hashFiles('.pre-commit-config.yaml') }}
     - name: pre-commit, twine checks
       run: |
         pre-commit run --all-files

.github/workflows/pypi-release.yaml

@@ -9,11 +9,12 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python 3.8
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: 3.8
+        cache: 'pip'
     - name: Install dependencies
       run: |
         pip install --upgrade wheel twine

.github/workflows/schema-updater.yaml

@@ -6,7 +6,7 @@ jobs:
   schema-updater:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - run: |
           curl https://raw.githubusercontent.com/aws-cloudformation/aws-cloudformation-resource-schema/master/src/main/resources/schema/provider.definition.schema.v1.json > src/rpdk/core/data/schema/provider.definition.schema.v1.json
       - uses: peter-evans/create-pull-request@v3