change 403 error mapping from expired to service error

Author: Zee2413

src/utils/AwsErrorMapper.ts

@@ -19,7 +19,6 @@ const CREDENTIAL_ERROR_NAMES = new Set([
     'UnrecognizedClientException',
     'ExpiredToken',
     'ExpiredTokenException',
-    'AccessDeniedException',
 ]);
 
 const NETWORK_ERROR_NAMES = new Set([
@@ -46,7 +45,7 @@ function isCredentialError(error: AwsError): boolean {
     }
 
     const statusCode = error.$metadata?.httpStatusCode;
-    return statusCode === 401 || statusCode === 403;
+    return statusCode === 401;
 }
 
 function isNetworkError(error: AwsError): boolean {

tst/unit/utils/AwsErrorMapper.test.ts

@@ -23,10 +23,10 @@ describe('mapAwsErrorToLspError', () => {
         expect(result.code).toBe(OnlineFeatureErrorCode.ExpiredCredentials);
     });
 
-    it('should map 403 status to ExpiredCredentials', () => {
+    it('should map 403 status to AwsServiceError', () => {
         const error = { $metadata: { httpStatusCode: 403 }, message: 'Forbidden' };
         const result = mapAwsErrorToLspError(error);
-        expect(result.code).toBe(OnlineFeatureErrorCode.ExpiredCredentials);
+        expect(result.code).toBe(OnlineFeatureErrorCode.AwsServiceError);
     });
 
     it('should map network errors to NoInternet', () => {