Improve code quality checks (#215)

Author: satyakigh

.github/workflows/benchmark.yml

@@ -37,7 +37,7 @@ jobs:
           npm run benchmark -- \
             --templates tst/resources/templates/*.json tst/resources/templates/*.yaml \
             --output benchmark-results.md \
-            --iterations 5000
+            --iterations 2500
 
       - name: Generate timestamp
         id: timestamp

.github/workflows/pr.yml

@@ -2,14 +2,15 @@ name: Pull Request
 
 on:
   pull_request:
+    types: [opened, edited, reopened, synchronize]
     branches: [ main ]
 
 jobs:
   get-configs:
     uses: ./.github/workflows/configs.yml
 
   pr-build-test-nodejs:
-    needs: [get-configs]
+    needs: [ get-configs ]
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -29,11 +30,14 @@ jobs:
       - name: Build
         run: npm run build
 
-      - name: Lint and Test
-        run: npm run lint && npm run test
+      - name: Code Quality
+        run: npm run lint && npm run check:duplicates
+
+      - name: Test
+        run: npm run test
 
   pr-build-test-go:
-    needs: [get-configs]
+    needs: [ get-configs ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5

.jscpd.json

@@ -15,7 +15,7 @@
     "src"
   ],
   "gitignore": true,
-  "threshold": 1,
+  "threshold": 0.8,
   "minLines": 10,
   "output": "./jscpd",
   "reporters": [

src/auth/AwsSdkCredentialsProvider.ts

@@ -15,7 +15,7 @@ import { SyntaxTreeManager } from '../context/syntaxtree/SyntaxTreeManager';
 import { NodeSearch } from '../context/syntaxtree/utils/NodeSearch';
 import { NodeType } from '../context/syntaxtree/utils/NodeType';
 import { DocumentManager } from '../document/DocumentManager';
-import { ANALYZE_DIAGNOSTIC, TRACK_CODE_ACTION_ACCEPTED } from '../handlers/ExecutionHandler';
+import { TRACK_CODE_ACTION_ACCEPTED } from '../handlers/ExecutionHandler';
 import { CfnInfraCore } from '../server/CfnInfraCore';
 import { CFN_VALIDATION_SOURCE } from '../stacks/actions/ValidationWorkflow';
 import { LoggerFactory } from '../telemetry/LoggerFactory';
@@ -69,10 +69,6 @@ export class CodeActionService {
             }
         }
 
-        if (params.context.diagnostics.length > 0) {
-            codeActions.push(this.generateAIAnalysisAction(params.textDocument.uri, params.context.diagnostics));
-        }
-
         if (this.shouldOfferRefactorActions(params)) {
             const refactorActions = this.generateRefactorActions(params);
             codeActions.push(...refactorActions);
@@ -107,19 +103,6 @@ export class CodeActionService {
         return fixes;
     }
 
-    private generateAIAnalysisAction(uri: string, diagnostics: Diagnostic[]): CodeAction {
-        return {
-            title: 'Ask AI',
-            kind: 'quickfix',
-            diagnostics,
-            command: {
-                title: 'Ask AI',
-                command: ANALYZE_DIAGNOSTIC,
-                arguments: [uri, diagnostics],
-            },
-        };
-    }
-
     /**
      * Generate fixes for CFN Validation diagnostics
      */

src/services/CodeActionService.ts

@@ -33,23 +33,10 @@ describe('CodeActionService', () => {
     });
 
     function verifyCodeAction(params: CodeActionParams, actual: CodeAction[], ...expected: CodeAction[]) {
-        expect(actual.length).toBe(expected.length + 1);
+        expect(actual.length).toBe(expected.length);
         for (const [index, expectedAction] of expected.entries()) {
             expect(equal(actual[index], expectedAction)).toBe(true);
         }
-
-        expect(
-            equal(actual[actual.length - 1], {
-                title: 'Ask AI',
-                kind: 'quickfix',
-                diagnostics: params.context.diagnostics,
-                command: {
-                    title: 'Ask AI',
-                    command: '/command/llm/diagnostic/analyze',
-                    arguments: [params.textDocument.uri, params.context.diagnostics],
-                },
-            }),
-        ).toBe(true);
     }
 
     describe('generateCodeActions', () => {

tst/unit/services/CodeActionService.test.ts

@@ -1,20 +1,33 @@
 import { defineConfig } from 'vitest/config';
 
 export default defineConfig({
-  test: {
-    globals: true,
-    environment: 'node',
-    include: ['tst/**/*.test.ts'],
-    exclude: ['**/node_modules/**', '**/out/**'],
-    setupFiles: ['tst/setup.ts'],
-    coverage: {
-      provider: 'v8',
-      reporter: ['cobertura', 'html', 'text'],
-      include: ['src/**/*.{js,ts}'],
-      enabled: true,
+    test: {
+        globals: true,
+        environment: 'node',
+        include: ['tst/**/*.test.ts'],
+        exclude: ['**/node_modules/**', '**/out/**'],
+        setupFiles: ['tst/setup.ts'],
+        coverage: {
+            provider: 'v8',
+            reporter: ['cobertura', 'html', 'text'],
+            include: ['src/**/*.{js,ts}'],
+            enabled: true,
+            thresholds: {
+                statements: 85,
+                branches: 85,
+                functions: 85,
+                lines: 85,
+            },
+            exclude: [
+                'src/ai/**',
+                'src/services/cfnLint/pyodide-worker.ts',
+                'src/telemetry/OTELInstrumentation.ts',
+                'src/telemetry/TelemetryService.ts',
+                'src/services/guard/assets/**',
+            ],
+        },
+        pool: 'forks', // Run tests in separate processes for better isolation
+        isolate: true, // Ensure each test file runs in isolation
+        testTimeout: 30000, // Increase timeout for longer-running tests
     },
-    pool: 'forks', // Run tests in separate processes for better isolation
-    isolate: true, // Ensure each test file runs in isolation
-    testTimeout: 30000, // Increase timeout for longer-running tests
-  },
 });

vitest.config.ts

@@ -2,9 +2,9 @@ import { defineConfig } from 'vitest/config';
 import baseConfig from './vitest.config';
 
 export default defineConfig({
-  ...baseConfig,
-  test: {
-    ...baseConfig.test,
-    include: ['tst/integration/**/*.test.ts', 'tst/e2e/**/*.test.ts'],
-  },
+    ...baseConfig,
+    test: {
+        ...baseConfig.test,
+        include: ['tst/integration/**/*.test.ts', 'tst/e2e/**/*.test.ts'],
+    },
 });

vitest.integration.config.ts

@@ -2,9 +2,9 @@ import { defineConfig } from 'vitest/config';
 import baseConfig from './vitest.config';
 
 export default defineConfig({
-  ...baseConfig,
-  test: {
-    ...baseConfig.test,
-    include: ['tst/unit/**/*.test.ts'],
-  },
+    ...baseConfig,
+    test: {
+        ...baseConfig.test,
+        include: ['tst/unit/**/*.test.ts'],
+    },
 });