Run tests on all machines (#276)

Author: satyakigh

.github/workflows/build-and-test.yml

@@ -33,7 +33,7 @@ jobs:
     uses: ./.github/workflows/configs.yml
 
   build-test-nodejs:
-    needs: [get-configs]
+    needs: [ get-configs ]
     runs-on: ${{ inputs.runs-on }}
     steps:
       - uses: actions/checkout@v5
@@ -57,12 +57,15 @@ jobs:
       - name: Build
         run: npm run build
 
-      - name: Lint and Test
+      - name: Code Quality
         if: runner.os != 'Windows'
-        run: npm run lint && npm run test
+        run: npm run lint && npm run check:duplicates
+
+      - name: Test
+        run: npm run test
 
   build-test-go:
-    needs: [get-configs]
+    needs: [ get-configs ]
     runs-on: ${{ inputs.runs-on }}
     steps:
       - name: Checkout repository

.github/workflows/ci.yml

@@ -9,5 +9,10 @@ jobs:
     uses: ./.github/workflows/build-and-test.yml
     permissions:
       contents: read
+    strategy:
+      fail-fast: true
+      matrix:
+        os: [ ubuntu-22.04, macos-latest ]
     with:
       ref: ${{ github.sha }}
+      runs-on: ${{ matrix.os }}

.github/workflows/pr.yml

@@ -11,7 +11,11 @@ jobs:
 
   pr-build-test-nodejs:
     needs: [ get-configs ]
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        os: [ ubuntu-22.04, macos-latest ]
+    runs-on: ${{ matrix.os }}
     permissions:
       contents: read
       pull-requests: write
@@ -31,14 +35,19 @@ jobs:
         run: npm run build
 
       - name: Code Quality
+        if: runner.os != 'Windows'
         run: npm run lint && npm run check:duplicates
 
       - name: Test
         run: npm run test
 
   pr-build-test-go:
     needs: [ get-configs ]
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        os: [ ubuntu-22.04, macos-latest ]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v5
 

package-lock.json

@@ -23,11 +23,10 @@
     "clean": "rm -rf build && rm -rf bundle && rm -rf coverage && rm -rf node_modules && rm -rf out && rm -rf jscpd",
     "build": "rm -rf out && tsc -b",
     "watch": "rm -rf out && tsc -b -w",
-    "test": "NODE_ENV=test vitest run",
-    "test:watch": "NODE_ENV=test vitest",
-    "test:integration": "NODE_ENV=test vitest run --config vitest.integration.config.ts",
-    "test:unit": "NODE_ENV=test vitest run --config vitest.unit.config.ts",
-    "test:leaks": "NODE_ENV=test vitest run --pool=forks --logHeapUsage",
+    "test": "cross-env NODE_ENV=test vitest run",
+    "test:integration": "cross-env NODE_ENV=test vitest run --config vitest.integration.config.ts",
+    "test:unit": "cross-env NODE_ENV=test vitest run --config vitest.unit.config.ts",
+    "test:leaks": "cross-env NODE_ENV=test vitest run --pool=forks --logHeapUsage",
     "lint": "eslint --cache --cache-location node_modules/.cache/eslint --max-warnings 0 .",
     "lint:fix": "npm run lint -- --fix",
     "build:go:dev": "GOPROXY=direct go build -C cfn-init/cmd -v -o ../../bundle/development/bin/cfn-init",
@@ -38,8 +37,8 @@
     "bundle:beta": "rm -rf out && webpack --env mode=production --env env=beta",
     "bundle:prod": "rm -rf out && webpack --env mode=production --env env=prod",
     "download-wheels": "tsx tools/download-wheels.ts",
-    "benchmark": "NODE_ENV=test AWS_ENV=alpha node --max-old-space-size=16384 --expose-gc -r ts-node/register tools/benchmark.ts",
-    "generate-metrics": "NODE_ENV=development AWS_ENV=alpha node --max-old-space-size=16384 -r ts-node/register tools/telemetry-generator.ts",
+    "benchmark": "cross-env NODE_ENV=test AWS_ENV=alpha node --max-old-space-size=16384 --expose-gc -r ts-node/register tools/benchmark.ts",
+    "generate-metrics": "cross-env NODE_ENV=development AWS_ENV=alpha node --max-old-space-size=16384 -r ts-node/register tools/telemetry-generator.ts",
     "debug-tree": "node -r ts-node/register tools/debug_tree.ts",
     "generate:guard-rules": "node -r ts-node/register tools/generate-guard-rules.ts",
     "check:duplicates": "jscpd",
@@ -109,6 +108,7 @@
     "@vitest/eslint-plugin": "1.3.4",
     "aws-sdk-client-mock": "4.1.0",
     "copy-webpack-plugin": "13.0.1",
+    "cross-env": "10.1.0",
     "eslint": "9.34.0",
     "eslint-config-prettier": "10.1.8",
     "eslint-plugin-import": "2.32.0",