Mark isComplete based on max completions (#73)

Author: kddejong

src/autocomplete/CompletionRouter.ts

@@ -95,7 +95,7 @@ export class CompletionRouter implements SettingsConfigurable, Closeable {
             return completions.then((result) => {
                 return this.formatter.format(
                     {
-                        isIncomplete: false,
+                        isIncomplete: result.length > this.completionSettings.maxCompletions,
                         items: result.slice(0, this.completionSettings.maxCompletions),
                     },
                     context,
@@ -104,7 +104,7 @@ export class CompletionRouter implements SettingsConfigurable, Closeable {
             });
         } else if (completions) {
             const completionList = {
-                isIncomplete: false,
+                isIncomplete: completions.length > this.completionSettings.maxCompletions,
                 items: completions.slice(0, this.completionSettings.maxCompletions),
             };
 

tst/unit/autocomplete/CompletionRouter.test.ts

@@ -794,4 +794,46 @@ describe('CompletionRouter', () => {
             });
         });
     });
+
+    describe('isIncomplete handling', () => {
+        test('should set isIncomplete to true when results exceed maxCompletions', () => {
+            const mockProvider = {
+                getCompletions: vi
+                    .fn()
+                    .mockReturnValue(Array.from({ length: 150 }, (_, i) => ({ label: `Item${i}`, kind: 1 }))),
+            };
+
+            completionRouter['completionProviderMap'].set('TopLevelSection', mockProvider);
+            completionRouter['completionSettings'] = { ...completionRouter['completionSettings'], maxCompletions: 100 };
+
+            const mockContext = createTopLevelContext('Unknown', { text: '' });
+            mockComponents.contextManager.getContext.returns(mockContext);
+
+            const result = completionRouter.getCompletions(mockParams) as CompletionList | undefined;
+
+            expect(result).toBeDefined();
+            expect(result!.isIncomplete).toBe(true);
+            expect(result!.items.length).toBe(100);
+        });
+
+        test('should set isIncomplete to false when results are within maxCompletions', () => {
+            const mockProvider = {
+                getCompletions: vi
+                    .fn()
+                    .mockReturnValue(Array.from({ length: 50 }, (_, i) => ({ label: `Item${i}`, kind: 1 }))),
+            };
+
+            completionRouter['completionProviderMap'].set('TopLevelSection', mockProvider);
+            completionRouter['completionSettings'] = { ...completionRouter['completionSettings'], maxCompletions: 100 };
+
+            const mockContext = createTopLevelContext('Unknown', { text: '' });
+            mockComponents.contextManager.getContext.returns(mockContext);
+
+            const result = completionRouter.getCompletions(mockParams) as CompletionList | undefined;
+
+            expect(result).toBeDefined();
+            expect(result!.isIncomplete).toBe(false);
+            expect(result!.items.length).toBe(50);
+        });
+    });
 });