rev-2 addressed comments

Deep Furiya · Deep Furiya · commit 3f010a6f45b6 · 2025-11-04T16:09:51.000-05:00
diff --git a/src/autocomplete/ResourceSectionCompletionProvider.ts b/src/autocomplete/ResourceSectionCompletionProvider.ts
@@ -90,12 +90,12 @@ export class ResourceSectionCompletionProvider implements CompletionProvider {
     }
 
     private isAtResourceTypeField(context: Context): boolean {
-        if (context.propertyPath[context.propertyPath.length - 1] !== 'Type') {
-            return false;
-        }
-        const startIndex = context.getEntityType() === EntityType.ForEachResource ? 4 : 2;
-        const propertiesIndex = context.propertyPath.indexOf('Properties', startIndex);
-        return propertiesIndex === -1;
+        const propertyPathLength = context.getEntityType() === EntityType.ForEachResource ? 5 : 3;
+
+        return (
+            context.propertyPath.length === propertyPathLength &&
+            context.propertyPath[context.propertyPath.length - 1] === 'Type'
+        );
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -90,12 +90,12 @@ export class ResourceSectionCompletionProvider implements CompletionProvider {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`private isAtResourceTypeField(context: Context): boolean {`
`93`		`- if (context.propertyPath[context.propertyPath.length - 1] !== 'Type') {`
`94`		`- return false;`
`95`		`- }`
`96`		`- const startIndex = context.getEntityType() === EntityType.ForEachResource ? 4 : 2;`
`97`		`- const propertiesIndex = context.propertyPath.indexOf('Properties', startIndex);`
`98`		`- return propertiesIndex === -1;`
	`93`	`+ const propertyPathLength = context.getEntityType() === EntityType.ForEachResource ? 5 : 3;`
	`94`	`+`
	`95`	`+ return (`
	`96`	`+ context.propertyPath.length === propertyPathLength &&`
	`97`	`+ context.propertyPath[context.propertyPath.length - 1] === 'Type'`
	`98`	`+ );`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`