Skip to content

Commit 676359c

Browse files
Zee2413Zee2413
authored
change type coercion (as) to check with satisfies (#338)
1 parent 84165c1 commit 676359c

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

‎tst/e2e/ResourceState.test.ts‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ describe('ResourceState E2E', () => {
7676

7777
await client.send('aws/cfn/resources/list', {
7878
resources: [{ resourceType: 'AWS::Lambda::Function' }],
79-
} as ListResourcesParams);
79+
} satisfies ListResourcesParams);
8080

8181
const result = (await client.send('aws/cfn/resources/types', {})) as ResourceTypesResult;
8282

@@ -88,7 +88,7 @@ describe('ResourceState E2E', () => {
8888
it('should return empty array when no resources requested', async () => {
8989
const result = (await client.send('aws/cfn/resources/list', {
9090
resources: [],
91-
} as ListResourcesParams)) as ListResourcesResult;
91+
} satisfies ListResourcesParams)) as ListResourcesResult;
9292

9393
expect(result.resources).toEqual([]);
9494
});
@@ -101,7 +101,7 @@ describe('ResourceState E2E', () => {
101101

102102
const result = (await client.send('aws/cfn/resources/list', {
103103
resources: [{ resourceType: 'AWS::Lambda::Function' }],
104-
} as ListResourcesParams)) as ListResourcesResult;
104+
} satisfies ListResourcesParams)) as ListResourcesResult;
105105

106106
expect(result.resources).toHaveLength(1);
107107
expect(result.resources[0].typeName).toBe('AWS::Lambda::Function');
@@ -122,7 +122,7 @@ describe('ResourceState E2E', () => {
122122

123123
const result = (await client.send('aws/cfn/resources/list', {
124124
resources: [{ resourceType: 'AWS::Lambda::Function' }, { resourceType: 'AWS::DynamoDB::Table' }],
125-
} as ListResourcesParams)) as ListResourcesResult;
125+
} satisfies ListResourcesParams)) as ListResourcesResult;
126126

127127
expect(result.resources).toHaveLength(2);
128128
expect(result.resources.map((r) => r.typeName)).toContain('AWS::Lambda::Function');
@@ -138,7 +138,7 @@ describe('ResourceState E2E', () => {
138138

139139
const result = (await client.send('aws/cfn/resources/list', {
140140
resources: [{ resourceType: 'AWS::Lambda::Function' }],
141-
} as ListResourcesParams)) as ListResourcesResult;
141+
} satisfies ListResourcesParams)) as ListResourcesResult;
142142

143143
expect(result.resources[0].nextToken).toBe('token-123');
144144
});
@@ -153,7 +153,7 @@ describe('ResourceState E2E', () => {
153153

154154
await client.send('aws/cfn/resources/list', {
155155
resources: [{ resourceType: 'AWS::Lambda::Function' }],
156-
} as ListResourcesParams);
156+
} satisfies ListResourcesParams);
157157

158158
mockCloudControlSend.resolves({
159159
TypeName: 'AWS::Lambda::Function',
@@ -166,7 +166,7 @@ describe('ResourceState E2E', () => {
166166
const result = (await client.send('aws/cfn/resources/search', {
167167
resourceType: 'AWS::Lambda::Function',
168168
identifier: 'my-function',
169-
} as SearchResourceParams)) as SearchResourceResult;
169+
} satisfies SearchResourceParams)) as SearchResourceResult;
170170

171171
expect(result.found).toBe(true);
172172
expect(result.resource?.resourceIdentifiers).toContain('my-function');
@@ -180,14 +180,14 @@ describe('ResourceState E2E', () => {
180180

181181
await client.send('aws/cfn/resources/list', {
182182
resources: [{ resourceType: 'AWS::Lambda::Function' }],
183-
} as ListResourcesParams);
183+
} satisfies ListResourcesParams);
184184

185185
mockCloudControlSend.rejects(new Error('ResourceNotFoundException'));
186186

187187
const result = (await client.send('aws/cfn/resources/search', {
188188
resourceType: 'AWS::Lambda::Function',
189189
identifier: 'non-existent',
190-
} as SearchResourceParams)) as SearchResourceResult;
190+
} satisfies SearchResourceParams)) as SearchResourceResult;
191191

192192
expect(result.found).toBe(false);
193193
expect(result.resource).toBeUndefined();
@@ -203,7 +203,7 @@ describe('ResourceState E2E', () => {
203203

204204
const result = (await client.send('aws/cfn/resources/refresh', {
205205
resources: [{ resourceType: 'AWS::Lambda::Function' }],
206-
} as RefreshResourcesParams)) as RefreshResourcesResult;
206+
} satisfies RefreshResourcesParams)) as RefreshResourcesResult;
207207

208208
expect(result.resources).toHaveLength(1);
209209
expect(result.resources[0].typeName).toBe('AWS::Lambda::Function');
@@ -217,7 +217,7 @@ describe('ResourceState E2E', () => {
217217

218218
await client.send('aws/cfn/resources/list', {
219219
resources: [{ resourceType: 'AWS::Lambda::Function' }],
220-
} as ListResourcesParams);
220+
} satisfies ListResourcesParams);
221221

222222
mockCloudControlSend.resolves({
223223
TypeName: 'AWS::Lambda::Function',
@@ -226,7 +226,7 @@ describe('ResourceState E2E', () => {
226226

227227
const result = (await client.send('aws/cfn/resources/refresh', {
228228
resources: [{ resourceType: 'AWS::Lambda::Function' }],
229-
} as RefreshResourcesParams)) as RefreshResourcesResult;
229+
} satisfies RefreshResourcesParams)) as RefreshResourcesResult;
230230

231231
expect(result.resources[0].resourceIdentifiers).toHaveLength(2);
232232
});
@@ -241,7 +241,7 @@ describe('ResourceState E2E', () => {
241241

242242
const listResult = (await client.send('aws/cfn/resources/list', {
243243
resources: [{ resourceType: 'AWS::Lambda::Function' }],
244-
} as ListResourcesParams)) as ListResourcesResult;
244+
} satisfies ListResourcesParams)) as ListResourcesResult;
245245

246246
expect(listResult.resources).toHaveLength(1);
247247
expect(listResult.resources[0].typeName).toBe('AWS::Lambda::Function');
@@ -256,7 +256,7 @@ describe('ResourceState E2E', () => {
256256

257257
const listAfterRemove = (await client.send('aws/cfn/resources/list', {
258258
resources: [{ resourceType: 'AWS::Lambda::Function' }],
259-
} as ListResourcesParams)) as ListResourcesResult;
259+
} satisfies ListResourcesParams)) as ListResourcesResult;
260260

261261
expect(listAfterRemove.resources[0].resourceIdentifiers).toHaveLength(0);
262262
});
@@ -287,7 +287,7 @@ describe('ResourceState E2E', () => {
287287
},
288288
],
289289
purpose: ResourceStatePurpose.IMPORT,
290-
} as ResourceStateParams)) as ResourceStateResult;
290+
} satisfies ResourceStateParams)) as ResourceStateResult;
291291

292292
expect(result.successfulImports['AWS::S3::Bucket']).toContain('my-bucket');
293293
expect(result.failedImports).toEqual({});
@@ -323,7 +323,7 @@ describe('ResourceState E2E', () => {
323323
},
324324
],
325325
purpose: ResourceStatePurpose.IMPORT,
326-
} as ResourceStateParams)) as ResourceStateResult;
326+
} satisfies ResourceStateParams)) as ResourceStateResult;
327327

328328
expect(result.successfulImports['AWS::S3::Bucket']).toHaveLength(2);
329329
expect(result.successfulImports['AWS::S3::Bucket']).toContain('bucket-1');
@@ -355,7 +355,7 @@ describe('ResourceState E2E', () => {
355355
},
356356
],
357357
purpose: ResourceStatePurpose.IMPORT,
358-
} as ResourceStateParams)) as ResourceStateResult;
358+
} satisfies ResourceStateParams)) as ResourceStateResult;
359359

360360
// Verify at least one resource was processed
361361
expect(result.successfulImports['AWS::S3::Bucket']).toBeDefined();
@@ -370,7 +370,7 @@ describe('ResourceState E2E', () => {
370370
textDocument: { uri },
371371
resourceSelections: undefined,
372372
purpose: ResourceStatePurpose.IMPORT,
373-
} as ResourceStateParams)) as ResourceStateResult;
373+
} satisfies ResourceStateParams)) as ResourceStateResult;
374374

375375
expect(result.successfulImports).toEqual({});
376376
expect(result.completionItem).toBeUndefined();
@@ -403,7 +403,7 @@ describe('ResourceState E2E', () => {
403403
},
404404
],
405405
purpose: ResourceStatePurpose.IMPORT,
406-
} as ResourceStateParams)) as ResourceStateResult;
406+
} satisfies ResourceStateParams)) as ResourceStateResult;
407407

408408
expect(result.successfulImports['AWS::Lambda::Function']).toContain('my-function');
409409
expect(result.completionItem).toBeDefined();
@@ -442,7 +442,7 @@ describe('ResourceState E2E', () => {
442442
},
443443
],
444444
purpose: ResourceStatePurpose.IMPORT,
445-
} as ResourceStateParams)) as ResourceStateResult;
445+
} satisfies ResourceStateParams)) as ResourceStateResult;
446446

447447
expect(result.successfulImports['AWS::S3::Bucket']).toContain('my-bucket');
448448
expect(result.successfulImports['AWS::Lambda::Function']).toContain('my-function');
@@ -473,7 +473,7 @@ describe('ResourceState E2E', () => {
473473
},
474474
],
475475
purpose: ResourceStatePurpose.IMPORT,
476-
} as ResourceStateParams)) as ResourceStateResult;
476+
} satisfies ResourceStateParams)) as ResourceStateResult;
477477

478478
expect(result.successfulImports['AWS::Lambda::Function']).toContain('function-1');
479479
expect(result.failedImports['AWS::Lambda::Function']).toContain('function-2');
@@ -505,7 +505,7 @@ describe('ResourceState E2E', () => {
505505
},
506506
],
507507
purpose: ResourceStatePurpose.CLONE,
508-
} as ResourceStateParams)) as ResourceStateResult;
508+
} satisfies ResourceStateParams)) as ResourceStateResult;
509509

510510
expect(result.successfulImports['AWS::S3::Bucket']).toContain('source-bucket');
511511
expect(result.completionItem).toBeDefined();
@@ -537,7 +537,7 @@ describe('ResourceState E2E', () => {
537537
},
538538
],
539539
purpose: ResourceStatePurpose.CLONE,
540-
} as ResourceStateParams)) as ResourceStateResult;
540+
} satisfies ResourceStateParams)) as ResourceStateResult;
541541

542542
expect(result.successfulImports['AWS::Lambda::Function']).toContain('source-function');
543543
});
@@ -628,7 +628,7 @@ Resources:
628628

629629
await client.send('aws/cfn/resources/list', {
630630
resources: [{ resourceType: 'AWS::Lambda::Function' }],
631-
} as ListResourcesParams);
631+
} satisfies ListResourcesParams);
632632

633633
// Mock GetResource for search
634634
mockCloudControlSend.resolves({
@@ -642,7 +642,7 @@ Resources:
642642
const searchResult = (await client.send('aws/cfn/resources/search', {
643643
resourceType: 'AWS::Lambda::Function',
644644
identifier: 'integration-function',
645-
} as SearchResourceParams)) as SearchResourceResult;
645+
} satisfies SearchResourceParams)) as SearchResourceResult;
646646

647647
expect(searchResult.found).toBe(true);
648648

@@ -667,7 +667,7 @@ Resources:
667667
},
668668
],
669669
purpose: ResourceStatePurpose.IMPORT,
670-
} as ResourceStateParams)) as ResourceStateResult;
670+
} satisfies ResourceStateParams)) as ResourceStateResult;
671671

672672
expect(importResult.successfulImports['AWS::Lambda::Function']).toContain('integration-function');
673673
});

0 commit comments

Comments
 (0)