Fix todo tests (#363)

Author: satyakigh

src/services/extractToParameter/TemplateStructureUtils.ts

@@ -6,9 +6,6 @@ import { YamlSyntaxTree } from '../../context/syntaxtree/YamlSyntaxTree';
 import { DocumentType } from '../../document/Document';
 import { parseJson } from '../../document/JsonParser';
 import { parseYaml } from '../../document/YamlParser';
-// import { LoggerFactory } from '../../telemetry/LoggerFactory';
-
-// const log = LoggerFactory.getLogger('TemplateStructureUtils');
 
 /**
  * Result of searching for Parameters section in a CloudFormation template.

src/utils/ErrorStackInfo.ts

@@ -23,5 +23,6 @@ export function determineSensitiveInfo(): string[] {
         errorStackInfo = [];
     }
 
+    errorStackInfo = [__dirname.trim(), ...errorStackInfo];
     return errorStackInfo;
 }

tst/e2e/Completion.test.ts

@@ -1674,7 +1674,7 @@ Resources:
                 await client.closeDocument({ textDocument: { uri } });
             });
 
-            it.todo('should show optional properties after required ones fulfilled', async () => {
+            it('should show optional properties after required ones fulfilled', async () => {
                 const template = getSimpleYamlTemplateText();
                 const updatedTemplate = `AWSTemplateFormatVersion: '2010-09-09'
 Description: Lambda function ListBucketsCommand.
@@ -1696,7 +1696,7 @@ Resources:
             return response.Buckets;
           };
       `;
-                const uri = await client.openJsonTemplate(template);
+                const uri = await client.openYamlTemplate(template);
 
                 await client.changeDocument({
                     textDocument: { uri, version: 2 },
@@ -1712,9 +1712,30 @@ Resources:
                 expect(completions?.items).toBeDefined();
 
                 const labels = completions.items.map((item: any) => item.label);
-                expect(labels).toContain('Architecture');
-
-                // works in functional testing and json, failing in YAML
+                expect(labels).toEqual([
+                    'Description',
+                    'TracingConfig',
+                    'VpcConfig',
+                    'RuntimeManagementConfig',
+                    'ReservedConcurrentExecutions',
+                    'SnapStart',
+                    'FileSystemConfigs',
+                    'FunctionName',
+                    'KmsKeyArn',
+                    'PackageType',
+                    'CodeSigningConfigArn',
+                    'Layers',
+                    'Tags',
+                    'ImageConfig',
+                    'MemorySize',
+                    'DeadLetterConfig',
+                    'Timeout',
+                    'LoggingConfig',
+                    'RecursiveLoop',
+                    'Environment',
+                    'EphemeralStorage',
+                    'Architectures',
+                ]);
 
                 await client.closeDocument({ textDocument: { uri } });
             });
@@ -3519,7 +3540,7 @@ Resources:
         });
 
         describe('Cross-Reference Completions', () => {
-            it.todo('should provide condition reference completions in resources', async () => {
+            it('should provide condition reference completions in resources', async () => {
                 const template = getSimpleJsonTemplateText();
                 const updatedTemplate = `{
 "AWSTemplateFormatVersion": "2010-09-09",
@@ -3558,10 +3579,6 @@ Resources:
                 const labels = completions.items.map((item: any) => item.label);
                 expect(labels).toContain('CreateProdResources');
 
-                // todo: condition are not provided as completions
-                // although template validation throws error
-                // '' is not one of ['CreateProdResources']
-
                 await client.closeDocument({ textDocument: { uri } });
             });
         });
@@ -3787,8 +3804,29 @@ Resources:
                 expect(completions?.items).toBeDefined();
 
                 const labels = completions.items.map((item: any) => item.label);
-                expect(labels).toContain('Description');
-                expect(labels).toContain('Architectures');
+                expect(labels).toEqual([
+                    'Description',
+                    'TracingConfig',
+                    'VpcConfig',
+                    'RuntimeManagementConfig',
+                    'ReservedConcurrentExecutions',
+                    'SnapStart',
+                    'FileSystemConfigs',
+                    'KmsKeyArn',
+                    'PackageType',
+                    'CodeSigningConfigArn',
+                    'Layers',
+                    'Tags',
+                    'ImageConfig',
+                    'MemorySize',
+                    'DeadLetterConfig',
+                    'Timeout',
+                    'LoggingConfig',
+                    'RecursiveLoop',
+                    'Environment',
+                    'EphemeralStorage',
+                    'Architectures',
+                ]);
 
                 await client.closeDocument({ textDocument: { uri } });
             });

tst/unit/services/extractToParameter/TemplateStructureUtils.test.ts

@@ -97,13 +97,14 @@ Resources: {}`;
             expect(result?.exists).toBe(false);
         });
 
-        it.todo('should handle malformed YAML gracefully', () => {
-            const malformedYaml = 'Parameters:\n  - invalid: structure';
-
-            const result = utils.findParametersSection(malformedYaml, DocumentType.YAML);
-
-            expect(result).toBeDefined();
-            expect(result?.exists).toBe(false);
+        it('should handle malformed YAML gracefully', () => {
+            expect(utils.findParametersSection('Parameters:\n  - invalid: structure', DocumentType.YAML)?.exists).toBe(
+                true,
+            );
+
+            expect(utils.findParametersSection('Parameters:- invalid: structure', DocumentType.YAML)?.exists).toBe(
+                false,
+            );
         });
     });