Updated to use parseValidYaml (#208)

Author: rongyamazon

package-lock.json

@@ -5,7 +5,7 @@ import { detectCfnFileType } from './CloudFormationDetection';
 import { DocumentMetadata } from './DocumentProtocol';
 import { detectDocumentType, uriToPath } from './DocumentUtils';
 import { parseJson } from './JsonParser';
-import { parseYaml } from './YamlParser';
+import { parseValidYaml } from './YamlParser';
 
 export class Document {
     private readonly log = LoggerFactory.getLogger(Document);
@@ -44,7 +44,7 @@ export class Document {
         if (this.documentType === DocumentType.JSON) {
             return parseJson(this.contents());
         }
-        return parseYaml(this.contents(), 0, true);
+        return parseValidYaml(this.contents());
     }
 
     public getLine(lineNumber: number): string | undefined {

src/document/Document.ts

@@ -37,6 +37,10 @@ export function parseYaml(yamlString: string, parseAttempt: number = 0, jsonPars
     }
 }
 
+export function parseValidYaml(validYamlString: string): any {
+    return load(validYamlString, { schema: CloudFormationSchema });
+}
+
 const CloudFormationYamlTypes = [
     // !Ref
     new Type('!Ref', {

src/document/YamlParser.ts

@@ -156,13 +156,12 @@ describe('Document', () => {
             expect(result).toBeDefined();
         });
 
-        it('should handle invalid YAML gracefully', () => {
-            const content = 'invalid:\n  - yaml\n    - structure';
+        it('should throw for invalid YAML', () => {
+            const content = 'key: value\n  invalid: indentation';
             const textDocument = TextDocument.create('file:///test.yaml', 'yaml', 1, content);
             const doc = new Document(textDocument);
 
-            const result = doc.getParsedDocumentContent();
-            expect(result).toBeDefined();
+            expect(() => doc.getParsedDocumentContent()).toThrow();
         });
     });
 });