Update paths for artifacts (#250)

Author: satyakigh

src/datastore/LMDB.ts

@@ -51,21 +51,22 @@ export class LMDBStore implements DataStore {
 export class LMDBStoreFactory implements DataStoreFactory {
     @Telemetry({ scope: 'LMDB.Global' }) private readonly telemetry!: ScopedTelemetry;
 
-    private readonly rootDir = pathToArtifact('lmdb');
-    private readonly storePath = join(this.rootDir, Version);
+    private readonly storePath: string;
     private readonly timeout: NodeJS.Timeout;
-
-    private readonly env: RootDatabase = open({
-        path: this.storePath,
-        maxDbs: 10, // 10 max databases
-        mapSize: 100 * 1024 * 1024, // 100MB max size
-        encoding: Encoding,
-        encryptionKey: encryptionStrategy(Version),
-    });
+    private readonly env: RootDatabase;
 
     private readonly stores = new Map<string, LMDBStore>();
 
-    constructor() {
+    constructor(private readonly rootDir: string = pathToArtifact('lmdb')) {
+        this.storePath = join(rootDir, Version);
+        this.env = open({
+            path: this.storePath,
+            maxDbs: 10, // 10 max databases
+            mapSize: 100 * 1024 * 1024, // 100MB max size
+            encoding: Encoding,
+            encryptionKey: encryptionStrategy(Version),
+        });
+
         this.registerLMDBGauges();
 
         this.timeout = setTimeout(

src/telemetry/LoggerFactory.ts

@@ -20,7 +20,6 @@ export const LogLevel: Record<LevelWithSilent, number> = {
 } as const;
 
 export class LoggerFactory implements Closeable {
-    private static readonly LogsDirectory = pathToArtifact('logs');
     private static readonly MaxFileSize = 50 * 1024 * 1024; // 50MB
 
     private static readonly _instance: LoggerFactory = new LoggerFactory();
@@ -30,7 +29,10 @@ export class LoggerFactory implements Closeable {
     private readonly loggers = new Map<string, Logger>();
     private readonly interval: NodeJS.Timeout;
 
-    private constructor(level?: LevelWithSilent) {
+    private constructor(
+        private readonly logsDirectory: string = pathToArtifact('logs'),
+        level?: LevelWithSilent,
+    ) {
         this.logLevel = level ?? TelemetrySettings.logLevel;
 
         this.baseLogger = pino({
@@ -51,7 +53,7 @@ export class LoggerFactory implements Closeable {
                         target: 'pino/file',
                         options: {
                             destination: join(
-                                LoggerFactory.LogsDirectory,
+                                logsDirectory,
                                 `${ExtensionId}-${DateTime.utc().toFormat('yyyy-MM-dd')}.log`,
                             ),
                             mkdir: true,
@@ -72,13 +74,13 @@ export class LoggerFactory implements Closeable {
 
     private async cleanOldLogs() {
         try {
-            const files = await readdir(LoggerFactory.LogsDirectory);
+            const files = await readdir(this.logsDirectory);
             const oneWeekAgo = DateTime.utc().minus({ weeks: 1 });
 
             for (const file of files) {
                 if (!file.endsWith('.log')) continue;
 
-                const filePath = join(LoggerFactory.LogsDirectory, file);
+                const filePath = join(this.logsDirectory, file);
                 const stats = await stat(filePath);
 
                 if (DateTime.fromJSDate(stats.mtime) < oneWeekAgo) {
@@ -94,12 +96,12 @@ export class LoggerFactory implements Closeable {
 
     private async trimLogs() {
         try {
-            const files = await readdir(LoggerFactory.LogsDirectory);
+            const files = await readdir(this.logsDirectory);
 
             for (const file of files) {
                 if (!file.endsWith('.log')) continue;
 
-                const filePath = join(LoggerFactory.LogsDirectory, file);
+                const filePath = join(this.logsDirectory, file);
                 const stats = await stat(filePath);
 
                 if (stats.size > LoggerFactory.MaxFileSize) {

tst/unit/datastore/LMDB.test.ts

@@ -1,27 +1,20 @@
 import fs from 'fs';
-import path from 'path';
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import path, { join } from 'path';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { DataStore } from '../../../src/datastore/DataStore';
 import { LMDBStoreFactory } from '../../../src/datastore/LMDB';
 
-const tstDir = 'tmp-tst';
-vi.mock('../../../src/utils/ArtifactsDir', () => ({
-    pathToArtifact: vi.fn().mockImplementation((dir) => {
-        return path.join(process.cwd(), tstDir, dir ?? '');
-    }),
-}));
-
 describe('LMDB', () => {
     let lmdbFactory: LMDBStoreFactory;
     let lmdbStore: DataStore;
-    const testDir = path.join(process.cwd(), tstDir);
+    const testDir = join(path.join(process.cwd(), 'tmp-tst'), 'lmdb');
 
     beforeEach(() => {
         if (!fs.existsSync(testDir)) {
             fs.mkdirSync(testDir, { recursive: true });
         }
 
-        lmdbFactory = new LMDBStoreFactory();
+        lmdbFactory = new LMDBStoreFactory(testDir);
         lmdbStore = lmdbFactory.getOrCreate('test-store');
     });
 
@@ -205,7 +198,7 @@ describe('LMDB', () => {
             await lmdbFactory.close();
 
             // Create new instance that should load from the same files
-            const newFactory = new LMDBStoreFactory();
+            const newFactory = new LMDBStoreFactory(testDir);
             const newStore = newFactory.getOrCreate('test-store');
             const result = newStore.get<typeof value>(key);