added feature flagfor top level section hover

Author: Deep Furiya

src/hover/HoverRouter.ts

@@ -136,7 +136,7 @@ export class HoverRouter implements SettingsConfigurable, Closeable {
 
     private createHoverProviders(schemaRetriever: SchemaRetriever): Map<HoverType, HoverProvider> {
         const hoverProviderMap = new Map<HoverType, HoverProvider>();
-        hoverProviderMap.set(HoverType.TopLevelSection, new TemplateSectionHoverProvider());
+        hoverProviderMap.set(HoverType.TopLevelSection, new TemplateSectionHoverProvider(this.constantsFeatureFlag));
         hoverProviderMap.set(HoverType.ResourceSection, new ResourceSectionHoverProvider(schemaRetriever));
         hoverProviderMap.set(HoverType.Parameter, new ParameterHoverProvider());
         hoverProviderMap.set(HoverType.ParameterAttribute, new ParameterAttributeHoverProvider());

src/hover/TemplateSectionHoverProvider.ts

@@ -1,12 +1,19 @@
 import { templateSectionDocsMap } from '../artifacts/TemplateSectionDocs';
 import { Context } from '../context/Context';
 import { TopLevelSection } from '../context/ContextType';
+import { FeatureFlag } from '../featureFlag/FeatureFlagI';
 import { Measure } from '../telemetry/TelemetryDecorator';
 import { HoverProvider } from './HoverProvider';
 
 export class TemplateSectionHoverProvider implements HoverProvider {
+    constructor(private readonly constantsFeatureFlag: FeatureFlag) {}
+
     @Measure({ name: 'getInformation' })
     getInformation(context: Context): string | undefined {
+        if (context.text === String(TopLevelSection.Constants) && !this.constantsFeatureFlag.isEnabled()) {
+            return undefined;
+        }
+
         return templateSectionDocsMap.get(context.text as TopLevelSection);
     }
 }

tst/unit/hover/HoverRouter.test.ts

@@ -31,6 +31,7 @@ describe('HoverRouter', () => {
     let hoverRouter: HoverRouter;
     let mockContextManager: StubbedInstance<ContextManager>;
     const params = docPosition('file:///test.yaml', 0, 0);
+    const mockFeatureFlag = { isEnabled: () => true, describe: () => 'Constants feature flag' };
 
     beforeEach(() => {
         // Reset mocks
@@ -58,7 +59,11 @@ describe('HoverRouter', () => {
         }));
 
         const mockComponents = createMockComponents();
-        hoverRouter = new HoverRouter(mockComponents.core.contextManager, mockComponents.external.schemaRetriever);
+        hoverRouter = new HoverRouter(
+            mockComponents.core.contextManager,
+            mockComponents.external.schemaRetriever,
+            mockFeatureFlag,
+        );
         mockContextManager = mockComponents.contextManager;
     });
 
@@ -104,6 +109,7 @@ describe('HoverRouter', () => {
             routerWithMockedProvider = new HoverRouter(
                 mockComponents.core.contextManager,
                 mockComponents.external.schemaRetriever,
+                mockFeatureFlag,
             );
             mockContextManager = mockComponents.contextManager;
         });
@@ -116,6 +122,7 @@ describe('HoverRouter', () => {
             const routerWithResourceDoc = new HoverRouter(
                 mockComponents.core.contextManager,
                 mockComponents.external.schemaRetriever,
+                mockFeatureFlag,
             );
             const mockContextManagerWithDoc = mockComponents.contextManager;
 
@@ -182,6 +189,7 @@ describe('HoverRouter', () => {
             const routerWithResourceDoc = new HoverRouter(
                 mockComponents.core.contextManager,
                 mockComponents.external.schemaRetriever,
+                mockFeatureFlag,
             );
             const mockContextManagerWithDoc = mockComponents.contextManager;
 

tst/unit/hover/TemplateSectionHoverProvider.test.ts

@@ -6,9 +6,11 @@ import { createTopLevelContext as topLevelContext } from '../../utils/MockContex
 
 describe('TemplateSectionHoverProvider', () => {
     let hoverProvider: TemplateSectionHoverProvider;
+    const mockFeatureFlagEnabled = { isEnabled: () => true, describe: () => 'Constants feature flag' };
+    const mockFeatureFlagDisabled = { isEnabled: () => false, describe: () => 'Constants feature flag' };
 
     beforeEach(() => {
-        hoverProvider = new TemplateSectionHoverProvider();
+        hoverProvider = new TemplateSectionHoverProvider(mockFeatureFlagEnabled);
     });
 
     function createTopLevelContext(section: string) {
@@ -95,6 +97,26 @@ describe('TemplateSectionHoverProvider', () => {
         expect(result).toBe(templateSectionDocsMap.get(TopLevelSection.Description));
     });
 
+    it('should return documentation for Constants section when feature flag is enabled', () => {
+        const provider = new TemplateSectionHoverProvider(mockFeatureFlagEnabled);
+        const mockContext = createTopLevelContext(TopLevelSection.Constants);
+
+        const result = provider.getInformation(mockContext);
+
+        expect(result).toBe(templateSectionDocsMap.get(TopLevelSection.Constants));
+        expect(result).toBeDefined();
+        expect(result).toContain('Constants');
+    });
+
+    it('should return undefined for Constants section when feature flag is disabled', () => {
+        const provider = new TemplateSectionHoverProvider(mockFeatureFlagDisabled);
+        const mockContext = createTopLevelContext(TopLevelSection.Constants);
+
+        const result = provider.getInformation(mockContext);
+
+        expect(result).toBeUndefined();
+    });
+
     it('should return undefined for Unknown section', () => {
         const mockContext = createTopLevelContext('SomeUnknownSection');
         const result = hoverProvider.getInformation(mockContext);

tst/utils/TemplateBuilder.ts

@@ -143,7 +143,8 @@ export class TemplateBuilder {
             this.schemaRetriever,
             undefined,
         );
-        this.hoverRouter = new HoverRouter(this.contextManager, this.schemaRetriever);
+        const mockFeatureFlag = { isEnabled: () => true, describe: () => 'Constants feature flag' };
+        this.hoverRouter = new HoverRouter(this.contextManager, this.schemaRetriever, mockFeatureFlag);
         this.initialize(startingContent);
     }