Skip to content

Commit c853172

Browse files
Zee2413gemammercado
Zee2413
authored and
gemammercado
committed
change snippet autocomplete icon from box to lines
1 parent d9558e4 commit c853172

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

‎src/autocomplete/ResourceEntityCompletionProvider.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class ResourceEntityCompletionProvider implements CompletionProvider, Con
6262
): ExtendedCompletionItem {
6363
const snippet = this.generateRequiredPropertiesSnippet(schema, context.documentType);
6464

65-
const completionItem: ExtendedCompletionItem = createCompletionItem('Properties', CompletionItemKind.Snippet, {
65+
const completionItem: ExtendedCompletionItem = createCompletionItem('Properties', CompletionItemKind.File, {
6666
insertText: snippet,
6767
data: { type: 'object' },
6868
});

‎src/autocomplete/TopLevelSectionCompletionProvider.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ ${CompletionFormatter.getIndentPlaceholder(1)}\${1:ConditionName}: $2`,
144144

145145
snippet = applySnippetIndentation(snippet, this.editorSettings, context.documentType);
146146

147-
const completionItem: ExtendedCompletionItem = createCompletionItem(section, CompletionItemKind.Snippet, {
147+
const completionItem: ExtendedCompletionItem = createCompletionItem(section, CompletionItemKind.File, {
148148
insertText: snippet,
149149
data: { type: 'object' },
150150
});

‎tst/unit/autocomplete/ResourceEntityCompletionProvider.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ describe('ResourceEntityCompletionProvider', () => {
154154
expect(propertiesItem).toBeDefined();
155155

156156
// Verify it's a snippet
157-
expect(propertiesItem!.kind).toBe(CompletionItemKind.Snippet);
157+
expect(propertiesItem!.kind).toBe(CompletionItemKind.File);
158158
expect(propertiesItem!.insertTextFormat).toBe(InsertTextFormat.Snippet);
159159

160160
// Verify data type is object

‎tst/unit/autocomplete/TopLevelSectionCompletionProvider.test.ts‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('TopLevelSectionCompletionProvider', () => {
6161
expect(regularSections).toHaveLength(10);
6262

6363
// Should return all snippet sections
64-
const snippetSections = result!.filter((item) => item.kind === CompletionItemKind.Snippet);
64+
const snippetSections = result!.filter((item) => item.kind === CompletionItemKind.File);
6565
expect(snippetSections).toHaveLength(5);
6666

6767
// Should return all sections without fuzzy search modifications
@@ -182,16 +182,16 @@ describe('TopLevelSectionCompletionProvider', () => {
182182

183183
// Find snippet completions for Resources, Parameters, Outputs, and Conditions
184184
const resourcesSnippet = result!.find(
185-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
185+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
186186
);
187187
const parametersSnippet = result!.find(
188-
(item) => item.label === 'Parameters' && item.kind === CompletionItemKind.Snippet,
188+
(item) => item.label === 'Parameters' && item.kind === CompletionItemKind.File,
189189
);
190190
const outputsSnippet = result!.find(
191-
(item) => item.label === 'Outputs' && item.kind === CompletionItemKind.Snippet,
191+
(item) => item.label === 'Outputs' && item.kind === CompletionItemKind.File,
192192
);
193193
const conditionsSnippet = result!.find(
194-
(item) => item.label === 'Conditions' && item.kind === CompletionItemKind.Snippet,
194+
(item) => item.label === 'Conditions' && item.kind === CompletionItemKind.File,
195195
);
196196

197197
// Verify that all snippet completions exist
@@ -218,7 +218,7 @@ describe('TopLevelSectionCompletionProvider', () => {
218218

219219
// Find the Resources snippet
220220
const resourcesSnippet = result!.find(
221-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
221+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
222222
);
223223

224224
expect(resourcesSnippet).toBeDefined();
@@ -239,7 +239,7 @@ describe('TopLevelSectionCompletionProvider', () => {
239239

240240
// Find the Resources snippet
241241
const resourcesSnippet = result!.find(
242-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
242+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
243243
);
244244

245245
expect(resourcesSnippet).toBeDefined();
@@ -293,7 +293,7 @@ describe('TopLevelSectionCompletionProvider', () => {
293293

294294
// Find the Parameters snippet
295295
const parametersSnippet = result!.find(
296-
(item) => item.label === 'Parameters' && item.kind === CompletionItemKind.Snippet,
296+
(item) => item.label === 'Parameters' && item.kind === CompletionItemKind.File,
297297
);
298298

299299
expect(parametersSnippet).toBeDefined();
@@ -308,7 +308,7 @@ describe('TopLevelSectionCompletionProvider', () => {
308308

309309
// Find the Outputs snippet
310310
const outputsSnippet = result!.find(
311-
(item) => item.label === 'Outputs' && item.kind === CompletionItemKind.Snippet,
311+
(item) => item.label === 'Outputs' && item.kind === CompletionItemKind.File,
312312
);
313313

314314
expect(outputsSnippet).toBeDefined();
@@ -323,7 +323,7 @@ describe('TopLevelSectionCompletionProvider', () => {
323323

324324
// Find the Conditions snippet
325325
const conditionsSnippet = result!.find(
326-
(item) => item.label === 'Conditions' && item.kind === CompletionItemKind.Snippet,
326+
(item) => item.label === 'Conditions' && item.kind === CompletionItemKind.File,
327327
);
328328

329329
expect(conditionsSnippet).toBeDefined();
@@ -341,21 +341,21 @@ describe('TopLevelSectionCompletionProvider', () => {
341341

342342
// Verify that defined sections are filtered out from snippets
343343
const resourcesSnippet = result!.find(
344-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
344+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
345345
);
346346
const parametersSnippet = result!.find(
347-
(item) => item.label === 'Parameters' && item.kind === CompletionItemKind.Snippet,
347+
(item) => item.label === 'Parameters' && item.kind === CompletionItemKind.File,
348348
);
349349

350350
expect(resourcesSnippet).toBeUndefined();
351351
expect(parametersSnippet).toBeUndefined();
352352

353353
// But other snippets should still be there
354354
const outputsSnippet = result!.find(
355-
(item) => item.label === 'Outputs' && item.kind === CompletionItemKind.Snippet,
355+
(item) => item.label === 'Outputs' && item.kind === CompletionItemKind.File,
356356
);
357357
const conditionsSnippet = result!.find(
358-
(item) => item.label === 'Conditions' && item.kind === CompletionItemKind.Snippet,
358+
(item) => item.label === 'Conditions' && item.kind === CompletionItemKind.File,
359359
);
360360

361361
expect(outputsSnippet).toBeDefined();
@@ -389,7 +389,7 @@ describe('TopLevelSectionCompletionProvider', () => {
389389
const result = testProvider.getCompletions(mockContext, mockParams);
390390

391391
const resourcesSnippet = result!.find(
392-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
392+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
393393
);
394394

395395
expect(resourcesSnippet).toBeDefined();
@@ -422,7 +422,7 @@ describe('TopLevelSectionCompletionProvider', () => {
422422
const result = testProvider.getCompletions(mockContext, mockParams);
423423

424424
const resourcesSnippet = result!.find(
425-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
425+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
426426
);
427427

428428
expect(resourcesSnippet).toBeDefined();
@@ -457,7 +457,7 @@ describe('TopLevelSectionCompletionProvider', () => {
457457
const result = testProvider.getCompletions(mockContext, mockParams);
458458

459459
const resourcesSnippet = result!.find(
460-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
460+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
461461
);
462462

463463
expect(resourcesSnippet).toBeDefined();
@@ -497,7 +497,7 @@ describe('TopLevelSectionCompletionProvider', () => {
497497
const result = testProvider.getCompletions(mockContext, mockParams);
498498

499499
const resourcesSnippet = result!.find(
500-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
500+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
501501
);
502502

503503
expect(resourcesSnippet).toBeDefined();
@@ -537,7 +537,7 @@ describe('TopLevelSectionCompletionProvider', () => {
537537
const result = testProvider.getCompletions(mockContext, mockParams);
538538

539539
const resourcesSnippet = result!.find(
540-
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.Snippet,
540+
(item) => item.label === 'Resources' && item.kind === CompletionItemKind.File,
541541
);
542542

543543
expect(resourcesSnippet).toBeDefined();

0 commit comments

Comments
 (0)