Remove validate deployment from codelens (#251)

* Remove validate deployment from codelens

* Updated README

Author: rongyamazon

README.md

@@ -49,8 +49,7 @@ The server implements the Language Server Protocol (LSP) to enable code editors
 - **Artifact Export** - Export and upload template artifacts to S3 for deployment
 
 ### Code Lens Actions
-- **Validate Deployment** - Validate template deployment from the editor
-- **Deploy Template** - Deploy templates with a single click
+- **Validate and Deploy** - Validate and deploy templates with a single click
 - **Open Stack Template** - Open managed stack templates for resources
 
 ### Advanced Capabilities

src/codeLens/StackActionsCodeLens.ts

@@ -5,12 +5,10 @@ import { SyntaxTreeManager } from '../context/syntaxtree/SyntaxTreeManager';
 import { Document } from '../document/Document';
 
 const STACK_ACTION_TITLES = {
-    VALIDATE_DEPLOYMENT: 'Validate Deployment',
-    DEPLOY: 'Deploy Template',
+    DEPLOY: 'Validate and Deploy',
 } as const;
 
 const STACK_ACTION_COMMANDS = {
-    VALIDATE_DEPLOYMENT: 'aws.cloudformation.api.validateDeployment',
     DEPLOY: 'aws.cloudformation.api.deployTemplate',
 } as const;
 
@@ -49,14 +47,6 @@ export function getStackActionsCodeLenses(
     const range = Range.create(Position.create(codeLensLine, 0), Position.create(codeLensLine, 0));
 
     return [
-        {
-            range,
-            command: {
-                title: STACK_ACTION_TITLES.VALIDATE_DEPLOYMENT,
-                command: STACK_ACTION_COMMANDS.VALIDATE_DEPLOYMENT,
-                arguments: [uri],
-            },
-        },
         {
             range,
             command: {

tst/unit/codeLens/StackActionsCodeLens.test.ts

@@ -68,7 +68,7 @@ describe('StackActionsCodeLens', () => {
         expect(result).toEqual([]);
     });
 
-    it('should return two code lenses for valid CFN template with Resources', () => {
+    it('should return one code lens for valid CFN template with Resources', () => {
         mockSyntaxTreeManager.getSyntaxTree.returns({ rootNode: {} } as any);
         mockGetEntityMap.mockReturnValue(new Map([['Bucket', {}]]));
 
@@ -78,13 +78,10 @@ describe('StackActionsCodeLens', () => {
 
         const result = getStackActionsCodeLenses('file:///test.yaml', document, mockSyntaxTreeManager);
 
-        expect(result).toHaveLength(2);
-        expect(result[0].command?.title).toBe('Validate Deployment');
-        expect(result[0].command?.command).toBe('aws.cloudformation.api.validateDeployment');
+        expect(result).toHaveLength(1);
+        expect(result[0].command?.title).toBe('Validate and Deploy');
+        expect(result[0].command?.command).toBe('aws.cloudformation.api.deployTemplate');
         expect(result[0].command?.arguments).toEqual(['file:///test.yaml']);
-        expect(result[1].command?.title).toBe('Deploy Template');
-        expect(result[1].command?.command).toBe('aws.cloudformation.api.deployTemplate');
-        expect(result[1].command?.arguments).toEqual(['file:///test.yaml']);
     });
 
     it('should place code lens on line 0 for simple template', () => {
@@ -165,7 +162,7 @@ describe('StackActionsCodeLens', () => {
 
         const result = getStackActionsCodeLenses('file:///test.yaml', document, mockSyntaxTreeManager);
 
-        expect(result).toHaveLength(2);
+        expect(result).toHaveLength(1);
         expect(result[0].range.start.line).toBe(0);
     });
 
@@ -184,7 +181,7 @@ describe('StackActionsCodeLens', () => {
 
         const result = getStackActionsCodeLenses('file:///test.yaml', document, mockSyntaxTreeManager);
 
-        expect(result).toHaveLength(2);
+        expect(result).toHaveLength(1);
     });
 
     it('should handle JSON template', () => {
@@ -197,7 +194,7 @@ describe('StackActionsCodeLens', () => {
 
         const result = getStackActionsCodeLenses('file:///test.json', document, mockSyntaxTreeManager);
 
-        expect(result).toHaveLength(2);
+        expect(result).toHaveLength(1);
     });
 
     it('should handle template with multiple resources', () => {
@@ -221,7 +218,7 @@ describe('StackActionsCodeLens', () => {
 
         const result = getStackActionsCodeLenses('file:///test.yaml', document, mockSyntaxTreeManager);
 
-        expect(result).toHaveLength(2);
+        expect(result).toHaveLength(1);
     });
 
     it('should handle whitespace-only lines correctly', () => {

tst/unit/handlers/CodeLensHandler.test.ts

@@ -78,10 +78,9 @@ describe('CodeLensHandler', () => {
 
         const result = await handler(params, CancellationToken.None);
 
-        expect(result).toHaveLength(3);
-        expect(result[0].command?.title).toBe('Validate Deployment');
-        expect(result[1].command?.title).toBe('Deploy Template');
-        expect(result[2].command?.title).toBe('Open Stack Template');
+        expect(result).toHaveLength(2);
+        expect(result[0].command?.title).toBe('Validate and Deploy');
+        expect(result[1].command?.title).toBe('Open Stack Template');
     });
 
     it('should not return stack actions for empty files', async () => {
@@ -161,8 +160,7 @@ describe('CodeLensHandler', () => {
 
         const result = await handler(params, CancellationToken.None);
 
-        expect(result).toHaveLength(2);
+        expect(result).toHaveLength(1);
         expect(result[0].command?.arguments).toEqual(['file:///test.yaml']);
-        expect(result[1].command?.arguments).toEqual(['file:///test.yaml']);
     });
 });