wrap deferred exit(err) in functor (#343)

Updates the generated code that defers a call to `exit(err)` for the
resource logger to wrap the defer in a temporary functor that then calls
`exit(err)`.

See aws-controllers-k8s/runtime#93 for
explanation.

Signed-off-by: Jay Pipes <[email protected]>

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Author: jaypipes

templates/pkg/resource/references_read_referenced_resource.go.tpl

@@ -51,4 +51,4 @@ Where field is of type 'Field' from aws-controllers-k8s/code-generator/pkg/model
 					"{{ .FieldConfig.References.Path }}")
 			}
 			{{- end -}}
-{{- end -}}
+{{- end -}}

templates/pkg/resource/sdk.go.tpl

@@ -54,7 +54,9 @@ func (rm *resourceManager) sdkCreate(
 ) (created *resource, err error) {
 	rlog := ackrtlog.FromContext(ctx)
 	exit := rlog.Trace("rm.sdkCreate")
-	defer exit(err)
+	defer func() {
+		exit(err)
+	}()
 
 {{- if $hookCode := Hook .CRD "sdk_create_pre_build_request" }}
 {{ $hookCode }}
@@ -133,7 +135,9 @@ func (rm *resourceManager) sdkDelete(
 ) (latest *resource, err error) {
 	rlog := ackrtlog.FromContext(ctx)
 	exit := rlog.Trace("rm.sdkDelete")
-	defer exit(err)
+	defer func() {
+		exit(err)
+	}()
 
 {{- if .CRD.Ops.Delete }}
 {{- if $hookCode := Hook .CRD "sdk_delete_pre_build_request" }}

templates/pkg/resource/sdk_find_get_attributes.go.tpl

@@ -5,7 +5,9 @@ func (rm *resourceManager) sdkFind(
 ) (latest *resource, err error) {
 	rlog := ackrtlog.FromContext(ctx)
 	exit := rlog.Trace("rm.sdkFind")
-	defer exit(err)
+	defer func() {
+		exit(err)
+	}()
 
 {{- if $hookCode := Hook .CRD "sdk_get_attributes_pre_build_request" }}
 {{ $hookCode }}

templates/pkg/resource/sdk_find_read_many.go.tpl

@@ -5,7 +5,9 @@ func (rm *resourceManager) sdkFind(
 ) (latest *resource, err error) {
 	rlog := ackrtlog.FromContext(ctx)
 	exit := rlog.Trace("rm.sdkFind")
-	defer exit(err)
+	defer func() {
+		exit(err)
+	}()
 
 {{- if $hookCode := Hook .CRD "sdk_read_many_pre_build_request" }}
 {{ $hookCode }}

templates/pkg/resource/sdk_find_read_one.go.tpl

@@ -5,7 +5,9 @@ func (rm *resourceManager) sdkFind(
 ) (latest *resource, err error) {
 	rlog := ackrtlog.FromContext(ctx)
 	exit := rlog.Trace("rm.sdkFind")
-	defer exit(err)
+	defer func() {
+		exit(err)
+	}()
 
 {{- if $hookCode := Hook .CRD "sdk_read_one_pre_build_request" }}
 {{ $hookCode }}

templates/pkg/resource/sdk_update.go.tpl

@@ -7,7 +7,9 @@ func (rm *resourceManager) sdkUpdate(
 ) (updated *resource, err error) {
 	rlog := ackrtlog.FromContext(ctx)
 	exit := rlog.Trace("rm.sdkUpdate")
-	defer exit(err)
+	defer func() {
+		exit(err)
+	}()
 
 {{- if $hookCode := Hook .CRD "sdk_update_pre_build_request" }}
 {{ $hookCode }}

templates/pkg/resource/sdk_update_set_attributes.go.tpl

@@ -5,6 +5,12 @@ func (rm *resourceManager) sdkUpdate(
 	latest *resource,
 	delta *ackcompare.Delta,
 ) (*resource, error) {
+	rlog := ackrtlog.FromContext(ctx)
+	exit := rlog.Trace("rm.sdkUpdate")
+	defer func() {
+		exit(err)
+	}()
+
 	// If any required fields in the input shape are missing, AWS resource is
 	// not created yet. And sdkUpdate should never be called if this is the
 	// case, and it's an error in the generated code if it is...