Skip to content

Commit 6865258

Browse files
authored
Merge pull request #66 from A-Hilaly/issue/773/sdkfind-1
Panic if input field renames are not part of a resource spec/status fields
2 parents cba1bea + cfefbc1 commit 6865258

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

pkg/generate/code/set_resource.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,16 +469,22 @@ func setResourceReadMany(
469469
var targetMemberShapeRef *awssdkmodel.ShapeRef
470470
targetAdaptedVarName := targetVarName
471471
// Check that the field has potentially been renamed
472-
renamedName, _ := r.InputFieldRename(
472+
renamedName, foundInputFieldRename := r.InputFieldRename(
473473
op.Name, memberName,
474474
)
475475
f, found = r.SpecFields[renamedName]
476476
if found {
477477
targetAdaptedVarName += cfg.PrefixConfig.SpecField
478478
} else {
479-
f, found = r.StatusFields[memberName]
479+
f, found = r.StatusFields[renamedName]
480480
if !found {
481-
// TODO(jaypipes): check generator config for exceptions?
481+
if foundInputFieldRename {
482+
msg := fmt.Sprintf(
483+
"Input field rename %s for operation %s is not part of %s Spec or Status fields",
484+
memberName, op.Name, r.Names.Camel,
485+
)
486+
panic(msg)
487+
}
482488
continue
483489
}
484490
targetAdaptedVarName += cfg.PrefixConfig.StatusField
@@ -521,7 +527,7 @@ func setResourceReadMany(
521527
// continue
522528
// }
523529
// }
524-
if util.InStrings(memberName, matchFieldNames) {
530+
if util.InStrings(renamedName, matchFieldNames) {
525531
out += fmt.Sprintf(
526532
"%s\t\tif %s.%s != nil {\n",
527533
indent,

0 commit comments

Comments
 (0)