Skip to content

Commit 89b0a10

Browse files
authored
Fix type of tolerations in helm chart (#267)
At the moment, the helm chart treats the deployment's tolerations as an object (similarly to nodeSelector). In the Deployment manifest however tolerations are an array (in contrast to nodeSelector). This PR makes the deployment's tolerations of type array instead of object. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent a48010c commit 89b0a10

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

templates/helm/values.schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"type": "object"
5252
},
5353
"tolerations": {
54-
"type": "object"
54+
"type": "array"
5555
},
5656
"affinity": {
5757
"type": "object"

templates/helm/values.yaml.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ deployment:
2121
kubernetes.io/os: linux
2222
# Which tolerations to set?
2323
# See: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
24-
tolerations: {}
24+
tolerations: []
2525
# What affinity to set?
2626
# See: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity
2727
affinity: {}

0 commit comments

Comments
 (0)