Skip to content

Commit be27f16

Browse files
committed
crossplane: use ExportedName property of operation calls to specifically match the name that can be used by other packages, otherwise Name can have API date in it, like it does for CloudFront
Signed-off-by: Muvaffak Onus <[email protected]>
1 parent fa05a2b commit be27f16

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

templates/crossplane/pkg/controller.go.tpl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ func (e *external) Observe(ctx context.Context, mg cpresource.Managed) (managed.
6767
if err := e.preObserve(ctx, cr, input); err != nil {
6868
return managed.ExternalObservation{}, errors.Wrap(err, "pre-observe failed")
6969
}
70-
resp, err := e.client.{{ .CRD.Ops.ReadOne.Name }}WithContext(ctx, input)
70+
resp, err := e.client.{{ .CRD.Ops.ReadOne.ExportedName }}WithContext(ctx, input)
7171
if err != nil {
7272
return managed.ExternalObservation{ResourceExists: false}, awsclient.Wrap(cpresource.Ignore(IsNotFound, err), errDescribe)
7373
}
@@ -76,7 +76,7 @@ func (e *external) Observe(ctx context.Context, mg cpresource.Managed) (managed.
7676
if err := e.preObserve(ctx, cr, input); err != nil {
7777
return managed.ExternalObservation{}, errors.Wrap(err, "pre-observe failed")
7878
}
79-
resp, err := e.client.{{ .CRD.Ops.GetAttributes.Name }}WithContext(ctx, input)
79+
resp, err := e.client.{{ .CRD.Ops.GetAttributes.ExportedName }}WithContext(ctx, input)
8080
if err != nil {
8181
return managed.ExternalObservation{ResourceExists: false}, awsclient.Wrap(cpresource.Ignore(IsNotFound, err), errDescribe)
8282
}
@@ -85,7 +85,7 @@ func (e *external) Observe(ctx context.Context, mg cpresource.Managed) (managed.
8585
if err := e.preObserve(ctx, cr, input); err != nil {
8686
return managed.ExternalObservation{}, errors.Wrap(err, "pre-observe failed")
8787
}
88-
resp, err := e.client.{{ .CRD.Ops.ReadMany.Name }}WithContext(ctx, input)
88+
resp, err := e.client.{{ .CRD.Ops.ReadMany.ExportedName }}WithContext(ctx, input)
8989
if err != nil {
9090
return managed.ExternalObservation{ResourceExists: false}, awsclient.Wrap(cpresource.Ignore(IsNotFound, err), errDescribe)
9191
}
@@ -124,7 +124,7 @@ func (e *external) Create(ctx context.Context, mg cpresource.Managed) (managed.E
124124
if err := e.preCreate(ctx, cr, input); err != nil {
125125
return managed.ExternalCreation{}, errors.Wrap(err, "pre-create failed")
126126
}
127-
resp, err := e.client.{{ .CRD.Ops.Create.Name }}WithContext(ctx, input)
127+
resp, err := e.client.{{ .CRD.Ops.Create.ExportedName }}WithContext(ctx, input)
128128
if err != nil {
129129
return managed.ExternalCreation{}, awsclient.Wrap(err, errCreate)
130130
}
@@ -142,7 +142,7 @@ func (e *external) Update(ctx context.Context, mg cpresource.Managed) (managed.E
142142
if err := e.preUpdate(ctx, cr, input); err != nil {
143143
return managed.ExternalUpdate{}, errors.Wrap(err, "pre-update failed")
144144
}
145-
resp, err := e.client.{{ .CRD.Ops.Update.Name }}WithContext(ctx, input)
145+
resp, err := e.client.{{ .CRD.Ops.Update.ExportedName }}WithContext(ctx, input)
146146
if err != nil {
147147
return managed.ExternalUpdate{}, awsclient.Wrap(err, errUpdate)
148148
}
@@ -167,7 +167,7 @@ func (e *external) Delete(ctx context.Context, mg cpresource.Managed) error {
167167
if ignore {
168168
return nil
169169
}
170-
resp, err := e.client.{{ .CRD.Ops.Delete.Name }}WithContext(ctx, input)
170+
resp, err := e.client.{{ .CRD.Ops.Delete.ExportedName }}WithContext(ctx, input)
171171
return e.postDelete(ctx, cr, resp, awsclient.Wrap(cpresource.Ignore(IsNotFound, err), errDelete))
172172
{{- else }}
173173
return e.delete(ctx, mg)

0 commit comments

Comments
 (0)