Correct IdempotencyToken and OID initialism errors (#389)

Prevents IdempotencyToken from becoming IDempotencyToken and Oid from becoming oID.

Signed-off-by: Jay Pipes <[email protected]>

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: jaypipes

pkg/names/names.go

@@ -44,9 +44,10 @@ var (
 		// camel-cased "Ids" refers to a set of Identifiers, so the correct
 		// uppercase representation is "IDs"
 		{"Ids", "IDs", "ids", nil},
-		// Need to prevent "Identifier" from becoming "IDentifier",
-		// and "Idle" from becoming "IDle"
-		{"Id", "ID", "id", regexp.MustCompile("Id(?!entifier|le|entity)", regexp.None)},
+		// Need to prevent "Identifier" from becoming "IDentifier", and "Idle"
+		// from becoming "IDle" and "IdempotencyToken" from becoming
+		// "IDempotencyToken"
+		{"Id", "ID", "id", regexp.MustCompile("Id(?!entifier|le|entity|empotency)", regexp.None)},
 		// Need to prevent "DbInstance" from becoming "dbinstance" when lower
 		// prefix-converted (should be dbInstance). Amazingly, even within just
 		// the RDS API, there are fields named "DbiResourceId",
@@ -120,6 +121,8 @@ var (
 		{"Mfa", "MFA", "mfa", nil},
 		// Prevent "Native" from becoming "NATive"
 		{"Nat", "NAT", "nat", regexp.MustCompile("Nat(?!i)", regexp.None)},
+		// Prevent Oid from becoming oID
+		{"Oid", "OID", "oid", nil},
 		{"Oidc", "OIDC", "oidc", nil},
 		{"Ocsp", "OCSP", "ocsp", nil},
 		// Capitalize the 'd' following RAM in certain cases
@@ -229,7 +232,8 @@ func goName(original string, lowerFirst bool, snake bool) (result string) {
 //
 // Examples:
 //
-//  original   | lowerFirst | output
+//	original   | lowerFirst | output
+//
 // ------------+ ---------- + -------------------------
 // Identifier  | true       | Identifier
 // Identifier  | false      | Identifier

pkg/names/names_test.go

@@ -52,6 +52,7 @@ func TestNames(t *testing.T) {
 		{"Family", "Family", "family", "family"},
 		{"Id", "ID", "id", "id"},
 		{"ID", "ID", "id", "id"},
+		{"IdempotencyToken", "IdempotencyToken", "idempotencyToken", "idempotency_token"},
 		{"Identifier", "Identifier", "identifier", "identifier"},
 		{"IoPerformance", "IOPerformance", "ioPerformance", "io_performance"},
 		{"Iops", "IOPS", "iops", "iops"},
@@ -69,6 +70,7 @@ func TestNames(t *testing.T) {
 		{"NatGateway", "NATGateway", "natGateway", "nat_gateway"},
 		{"NativeAuditFieldsIncluded", "NativeAuditFieldsIncluded", "nativeAuditFieldsIncluded", "native_audit_fields_included"},
 		{"NumberOfAmiToKeep", "NumberOfAMIToKeep", "numberOfAMIToKeep", "number_of_ami_to_keep"},
+		{"OID", "OID", "oid", "oid"},
 		{"Package", "Package", "package_", "package_"},
 		{"Param", "Param", "param", "param"},
 		{"Ram", "RAM", "ram", "ram"},