Remove all references to the stable release (#1804)

Description of changes:
The `stable` releases were never fully supported and most controllers did not keep them up-to-date. Also, the purpose of deploying the "stable" major version could also be achieved using semver ranges with most tooling. This pull request removes all references to the stable release and replaces references to them by talking about GA major versions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: RedbackThomson

docs/content/docs/community/releases.md

@@ -105,10 +105,6 @@ that installs the controller into a target Kubernetes cluster. Both these
 artifacts will have tags that correspond to the Semantic Version Git tag
 applied against the source code repository for the controller.
 
-Service controllers may have a [Stable Helm Chart](#stable-helm-charts) that
-will install a version of the service controller binary that the maintainer
-team is confident will hold up to production use.
-
 ### Semantic Versioning
 
 ACK is a collection of custom Kubernetes controllers, one for each supported
@@ -152,7 +148,7 @@ the SemVer version.
 
 For example, if a Git tag of `v1.2.6` was created on the
 [github.com/aws-controllers-k8s/s3-controller][s3-ctrl] repository, a container
-image with a tag `v1.2.6` would be published to the
+image with a tag `1.2.6` would be published to the
 [public.ecr.aws/aws-controllers-k8s/s3-controller][ecr-ack-ctrl] ECR Public
 repository.
 
@@ -171,7 +167,7 @@ an artifact tag including the SemVer version.
 
 For example, a Git tag of `v1.2.6` on the
 [github.com/aws-controllers-k8s/s3-controller][s3-ctrl]
-repository means a Helm chart with a tag `v1.2.6` would be published to the
+repository means a Helm chart with a tag `1.2.6` would be published to the
 [public.ecr.aws/aws-controllers-k8s/s3-chart][ecr-ack-chart] ECR Public
 repository.
 
@@ -200,69 +196,6 @@ Go's module infrastructure to pin the dependency between the code generator and
 the common runtime.
 {{% /hint %}}
 
-### Stable Helm Charts
-
-{{% hint type="success" title="Tip" %}}
-We [recommend](../../user-docs/install/#install-an-ack-service-controller-with-helm-recommended) using Helm to install an ACK service
-controller.
-{{% /hint %}}
-
-
-Some ACK service controllers will have Helm Charts with a
-`v$MAJOR_VERSION-stable` tag, referred from here out as just a
-"`stable` artifact tag". There will only be one of these tags for the ACK
-service controller **in a major version series**. For example, the full
-`stable` artifact tag for the ElastiCache ACK service controller's "v1" major
-version series would be
-`public.ecr.aws/aws-controllers-k8s/elasticache-chart:v1-stable`.
-
-This `stable` artifact tag points to a Helm chart that has configuration values
-that have been tested with a specific SemVer container image.
-
-Typically these tests are "soak" tests and allow the team maintaining that ACK
-controller's source code to have a high degree of confidence in the
-controller's long-running operation.
-
-{{% hint %}}
-Please note that not all ACK service controllers will have a Helm chart
-with a `stable` artifact tag. Furthermore, there will only ever be a single
-`stable` Helm Chart tag **per major version series of a controller**.
-{{% /hint %}}
-
-
-This `stable` Helm Chart tag (an OCI Artifact tag) will point to different
-Helm Chart packages over time. From time to time, the maintainer team for a
-service controller may update the configuration values and associated SemVer
-container image tag for the controller binary to point to a newer image.
-
-For example, consider the ElastiCache ACK service controller maintainer team
-has executed a series of long-running tests of the
-`public.ecr.aws/aws-controllers-k8s/elasticache-controller` image tagged with
-the `v1.2.6` SemVer tag. The maintainer team is confident that the controller
-is stable for production use. In the `stable` Git branch of the ElastiCache
-service controller's source repository, the team would update the Helm Chart's
-Deployment, setting the `Deployment.spec.template.spec.containers[0].image` to
-`public.ecr.aws/aws-controllers-k8s/elasticache-controller:v1.2.6`.
-
-They then package the Helm Chart and publish it as an OCI Artifact to the
-`public.ecr.aws/aws-controllers-k8s/elasticache-chart` registry, using an OCI
-artifact tag of `v1-stable`.
-
-A couple months later, the maintainer team has added a few minor, non-breaking
-features to their controller along with a number of bug fixes. The latest
-SemVer tag for the ElastiCache controller image is at `v1.3.9`.
-
-The maintainer team has separately been executing long-running tests against
-the `v1.3.2` controller image and are confident that this release is
-appropriate for production use. The maintainer team would update the Helm Chart
-in their `stable` Git branch to have its
-`Deployment.spec.template.spec.containers[0].image` set to
-`public.ecr.aws/aws-controllers-k8s/elasticache-controller:v1.3.2`. They would
-then package this Helm Chart and push overwrite the
-`public.ecr.aws/aws-controllers-k8s/elasticache-chart:v1-stable` OCI Artifact
-tag to point to this newly-updated Helm Chart that refers to the `v1.3.2`
-controller image.
-
 ## Maintenance Phases
 
 As noted above, individual ACK service controllers all use Semantic Versioning
@@ -294,7 +227,7 @@ through long-running "soak" tests and are recommended for production use by the
 team maintaining that controller.
 
 All ACK controllers in the `General Availability` Maintenance Phase will have a
-Helm Chart with the `stable` artifact tag.
+Helm Chart tagged with the major version >0 (eg. `1.0.0`).
 
 Users who submit bug reports using Github Issues that reference a `General
 Availability` controller will have their bug reports prioritized by the

docs/content/docs/contributor-docs/release.md

@@ -114,60 +114,3 @@ git push origin release-$RELEASE_VERSION
 6) `git tag` operation (applied automatically in last step) triggers a postsubmit prowjob which builds container image and then publishes
 both container image and Helm chart to public ECR repository.
 Service team can see the release prowjobs, their status and logs at https://prow.ack.aws.dev/
-
-## Stable Release
-The postsubmit prowjob mentioned above also publishes the stable Helm charts,
-whenever there is a code push on `stable` git branch. Follow the steps below
-to cut a stable release for an ACK controller.
-
-1) Checkout the ACK controller release which will be marked as stable.
-Example below uses s3-controller `0.0.19` release.
-```bash
-cd $GOSRC/github.com/aws-controllers-k8s
-export SERVICE=s3
-export STABLE_RELEASE=<v0.0.19-do-not-copy> #Update this tag for the specific controller
-cd $SERVICE-controller
-git fetch --all --tags
-git checkout -b stable-$STABLE_RELEASE $STABLE_RELEASE
-```
-
-2) Update the helm chart version to the stable version. To learn more about
-nomenclature of stable branch and helm chart version please read our
-[release phase guide](../../community/releases/).
-
-For the above example, replace `version: 0.0.19` inside `helm/Chart.yaml`
-with `version: 0-stable`. Without this update the postsubmit prowjob will
-fail because validation error due to chart version mismatch.
-
-3) Commit your changes from step2
-```bash
-git add helm/Chart.yaml
-git commit -m "Updating the helm chart version for stable release"
-```
-
-4) Determine the remote which points to `aws-controllers-k8s/$SERVICE-controller`
-and not your personal fork. Execute `git remote --verbose` command to find out the
-remote name. Example: In the command below, `origin` points to the
-`aws-controllers-k8s/s3-controller` repository.
-
-```bash
-git remote --verbose
-
-origin  https://github.com/aws-controllers-k8s/s3-controller.git (fetch)
-origin  https://github.com/aws-controllers-k8s/s3-controller.git (push)
-vj      https://github.com/vijtrip2/s3-controller.git (fetch)
-vj      https://github.com/vijtrip2/s3-controller.git (push)
-```
-
-5) Push the changes to the `stable` branch for remote pointing to
-`aws-controllers-k8s/$SERVICE-controller`
-```bash
-git push -u origin stable-$STABLE_RELEASE:stable
-```
-The above command will create a new `stable` branch if it does not exist
-and trigger the ACK postsubmit prowjob for stable release. This prowjob will
-not build a container image and only publishes the helm artifacts with stable tag.
-
-If the git push command fails, use `--force` option to update the upstream
-`stable` branch with your local changes.
-