generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 271
Open
Labels
area/code-generationIssues or PRs as related to controllers or docs code generationIssues or PRs as related to controllers or docs code generationkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.
Description
Describe the bug
The error message produced for scalar fields in the boundary check for floats and ints has inconsistent capitalization of the field name between runs of the code-gen. This results in superfluous changes when making unrelated changes to controllers.
Steps to reproduce
- Pull the latest changes for the ecs-controller repo
- In code-generation re-run
make build-controller - See that some float/int field names will have changed in error messages for the boundary check. Note, the individual fields that have changed aren't consistent.
example field name change.
return nil, fmt.Errorf("error: field iops is of type int32") -> return nil, fmt.Errorf("error: field Iops is of type int32")
Expected outcome
No changes besides ack-generate-meta.yaml are made to the controller.
Environment
- Kubernetes version: N/A
- Using EKS (yes/no), if so version? N/A
- AWS service targeted (S3, RDS, etc.) ECS, but this affects many controllers.
Metadata
Metadata
Assignees
Labels
area/code-generationIssues or PRs as related to controllers or docs code generationIssues or PRs as related to controllers or docs code generationkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.