Why does the metrics service have `type: NodePort`?

[james-callahan]

I'm trying to see why the metrics service has a type of NodePort.
https://github.com/aws-controllers-k8s/code-generator/blame/v0.47.2/templates/config/controller/service.yaml.tpl#L14

This is quite an unusual default; and we found that this resulted in ACK metrics being available to anything in our VPC (thankfully the security group to the outside world was denying it)

[github-actions]

Hello @james-callahan 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.

[knottnt]

@james-callahan Thank you for bring this up. Doing some digging this looks like a mistake and needs to be corrected to use ClusterIP as a default. For time being installing with Helm charts doesn't appear to be impacted by this.

[james-callahan]

Fixed via #600