Skip to content

[EC2][Security Groups] Allow adopt-or-create annotation to use SecurityGroup Name #2561

@shabbskagalwala

Description

@shabbskagalwala

Is your feature request related to a problem?
Currently when managing ACK resources through Kro or any GitOps pipelines we would like to use the annotation services.k8s.aws/adoption-policy: adopt-or-create on SecurityGroups to be able to adopt or create SecurityGroups if one already exists. The current implementation requires the annotation services.k8s.aws/adoption-fields with the id of the security group to be known before hand even when the entire spec of the SecurityGroups is provided.

Describe the solution you'd like
Allow using SecurityGroup names to adopt or create SecurityGroups.

SecurityGroups have unique name identifiers which can make this possible. Instead of depending on the id of the SecurityGroups we could use the annotation services.k8s.aws/adoption-policy: adopt-or-create to adopt a security group if exists or create one.

Chart and EC2 version

name: ec2-chart
repository: oci://public.ecr.aws/aws-controllers-k8s
version: 1.4.8
appVersion: 1.4.8

Metadata

Metadata

Assignees

Labels

area/adoption-annotationIssues or PRs related to ACK Adoption by Annotation featureservice/ec2Indicates issues or PRs that are related to ec2-controller.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions