AWS ACK S3 Controller: Not speficying lifecycle policy rule FILTER causing MalformedXML error

[lochy89]

Describe the bug
If I want to create an S3 bucket with lifecycle policy and do not define any filter within the given rule, not even an empty array, I get the following error message:

Steps to reproduce
Using lifecycle policy without filter defined.

  lifecycle:
    rules:
      - id: RemoveNonCurrentVersionsAfter7Days
        status: Enabled
        noncurrentVersionExpiration:
          noncurrentDays: 7
        # filter: {}

Expected outcome
In my opinion, it would be worth using a default empty array in such cases if the user does not define one.

Environment

• ACK S3 controller version: 1.0.35
• Kubernetes version: 1.29
• Using EKS: yes, version 1.29
• AWS service targeted: S3

Additional context

It would be better if ack can threw more useful error message, as the associated S3 controller did not write any errors in the log. I get this message on the created resource manifest itself, but it would be better if we could also see an error message about the resource spec that is causing the error.
This way we don't need to figure it out from scratch which resource spec is causing the problem.

Thank you very much!

[github-actions]

Hello @lochy89 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.

[rushmash91]

Hi @lochy89,
Thank you for raising this issue!

ACK controllers are designed as declarative wrappers around AWS service APIs that provide a 1:1 mapping between Kubernetes resources and AWS resources. We focus on declarative state management rather than implementing custom strategies or API patterns beyond what AWS natively provides. The S3 API expects filter: {} for speficying lifecycle policy rule.

Thanks again for the feedback!

[rushmash91]

Hi @lochy89, feel free to reopen the issues if you have any comments 🙂
/close

[ack-prow]

@rushmash91: Closing this issue.

In response to this:

Hi @lochy89, feel free to reopen the issues if you have any comments 🙂
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.