EKS: Adopting Pod Identity Association

[JFenstermacher]

Describe the bug
I don't think PodIdentityAssociation(s) are adoptable

Steps to reproduce
I have tried all manner of adoption-fields and it doesn't work.

I have tried all the following:

No adoption-fields just adopt-or-create

annotations:
    services.k8s.aws/adoption-policy: "adopt-or-create"

All manners of adoption-fields

annotations:
    services.k8s.aws/adoption-policy: "adopt"
    services.k8s.aws/adoption-fields: | 
        {
          "clusterName": "***",
          "associationId": "***"
        }

I know clusterName is minimally required, because a error saying it's required appears. All other configurations, and I have tried plenty, don't seem to work.

I have tried adding, name and namespace that appears in the error message for reconciler.

I have tried adding all the fields that are present in a aws eks describe-pod-identity-association request to the adoption-fields.

I have tried adding combinations of the both of them.

Nothing works.

Every single other field changes results in an error of:

adopted resource not found

Expected outcome

I expect that some configuration will allow the adoption of Pod Identity Associations.

Further, I expect your documentation to outline what are the required fields per resource, if it isn't obvious.

Environment

• 1.30
• EKS 1.30
• EKS (Pod Identity Assocation)

[github-actions]

Hello @JFenstermacher 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.

[michaelhtm]

Hello @JFenstermacher,
I believe this is due to the capitalization of id in associationId.
The field name should instead be associationID. https://github.com/aws-controllers-k8s/eks-controller/blob/main/pkg/resource/pod_identity_association/resource.go#L111

[JFenstermacher]

Hey @michaelhtm,

Thank you for the response. I'll test this out today.

This error message never appeared in any logs, "required field missing: associationID".

Also, the describe-pod-identity-association responds with associationId. Beyond reading the code, is there a heuristic here for figuring what the keys are supposed to be when doing an adoption?